Skip to content

Prevent ProjectUpdateRepositoryStorageWorker from deleting repo

John Cai requested to merge jc-prevent-storage-update-deletion into master

What does this MR do?

fixes: https://gitlab.com/gitlab-org/gitaly/-/issues/1318

To prevent ProjectUpdateRepositoryStorageWorker from deleting a repository, check the filesystem_id of the storage. if it's the same, that means it's the same storage path hence the same directory on the same filesystem and we do not want to move the project--otherwise it will result in a deletion.

this MR replaces https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/390

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by John Cai

Merge request reports