Move group "Administration" nav behind feature flag

What does this MR do?

This is a follow up to !28057 (merged). There has been some negative feedback around this change (see thread here: #209020 (closed)) and it probably should have been behind a feature flag from the get go (learning experience ). Because of this we have decided to move this behind a feature flag until we can best determine how to proceed.

Changes

• Moves group "Administration" nav behind group_administration_nav_item feature flag
• Reverts documentation updates made in !28057 (merged). To be further discussed in #213726 (closed)

Local Testing

1. Install an EE license. See https://about.gitlab.com/handbook/developer-onboarding/#working-on-gitlab-ee.
2. Enable these SAML SSO related feature flags: group_saml, enforced_sso, and enforced_sso_requires_session
3. Enable group_saml in config/gitlab.yml. See https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/master/doc/howto/saml.md#gitlab-configuration. Note: Ensure this is added to the development: section of your config
4. Enable group_administration_nav_item feature flag
   • bin/rails console
   • group = Group.find_by(name: 'group name')
   • Feature.enable(:group_administration_nav_item, group)

Screenshots

Page	Before !28057 (merged) was merged	After w/ feature disabled	After w/ feature enabled
Parent Group
Subgroup

Does this MR meet the acceptance criteria?

Conformity

• [-] Changelog entry
• Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• [-] Database guides
• Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers
• [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• [-] Label as security and @ mention @gitlab-com/gl-security/appsec
• [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• [-] Security reports checked/validated by a reviewer from the AppSec team

changed milestone to %12.10

added devopsmanage groupspaces DEPRECATED labels

	1 Warning
	88250e41: The commit subject length is acceptable, but please try to reduce it to 50 characters.. For more information, take a look at our Commit message guidelines.

1 Message

CHANGELOG missing: If this merge request doesn’t need a CHANGELOG entry, feel free to ignore this message. If you want to create a changelog entry for GitLab FOSS, run the following: bin/changelog -m 29084 "Move group "Administration" nav behind feature flag" If you want to create a changelog entry for GitLab EE, run the following instead: bin/changelog --ee -m 29084 "Move group "Administration" nav behind feature flag" Note: Merge requests with ~backstage, ci-build, meta do not trigger this check.

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

Category	Reviewer	Maintainer
backend	Markus Koller (@toupeira)	Douglas Barbosa Alexandre (@dbalexandre)
frontend	Himanshu Kapoor (@himkp)	Tim Zallmann (@timzallmann)

Generated by Danger

changed the description

added feature flag typefeature labels

added 1 commit

• 261bafc0 - Remove changelog entry

Compare with previous version

changed the description

added 2 commits

• 7f7af108 - Move group "Administration" nav behind feature flag
• dd7f7d18 - Remove changelog entry

Compare with previous version

changed the description

changed the description

Overriding DangerBot in favor of reviewers from previous MR (!28057 (merged))

@asubramanian1, @rhardarson can you review this follow up MR since you reviewed the original one? Let me know if you have any questions!

assigned to @asubramanian1 and @rhardarson and unassigned @peterhegman

@mjang1 can you take a peak at this when you have a chance? This MR reverts the documentation changes in !28057 (merged) so we can further discuss in #213726 (closed)

mentioned in issue #209020 (closed)

approved this merge request

assigned to @markrian and unassigned @rhardarson

Thanks @peterhegman . From a doc PoV, I see this is a straight reversion of !28057 (merged). Approving (doc PoV only ) on that basis. Step 1. Thank you. :)

approved this merge request

Thanks @peterhegman for the efforts and detailed explanation on the tests, backend LGTM

unassigned @asubramanian1