Geo Nodes: Disabled vs Empty Sync
What does this MR do?
Closes #13309 (closed)
Currently in the Geo Nodes UI, there isn't a differentiation between when a sync is disabled and when there is nothing to sync. This MR creates that differentiation by leveraging the API to note if the sync is disabled or not. The code for the API can be found in this MR:!28478 (merged)
Additional Cleanup:
With the changes in the above mentioned MR, we no longer needed the featureDisabled
prop, this MR removes that in favor of the itemEnabled
prop as well.
Screenshots
Nothing to Sync | Sync Disabled | |
---|---|---|
before | ![]() |
![]() |
after | ![]() |
![]() |
mock | ![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #13309 (closed)
Edited by Zack Cuddy