Skip to content

Geo Nodes: Disabled vs Empty Sync

Zack Cuddy requested to merge 13309-nothing-to-sync into master

What does this MR do?

Closes #13309 (closed)

Currently in the Geo Nodes UI, there isn't a differentiation between when a sync is disabled and when there is nothing to sync. This MR creates that differentiation by leveraging the API to note if the sync is disabled or not. The code for the API can be found in this MR:!28478 (merged)

Additional Cleanup: With the changes in the above mentioned MR, we no longer needed the featureDisabled prop, this MR removes that in favor of the itemEnabled prop as well.

Screenshots

Nothing to Sync Sync Disabled
before Before_Nothing Before_Disabled
after After_Nothing After_Disabled
mock Mock_Nothing Mock_Disabled

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #13309 (closed)

Edited by Zack Cuddy

Merge request reports