Skip to content

Add support for metrics embeds not backed by the DB

Sarah Yasonik requested to merge sy-transient-embeds into master

What does this MR do?

This MR adds support for metrics embeds to be defined & rendered entirely on the fly, rather than stemming from data in the DB.

This is to enable embedding of metrics based on alerts coming from a manually configured prometheus instance. As these alerts aren't associated with any alerting rules we manage for the user, we don't have record of the alert at the time it begins firing. So this embed type will allow the embed to be defined in GFM as a part of the /metrics_dashboard query params.

This has a disadvantage of a potentially quite long URL - #213276.

Issue: #195739 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Sarah Yasonik

Merge request reports