Add support for metrics embeds not backed by the DB
What does this MR do?
This MR adds support for metrics embeds to be defined & rendered entirely on the fly, rather than stemming from data in the DB.
This is to enable embedding of metrics based on alerts coming from a manually configured prometheus instance. As these alerts aren't associated with any alerting rules we manage for the user, we don't have record of the alert at the time it begins firing. So this embed type will allow the embed to be defined in GFM as a part of the /metrics_dashboard
query params.
This has a disadvantage of a potentially quite long URL - #213276.
Issue: #195739 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required) - Skipping because this isn't actually intended to be used for users
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %12.10
added backend devopsmonitor grouprespond typefeature labels
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Erick Bajao ( @iamricecake
)Douglas Barbosa Alexandre ( @dbalexandre
)test Quality for spec/features/*
Erick Bajao ( @iamricecake
)No maintainer available Generated by
DangerEdited by 🤖 GitLab Bot 🤖mentioned in issue #213276
marked the checklist item Changelog entry as completed
- Resolved by Sarah Yasonik
@k_cook Could you do review for this MR? Thanks in advance!
assigned to @k_cook
mentioned in merge request !28622 (merged)
- Resolved by Sarah Yasonik
unassigned @k_cook
added 611 commits
-
9f655e2a...68617d4e - 610 commits from branch
master
- 645461f6 - Add support for DB-less embeds
-
9f655e2a...68617d4e - 610 commits from branch
@dbalexandre Could you do maintainer review on this?
assigned to @dbalexandre
enabled an automatic merge when the pipeline for da6e591f succeeds
Thanks, @syasonik! LGTM
mentioned in commit c85f0acc
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in issue #195739 (closed)
mentioned in merge request !29734 (merged)