Skip to content
Snippets Groups Projects

Add support for metrics embeds not backed by the DB

Merged Sarah Yasonik requested to merge sy-transient-embeds into master
All threads resolved!

What does this MR do?

This MR adds support for metrics embeds to be defined & rendered entirely on the fly, rather than stemming from data in the DB.

This is to enable embedding of metrics based on alerts coming from a manually configured prometheus instance. As these alerts aren't associated with any alerting rules we manage for the user, we don't have record of the alert at the time it begins firing. So this embed type will allow the embed to be defined in GFM as a part of the /metrics_dashboard query params.

This has a disadvantage of a potentially quite long URL - #213276.

Issue: #195739 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Sarah Yasonik

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Kirstie Cook approved this merge request

    approved this merge request

  • unassigned @k_cook

  • Sarah Yasonik added 1 commit

    added 1 commit

    • 9f655e2a - Add support for DB-less embeds

    Compare with previous version

  • Sarah Yasonik added 611 commits

    added 611 commits

    Compare with previous version

  • Sarah Yasonik resolved all threads

    resolved all threads

  • Author Developer

    @dbalexandre Could you do maintainer review on this? :smile:

  • Douglas Barbosa Alexandre approved this merge request

    approved this merge request

  • Douglas Barbosa Alexandre enabled an automatic merge when the pipeline for da6e591f succeeds

    enabled an automatic merge when the pipeline for da6e591f succeeds

  • mentioned in commit c85f0acc

  • added workflowcanary label and removed workflowstaging label

  • Author Developer

    Verified on staging.

    with time params with time params
    Screen_Shot_2020-04-08_at_1.07.08_PM Screen_Shot_2020-04-08_at_1.07.51_PM
  • added workflowproduction label and removed workflowcanary label

  • mentioned in issue #195739 (closed)

  • Sarah Yasonik mentioned in merge request !29734 (merged)

    mentioned in merge request !29734 (merged)

  • Please register or sign in to reply
    Loading