Skip to content

Create token response should be CREATED

Amy Troschinetz requested to merge create-token--http-response into master

What does this MR do?

Previously, the create token response was HTTP 200 OK. It should really be 201 CREATED as that is what the action is doing: Creating a new deploy token.

Note that this feature is already behind a feature flag as this MR is a followup from !27141 (merged).

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Amy Troschinetz

Merge request reports