Conditional mocking of admin mode in specs by directory
What does this MR do?
Prepare to break !27405 (closed) in chunks by mocking admin mode in spec by directory.
- Keeps the
:do_not_mock_admin_mode
metadata and introduces a new:enable_admin_mode
. The mocking of admin mode is still active like previously, but limited to a set of directories - We'll break !27405 (closed) in multiple MRs that each tackle a subset of the directories, apply the changes in there to the specs and remove mocking of the relevant directories
- This approach also has the nice property of forcing new specs added outside of these directories to have to handle admin mode, as will be the case for all of them when the migration is finished
Related to #31511 (closed)
/cc @bufferoverflow @rpaik @reprazent @ifarkas @rymai
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
mentioned in issue #31511 (closed)
added 1 commit
- 06e78f6d - Conditional mocking of admin mode in specs based on directory
mentioned in merge request siemens/gitlab!17 (closed)
@rymai @reprazent This is ready for review
- Resolved by Diego Louzán
added Community contribution customer labels
assigned to @reprazent
assigned to @ifarkas and unassigned @reprazent
enabled an automatic merge when the pipeline for 06e78f6d succeeds
Thanks @dlouzan, looks good to me too!
MWPS set.mentioned in commit 924829f0
changed milestone to %12.10
mentioned in merge request !25321 (merged)
mentioned in commit 8cf109be
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in commit de437209
mentioned in commit 337f6309
mentioned in commit 64e6b1ec
mentioned in merge request siemens/gitlab!41 (closed)
mentioned in merge request !58530 (closed)
mentioned in merge request !107925 (merged)