Skip to content
Snippets Groups Projects

Conditional mocking of admin mode in specs by directory

All threads resolved!

What does this MR do?

Prepare to break !27405 (closed) in chunks by mocking admin mode in spec by directory.

  • Keeps the :do_not_mock_admin_mode metadata and introduces a new :enable_admin_mode. The mocking of admin mode is still active like previously, but limited to a set of directories
  • We'll break !27405 (closed) in multiple MRs that each tackle a subset of the directories, apply the changes in there to the specs and remove mocking of the relevant directories
  • This approach also has the nice property of forcing new specs added outside of these directories to have to handle admin mode, as will be the case for all of them when the migration is finished

Related to #31511 (closed)

:tools: with :heart: at Siemens

/cc @bufferoverflow @rpaik @reprazent @ifarkas @rymai

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Diego Louzán

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Diego Louzán changed the description

    changed the description

  • Bob Van Landuyt approved this merge request

    approved this merge request

  • Thank you @dlouzan, this looks good to me!

    @ifarkas would you have a moment for the maintainer review?

  • Bob Van Landuyt assigned to @ifarkas and unassigned @reprazent

    assigned to @ifarkas and unassigned @reprazent

  • Diego Louzán resolved all threads

    resolved all threads

  • Imre Farkas approved this merge request

    approved this merge request

  • Imre Farkas enabled an automatic merge when the pipeline for 06e78f6d succeeds

    enabled an automatic merge when the pipeline for 06e78f6d succeeds

  • Thanks @dlouzan, looks good to me too! :rocket: MWPS set.

  • merged

  • Imre Farkas mentioned in commit 924829f0

    mentioned in commit 924829f0

  • Ray Paik changed milestone to %12.10

    changed milestone to %12.10

  • Stan Hu mentioned in merge request !25321 (merged)

    mentioned in merge request !25321 (merged)

  • Stan Hu mentioned in commit 8cf109be

    mentioned in commit 8cf109be

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Stan Hu mentioned in commit de437209

    mentioned in commit de437209

  • Stan Hu mentioned in commit 337f6309

    mentioned in commit 337f6309

  • Stan Hu mentioned in commit 64e6b1ec

    mentioned in commit 64e6b1ec

  • mentioned in merge request siemens/gitlab!41 (closed)

  • Diego Louzán mentioned in merge request !58530 (closed)

    mentioned in merge request !58530 (closed)

  • Jonas Wälter mentioned in merge request !107925 (merged)

    mentioned in merge request !107925 (merged)

  • Please register or sign in to reply
    Loading