Add WebIDE Dark Theme Support
What does this MR do?
Adds support for the dark theme in the Web IDE. Issue: #209808 (closed)
This feature is behind a feature flag. To test:
In the rails console (rails c), enter the following command to enable your feature flag
Feature.enable(:webide_dark_theme)Screenshots
| Section | Screenshot |
|---|---|
| Loading state |  |
| Editing |  |
| Markdown preview |  |
| New from template |  |
| Review tab |  |
| Commit tab |  |
Known Issues
This MR adds dark theme support for most of the Web IDE. There are areas that are not yet covered. Below are those areas with the respective issues:
- Modals: #213828 (closed)
- Right Sidebar: #213826 (closed)
- Project Avatar Icons: #214236 (closed)
- Dropdowns: #213831 (closed)
- Markdown Preview: #214239 (closed)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Himanshu Kapoor