Fix the 'review-deploy' job when RA deployment is manual
What does this MR do?
- Always make the
review-deploy
job manual. - Move
review-build-cng
to thereview
stage so thatreview-build-cng
andreview-deploy
can be started without the other being done first. - Always try to trigger
review-deploy
at the end ofreview-build-cng
. - In
review-deploy
:- If
review-build-cng
is not started, start it. - Wait for
review-build-cng
to finish. - Proceed to deployment.
- At the end, play
review-qa-smoke
andreview-performance
.
- If
- In
review-qa-smoke
andreview-performance
, wait forreview-deploy
to be finished, then download itsenvironment_url.txt
artifact.
Note that #31264 (closed) would allow to avoid most if not all of these workarounds.
Validation
With no frontend change, no deploy
-
The review-build-cng
andreview-deploy
jobs are playable: https://gitlab.com/gitlab-org/gitlab/pipelines/131907868 -
Pipeline shouldn't be stuck in the Running
state
review-deploy
first
With no frontend change, playing -
Play review-deploy
: https://gitlab.com/gitlab-org/gitlab/-/jobs/500096800-
Expect review-build-cng
to be played first -
Expect to wait for review-build-cng
to be done before proceeding to the deploy -
Expect review-qa-smoke
andreview-performance
to be played at the end ofreview-deploy
-
-
Expect review-qa-smoke
andreview-performance
to pass
review-build-cng
first
With no frontend change, playing -
Play review-build-cng
: https://gitlab.com/gitlab-org/gitlab/-/jobs/500543494-
Expect review-deploy
to be played at the end ofreview-build-cng
-
Expect review-qa-smoke
andreview-performance
to be played at the end ofreview-deploy
-
-
-
Expect review-qa-smoke
andreview-performance
to pass
With a frontend change (so that Review App deployment is automatic
-
Expect review-build-cng
to start automatically: https://gitlab.com/gitlab-org/gitlab/-/jobs/492379779-
Expect review-deploy
to be played at the end ofreview-build-cng
-
-
Expect review-qa-smoke
andreview-performance
to start automatically afterreview-deploy
is done -
Expect review-qa-smoke
andreview-performance
to pass
Closes #212354 (closed).
Merge request reports
Activity
changed milestone to %12.10
added Engineering Productivity ci-build severity2 typebug + 1 deleted label
1 Warning 3b761b4d: The commit subject length is acceptable, but please try to reduce it to 50 characters.. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer Engineering Productivity for CI, Danger Albert Salim ( @caalberts
)Bob Van Landuyt ( @reprazent
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 89 commits
-
4bb2ac6d...550d687c - 88 commits from branch
master
- db898f07 - Fix the 'review-deploy' job when RA deployment is manual
-
4bb2ac6d...550d687c - 88 commits from branch
added 1 commit
- fe99278b - Fix the CNG image 'gitlab-unicorn-*' to 'gitlab-webservice-*'
- Resolved by Rémy Coutable
124 $ export CI_ENVIRONMENT_URL="$(cat environment_url.txt)" 125 cat: can't open 'environment_url.txt': No such file or directory 126 $ echo "${CI_ENVIRONMENT_URL}" 127 $ echo "${QA_IMAGE}" 128 registry.gitlab.com/gitlab-org/gitlab/gitlab/gitlab-ee-qa:212354-fix-review-deploy
added 211 commits
-
1c69d876...dc178732 - 210 commits from branch
master
- aaa07537 - Fix the 'review-deploy' job when RA deployment is manual
-
1c69d876...dc178732 - 210 commits from branch
marked the checklist item Play
review-deploy
: https://gitlab.com/gitlab-org/gitlab/-/jobs/486254014 as completedadded 1 commit
- 07c25cef - Fix the 'review-deploy' job when RA deployment is manual
added 1 commit
- b8207c00 - Fix the 'review-deploy' job when RA deployment is manual
added 1 commit
- 625e3aa9 - Fix the 'review-deploy' job when RA deployment is manual
added 1 commit
- 1c3e1c70 - Fix the 'review-deploy' job when RA deployment is manual
added 1 commit
- 5e64aae2 - Fix the 'review-deploy' job when RA deployment is manual
marked the checklist item Play
review-deploy
: https://gitlab.com/gitlab-org/gitlab/-/jobs/486932690 as completedadded 571 commits
-
935efda2...5be42618 - 569 commits from branch
master
- e59e8445 - Fix the 'review-deploy' job when RA deployment is manual
- 4513561b - Dummy frontend change
-
935efda2...5be42618 - 569 commits from branch