Skip to content

Fix audit event that weren't being created for failed LDAP log-in tries

Rémy Coutable requested to merge 211824-fix-failed-ldap-login-audit into master

What does this MR do?

I think we stopped logging failed LDAP logging with f10c999b.

The logging was added by @jameslopez with e74c7e2a but:

There was already a test for this behavior but it only passed after a retry (not sure why), so I've made sure that we never retry this particular test to ensure it's not a false positive.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #211824 (closed).

Edited by Rémy Coutable

Merge request reports