[graphql] Convert to using the new query interpreter runtime
What does this MR do?
Convert to using the GraphQL - Interpreter
Going straight to the latest, 1.13.12
Related to: #210556 (closed)
Screenshots
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added GraphQL backstage [DEPRECATED] bugperformance devopsplan labels
mentioned in issue #210556 (closed)
2 Errors 641e6462: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. b210d686: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. 6 Warnings This merge request is quite big (1063 lines changed), please consider splitting it into multiple merge requests. This merge request includes more than 10 commits. Each commit should meet the following criteria: - Have a well-written commit message.
- Has all tests passing when used on its own (e.g. when using git checkout SHA).
- Can be reverted on its own without also requiring the revert of commit that came before it.
- Is small enough that it can be reviewed in isolation in under 30 minutes or so.
If this merge request contains commits that do not meet this criteria and/or contains intermediate work, please rebase these commits into a smaller number of commits or split this merge request into multiple smaller merge requests.
c122573b: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. ef472d48: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 641e6462: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. b210d686: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Allison Browne ( @allison.browne
) (UTC-5, 1 hour ahead of@digitalmoksha
)Kerri Miller ( @kerrizor
) (UTC-8, 2 hours behind@digitalmoksha
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerSetting groupproject management based on
@digitalmoksha
's group.added groupproject management label
mentioned in issue #211478 (closed)
added 3004 commits
-
e2a68797...858c3de9 - 3003 commits from branch
master
- 2b22279c - wip
-
e2a68797...858c3de9 - 3003 commits from branch
mentioned in merge request !29326 (closed)
added 1685 commits
-
2b22279c...a8855bb7 - 1684 commits from branch
master
- 1ca80918 - wip
-
2b22279c...a8855bb7 - 1684 commits from branch
added 2234 commits
-
1ca80918...bac995be - 2233 commits from branch
master
- d12e624f - wip
-
1ca80918...bac995be - 2233 commits from branch
added 5842 commits
-
d12e624f...963966c1 - 5841 commits from branch
master
- 2e14643f - wip
-
d12e624f...963966c1 - 5841 commits from branch
added sectiondev label
added 12071 commits
-
2e14643f...e6a58a0e - 12070 commits from branch
master
- af18adc8 - wip
-
2e14643f...e6a58a0e - 12070 commits from branch
added 2673 commits
-
af18adc8...2ff32a4e - 2672 commits from branch
master
- 5d818816 - wip
-
af18adc8...2ff32a4e - 2672 commits from branch
added backend label
added 2673 commits
-
af18adc8...2ff32a4e - 2672 commits from branch
master
- 5d818816 - wip
-
af18adc8...2ff32a4e - 2672 commits from branch
added 738 commits
-
5d818816...6b5d711f - 737 commits from branch
master
- 1e4f1ac1 - wip
-
5d818816...6b5d711f - 737 commits from branch
mentioned in merge request !42111 (merged)
added 5305 commits
-
1e4f1ac1...ecbe4d0c - 5304 commits from branch
master
- 193ea148 - wip
-
1e4f1ac1...ecbe4d0c - 5304 commits from branch
added 2775 commits
-
193ea148...f48c6c15 - 2774 commits from branch
master
- e887bfc9 - wip
-
193ea148...f48c6c15 - 2774 commits from branch
- Resolved by Brett Walker
Just a note, we need to use the gem's authorize mechanism in order to adopt the new interpreter.
removed backstage [DEPRECATED] label
added maintenancerefactor typefeature typemaintenance labels
mentioned in merge request !40088 (merged)
added 7350 commits
-
e887bfc9...feb1ba94 - 7349 commits from branch
master
- 73f5d613 - wip
-
e887bfc9...feb1ba94 - 7349 commits from branch
-
Remove check for resolve proc in spec
'raises when passing a resolve block'
, https://gitlab.com/gitlab-org/gitlab/blob/master/spec/lib/gitlab/graphql/markdown_field_spec.rb - Look at https://gitlab.com/gitlab-org/gitlab/blob/ea9a4fd82489d9ee80fd220943a1a98e90c041e5/spec/support/helpers/graphql_helpers.rb#L110-L110
Edited by Brett Walker-
Remove check for resolve proc in spec
mentioned in merge request !49038 (merged)
added 5460 commits
-
73f5d613...cfc53bf6 - 5460 commits from branch
master
-
73f5d613...cfc53bf6 - 5460 commits from branch
added 1516 commits
-
18f00957...1252d865 - 1515 commits from branch
master
- c876ba5d - wip
-
18f00957...1252d865 - 1515 commits from branch
added 1249 commits
-
c876ba5d...d7046d7b - 1248 commits from branch
master
- 4a04874f - wip
-
c876ba5d...d7046d7b - 1248 commits from branch
added 1868 commits
-
4a04874f...35a2f4c4 - 1867 commits from branch
master
- 4182927d - wip
-
4a04874f...35a2f4c4 - 1867 commits from branch
mentioned in merge request !55306 (merged)
mentioned in merge request !55746 (merged)
added 3807 commits
-
4182927d...0a7b9704 - 3806 commits from branch
master
- dae9d54d - wip
-
4182927d...0a7b9704 - 3806 commits from branch
added 2274 commits
-
dae9d54d...73f6ae7c - 2273 commits from branch
master
- 09d84e59 - wip
-
dae9d54d...73f6ae7c - 2273 commits from branch
added 1453 commits
-
2cfd7a3b...7eac90e7 - 1451 commits from branch
master
- f9b8ed0c - wip
- 32e1042b - Add feature flag file
-
2cfd7a3b...7eac90e7 - 1451 commits from branch
added 2 commits
changed milestone to %13.12
changed milestone to %14.0
added missed:13.12 label
added 11196 commits
-
bf1fdb66...43239d5a - 11193 commits from branch
master
- 1b374771 - Initial move to the new GraphQL interpreter
- 5695f205 - Create the new AST LoggerAnalyzer
- 11e90968 - Create the new AST RecursionAnalyzer
Toggle commit list-
bf1fdb66...43239d5a - 11193 commits from branch
- A deleted user
added feature flag label
added 1565 commits
-
11e90968...61625cbd - 1562 commits from branch
master
- a6c9dc7a - Initial move to the new GraphQL interpreter
- 67da50ff - Create the new AST LoggerAnalyzer
- ea9a4fd8 - Create the new AST RecursionAnalyzer
Toggle commit list-
11e90968...61625cbd - 1562 commits from branch
changed milestone to %14.1
added 477 commits
-
471b86ee...73aec068 - 471 commits from branch
master
- 901ca0d9 - Initial move to the new GraphQL interpreter
- 663bb5ad - Create the new AST LoggerAnalyzer
- c50abc80 - Create the new AST RecursionAnalyzer
- e278222f - Prepare to remove spec once graphql_interpreter
- ea753d87 - Attempt specs with interpreter enabled
- bb4d584a - wip
Toggle commit list-
471b86ee...73aec068 - 471 commits from branch
mentioned in issue #334423 (closed)
added 869 commits
-
bb4d584a...2fca139b - 863 commits from branch
master
- 3ef03f8e - Initial move to the new GraphQL interpreter
- 9b6e754d - Create the new AST LoggerAnalyzer
- ce07a163 - Create the new AST RecursionAnalyzer
- 28983ce0 - Prepare to remove spec once graphql_interpreter
- c7af4438 - Attempt specs with interpreter enabled
- fdd78f6c - wip
Toggle commit list-
bb4d584a...2fca139b - 863 commits from branch
added 1721 commits
-
fdd78f6c...eb93b02a - 1715 commits from branch
master
- bb270527 - Initial move to the new GraphQL interpreter
- fdc9f1c3 - Create the new AST LoggerAnalyzer
- 79c11a6d - Create the new AST RecursionAnalyzer
- 0a2d9d82 - Prepare to remove spec once graphql_interpreter
- 28ed758c - rubocop
- e7a275ec - Fix some specs
Toggle commit list-
fdd78f6c...eb93b02a - 1715 commits from branch
added 788 commits
-
67901a50...b3658f2c - 780 commits from branch
master
- 818cd77f - Initial move to the new GraphQL interpreter
- af7d7ad9 - Create the new AST LoggerAnalyzer
- 6832241a - Create the new AST RecursionAnalyzer
- 2c3e5691 - Prepare to remove spec once graphql_interpreter
- 5835f85a - rubocop
- d1052f2c - Fix some specs
- b5c45e48 - override unauthorized_object(unauthorized_error)
- 51153479 - Update some specs that raise an error
Toggle commit list-
67901a50...b3658f2c - 780 commits from branch
mentioned in merge request !66113 (closed)
added 5 commits
Toggle commit list- A deleted user
added documentation label
added 1 commit
- 972d93ba - Fix specs checking for an error to be raised
mentioned in issue #336292 (closed)
changed milestone to %14.2
added 1 commit
- 87011b52 - Fix specs checking for an error to be raised
mentioned in merge request !66461 (merged)
mentioned in merge request !66462 (merged)
mentioned in merge request !66463 (merged)
mentioned in merge request !66495 (merged)
mentioned in merge request !66496 (merged)
mentioned in merge request !66497 (merged)
mentioned in merge request !66563 (merged)
mentioned in merge request !66565 (merged)
mentioned in merge request !66566 (merged)
added 1 commit
- b87780cf - Fix specs checking for an error to be raised
added 1651 commits
-
b87780cf...1d854f3e - 1639 commits from branch
master
- bcca1f06 - Initial move to the new GraphQL interpreter
- e5f8f907 - Create the new AST LoggerAnalyzer
- c4e5262f - Create the new AST RecursionAnalyzer
- 63144dc7 - Prepare to remove spec once graphql_interpreter
- 79e2e231 - rubocop
- ba94a145 - Fix some specs
- c9a7d266 - override unauthorized_object(unauthorized_error)
- cca6a563 - Update some specs that raise an error
- c7d4ba23 - wip
- f75d97b1 - Fix specs checking for an error to be raised
- 6de73e11 - Fix arg handlling in GraphQL::Helpers
- c385806a - Fix specs checking for an error to be raised
Toggle commit list-
b87780cf...1d854f3e - 1639 commits from branch
mentioned in merge request !66979 (merged)
added 1323 commits
-
c385806a...36c5d718 - 1311 commits from branch
master
- c5e17088 - Initial move to the new GraphQL interpreter
- fcb10703 - Create the new AST LoggerAnalyzer
- 925a3438 - Create the new AST RecursionAnalyzer
- 6a76a312 - Prepare to remove spec once graphql_interpreter
- 7c747064 - rubocop
- 1ae2091b - Fix some specs
- 46cf079e - override unauthorized_object(unauthorized_error)
- 06dab1cd - Update some specs that raise an error
- 9f29e430 - wip
- 21576995 - Fix specs checking for an error to be raised
- 18fce204 - Fix arg handlling in GraphQL::Helpers
- e207f4ad - Fix specs checking for an error to be raised
Toggle commit list-
c385806a...36c5d718 - 1311 commits from branch
#336292 (closed) is finally done and closed, can now keep moving forward...
added 470 commits
-
e207f4ad...f98b5fad - 458 commits from branch
master
- a58f5d08 - Initial move to the new GraphQL interpreter
- 502431fc - Create the new AST LoggerAnalyzer
- 5c1c9149 - Create the new AST RecursionAnalyzer
- 18aa8564 - Prepare to remove spec once graphql_interpreter
- 0d8301bd - rubocop
- bc65a1eb - Fix some specs
- 95a1b98f - override unauthorized_object(unauthorized_error)
- e094759e - Update some specs that raise an error
- 0e32dd32 - wip
- 910d7b74 - Fix specs checking for an error to be raised
- 2f07fef1 - Fix arg handlling in GraphQL::Helpers
- a9bd5d9b - Fix specs checking for an error to be raised
Toggle commit list-
e207f4ad...f98b5fad - 458 commits from branch
added 1006 commits
-
a9bd5d9b...12c0e08d - 994 commits from branch
master
- c6349fa1 - Initial move to the new GraphQL interpreter
- 0c5345bb - Create the new AST LoggerAnalyzer
- 42c9d421 - Create the new AST RecursionAnalyzer
- b39d37e2 - Prepare to remove spec once graphql_interpreter
- 0f88314f - rubocop
- 604e4dfb - Fix some specs
- 822cb9d6 - override unauthorized_object(unauthorized_error)
- f1ef895c - Update some specs that raise an error
- a37e7884 - wip
- 02ce72e7 - Fix specs checking for an error to be raised
- c9a64656 - Fix arg handlling in GraphQL::Helpers
- ea042167 - Fix specs checking for an error to be raised
Toggle commit list-
a9bd5d9b...12c0e08d - 994 commits from branch
changed milestone to %14.3
added missed:14.2 label
added 4097 commits
-
f39e975b...6de28e1d - 4084 commits from branch
master
- 09d64f6c - Initial move to the new GraphQL interpreter
- fb625d90 - Create the new AST LoggerAnalyzer
- 09c46e36 - Create the new AST RecursionAnalyzer
- 993c2acf - Prepare to remove spec once graphql_interpreter
- 1a9150dc - rubocop
- 3d56c51f - Fix some specs
- a0489081 - override unauthorized_object(unauthorized_error)
- f08a75ba - Update some specs that raise an error
- 08e77e49 - wip
- c7eb3dc8 - Fix specs checking for an error to be raised
- ec2bb279 - Fix arg handlling in GraphQL::Helpers
- 6f529ca6 - Fix specs checking for an error to be raised
- 121ce541 - Must override == in the clas itself
Toggle commit list-
f39e975b...6de28e1d - 4084 commits from branch
changed milestone to %14.4
added missed:14.3 label
added 2170 commits
-
121ce541...1a8c4d75 - 2157 commits from branch
master
- 89ba2c4b - Initial move to the new GraphQL interpreter
- 089e5c7b - Create the new AST LoggerAnalyzer
- e3c4a17b - Create the new AST RecursionAnalyzer
- 244b51d0 - Prepare to remove spec once graphql_interpreter
- 2d34383c - rubocop
- b2b61b1b - Fix some specs
- 62a0e7b2 - override unauthorized_object(unauthorized_error)
- 5c5a0a61 - Update some specs that raise an error
- 5b01190d - wip
- 7c71a767 - Fix specs checking for an error to be raised
- e838fa54 - Fix arg handlling in GraphQL::Helpers
- 685b382a - Fix specs checking for an error to be raised
- a8115fd3 - Must override == in the clas itself
Toggle commit list-
121ce541...1a8c4d75 - 2157 commits from branch
- Resolved by Brett Walker
- Resolved by Brett Walker
Hmm, ran into another snag.
So we use the
extras:
mechanism (https://graphql-ruby.org/fields/introduction.html#extra-field-metadata) to grab a piece of metadata, the object which holds the real model target (like a Group or Project) of the closest query. Example in https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/graphql/types/ci/runner_web_url_edge.rb#L9field :web_url, GraphQL::Types::String, null: true, description: 'Web URL of the runner. The value depends on where you put this field in the query. You can use it for projects or groups.', extras: [:parent] def initialize(node, connection) super @runner = node.node end def web_url(parent:) owner = closest_parent([::Types::ProjectType, ::Types::GroupType], parent) case owner when ::Group Gitlab::Routing.url_helpers.group_runner_url(owner, @runner) when ::Project Gitlab::Routing.url_helpers.project_runner_url(owner, @runner) end end
The problem is this
parent
method is part of theGraphQL::Query::Context::FieldResolutionContext
. But as noted in https://graphql-ruby.org/queries/interpreter.html#compatibility, that is no longer supported.This value does exist (at least for
RunnerWebUrlEdge
), asowner_object
down in https://github.com/rmosolgo/graphql-ruby/blob/61232b03412df6685406fc46c414e11d3f447817/lib/graphql/execution/interpreter/runtime.rb#L433. But there is no way to grab that value using theextras
mechanism.The failing job/spec is https://gitlab.com/gitlab-org/gitlab/-/jobs/1656505275,
rspec ./spec/frontend/fixtures/runner.rb:90
Based on the code in
FindClosest
(https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/graphql/types/concerns/find_closest.rb#L9), for the old way we needparent = value from extras: [:parent] parent.object.object, which should be a Group or Project
versus for the new interpreter code we need something like
parent = value from extras: [:owner_object] parent.object.parent, which should be a Group or Project
One of the tricky things about using the Extra Field Metadata is that, according to the docs,
Be warned, these APIs are subject to change, so check the changelog when updating.
I've opened https://github.com/rmosolgo/graphql-ruby/issues/3641 to try and gain some insight, but happy if someone here has an idea.
Note: we're using
FindClosest
instead of the documented usage in https://docs.gitlab.com/ee/development/api_graphql_styleguide.html#pass-a-parent-object-into-a-child-presenter. Not sure if that makes a difference or not yet, will have to look at that more.
changed milestone to %14.5
added missed:14.4 label
added 2708 commits
-
5ca178ce...1fb310c9 - 2695 commits from branch
master
- af5fc502 - Initial move to the new GraphQL interpreter
- f55079dc - Create the new AST LoggerAnalyzer
- 031c9782 - Create the new AST RecursionAnalyzer
- 09e70af7 - Prepare to remove spec once graphql_interpreter
- e5f75f66 - rubocop
- 63497cbc - Fix some specs
- b186f7e0 - override unauthorized_object(unauthorized_error)
- 0d0dd990 - Update some specs that raise an error
- 9edeeed2 - wip
- 9f2a7383 - Fix specs checking for an error to be raised
- 7c1e60a7 - Fix arg handlling in GraphQL::Helpers
- bf8900ad - Fix specs checking for an error to be raised
- 8b907646 - Must override == in the clas itself
Toggle commit list-
5ca178ce...1fb310c9 - 2695 commits from branch
removed typefeature label
changed milestone to %14.6
added missed:14.5 label
added 3625 commits
-
8b907646...25a12464 - 3612 commits from branch
master
- e9bbd8f4 - Initial move to the new GraphQL interpreter
- 1649252b - Create the new AST LoggerAnalyzer
- 8a97924d - Create the new AST RecursionAnalyzer
- 4a1ecd91 - Prepare to remove spec once graphql_interpreter
- 7cb89341 - rubocop
- 7ca1676c - Fix some specs
- 119fb1e0 - override unauthorized_object(unauthorized_error)
- 5187d03e - Update some specs that raise an error
- 95760bfe - wip
- 444e1afc - Fix specs checking for an error to be raised
- d1e512e5 - Fix arg handlling in GraphQL::Helpers
- be7e37b7 - Fix specs checking for an error to be raised
- 12851a4e - Must override == in the clas itself
Toggle commit list-
8b907646...25a12464 - 3612 commits from branch
added 1315 commits
-
b4bdbe47...59e5e1f7 - 1300 commits from branch
master
- 500f4a71 - Initial move to the new GraphQL interpreter
- 63f3c101 - Create the new AST LoggerAnalyzer
- 43b31213 - Create the new AST RecursionAnalyzer
- 73d16bb9 - Prepare to remove spec once graphql_interpreter
- 65d4966f - rubocop
- 8afd47a8 - Fix some specs
- c613bce6 - override unauthorized_object(unauthorized_error)
- a4b6e001 - Update some specs that raise an error
- 177f5e5e - wip
- 7979a768 - Fix specs checking for an error to be raised
- 89992ba7 - Fix arg handlling in GraphQL::Helpers
- dc9fcab3 - Fix specs checking for an error to be raised
- a949157b - Must override == in the clas itself
- 7abaa7a6 - Fix error in schema
- dc3a0520 - Try using latest 1.12.21
Toggle commit list-
b4bdbe47...59e5e1f7 - 1300 commits from branch
Allure report
allure-report-publisher
generated test report!package-and-qa:
test report
package-and-qa-ff-disabled: test report
package-and-qa-ff-enabled: test reportpackage-and-qa-ff-enabled:
test report for 2cb2e7d1expand test summary
+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Verify | 68 | 0 | 16 | 10 | ❗ | | Configure | 0 | 0 | 6 | 0 | ➖ | | Plan | 106 | 0 | 0 | 2 | ❗ | | Create | 296 | 0 | 14 | 12 | ❗ | | Secure | 36 | 2 | 4 | 14 | ❌ | | Release | 12 | 0 | 0 | 0 | ✅ | | Manage | 182 | 0 | 12 | 0 | ✅ | | Protect | 4 | 0 | 0 | 0 | ✅ | | Fulfillment | 4 | 0 | 22 | 0 | ✅ | | Package | 0 | 0 | 6 | 0 | ➖ | | Non-devops | 4 | 0 | 0 | 0 | ✅ | | Version sanity check | 0 | 0 | 2 | 2 | ➖ | +----------------------+--------+--------+---------+-------+--------+ | Total | 712 | 2 | 82 | 40 | ❌ | +----------------------+--------+--------+---------+-------+--------+
test report for 2cb2e7d1expand test summary
+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Package | 0 | 0 | 6 | 0 | ➖ | | Create | 296 | 0 | 14 | 12 | ❗ | | Plan | 106 | 0 | 0 | 2 | ❗ | | Manage | 182 | 0 | 12 | 0 | ✅ | | Secure | 36 | 2 | 4 | 14 | ❌ | | Fulfillment | 4 | 0 | 22 | 0 | ✅ | | Verify | 68 | 0 | 16 | 10 | ❗ | | Non-devops | 4 | 0 | 0 | 0 | ✅ | | Configure | 0 | 0 | 6 | 0 | ➖ | | Release | 12 | 0 | 0 | 0 | ✅ | | Version sanity check | 0 | 0 | 2 | 2 | ➖ | | Protect | 4 | 0 | 0 | 0 | ✅ | +----------------------+--------+--------+---------+-------+--------+ | Total | 712 | 2 | 82 | 40 | ❌ | +----------------------+--------+--------+---------+-------+--------+
test report for e9d56ab6expand test summary
+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Manage | 36 | 0 | 2 | 38 | ❗ | | Plan | 41 | 0 | 1 | 41 | ❗ | | Create | 22 | 0 | 3 | 23 | ❗ | | Verify | 12 | 0 | 1 | 12 | ❗ | | Configure | 0 | 0 | 1 | 0 | ➖ | | Package | 0 | 0 | 1 | 0 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | ➖ | | Protect | 2 | 0 | 0 | 2 | ❗ | +----------------------+--------+--------+---------+-------+--------+ | Total | 113 | 0 | 10 | 116 | ❗ | +----------------------+--------+--------+---------+-------+--------+
mentioned in merge request !75950 (merged)
added 1728 commits
-
bf1fff89...b60c838b - 1711 commits from branch
master
- 4533ca96 - Initial move to the new GraphQL interpreter
- 8ca995d2 - Create the new AST LoggerAnalyzer
- d0e9afa5 - Create the new AST RecursionAnalyzer
- 30c80989 - Prepare to remove spec once graphql_interpreter
- dad58f76 - rubocop
- 4ae2551f - Fix some specs
- d4e0b96c - override unauthorized_object(unauthorized_error)
- 8d5c4a47 - Update some specs that raise an error
- d739c111 - wip
- bb614b3f - Fix specs checking for an error to be raised
- 75d0ec41 - Fix arg handlling in GraphQL::Helpers
- b092a9c4 - Fix specs checking for an error to be raised
- b983d850 - Must override == in the clas itself
- fc064a29 - Fix error in schema
- 501fdeb3 - Try using latest 1.12.21
- f8f3a625 - Fix spec error
- d2b4de60 - Procs are no longer supported
Toggle commit list-
bf1fff89...b60c838b - 1711 commits from branch
added 7 commits
Toggle commit list- Resolved by Brett Walker
When we raise an exception when validating our arguments in a
prepare
proc, such as in https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/graphql/mutations/container_repositories/destroy_tags.rb#L19-27argument :tag_names, [GraphQL::Types::String], required: true, description: "Container repository tag(s) to delete. Total number can't be greater than #{LIMIT}", prepare: ->(tag_names, _) do raise Gitlab::Graphql::Errors::ArgumentError, TOO_MANY_TAGS_ERROR_MESSAGE if tag_names.size > LIMIT tag_names end
the exception can cause a
NoMethodError: undefined method `argument_values' for #<Gitlab::Graphql::Errors::ArgumentError:0x00007fccf9474eb0>
However I think it should allow this and continue bubbling up the error.
I've opened https://github.com/rmosolgo/graphql-ruby/issues/3789.
added 420 commits
-
4b4af40b...3142c5d9 - 399 commits from branch
master
- ee9fd938 - Initial move to the new GraphQL interpreter
- 8666ca1e - Create the new AST LoggerAnalyzer
- b61203c7 - Create the new AST RecursionAnalyzer
- 96cb9676 - Prepare to remove spec once graphql_interpreter
- 137bea5b - rubocop
- a2a2d51f - Fix some specs
- df1da884 - override unauthorized_object(unauthorized_error)
- 56372b3e - Update some specs that raise an error
- e03c4b3d - wip
- f4f6ef1d - Fix specs checking for an error to be raised
- 3aec0890 - Fix arg handlling in GraphQL::Helpers
- e8ad0ad3 - Fix specs checking for an error to be raised
- 6b7b87d1 - Must override == in the clas itself
- 2edc6595 - Fix error in schema
- d1f2ed23 - Try using latest 1.12.21
- ad3c757a - Fix spec error
- 86a4d8ca - Procs are no longer supported
- d0dfa423 - GraphQL::Pagination::Connections is now a default
- 0921df87 - Fix log tracer spec
- eb86f9de - Check for object in FindClosest
- c9b2aecc - Work in progress
Toggle commit list-
4b4af40b...3142c5d9 - 399 commits from branch
added 206 commits
-
c9b2aecc...4ef62907 - 185 commits from branch
master
- a2f766fb - Initial move to the new GraphQL interpreter
- 3633149f - Create the new AST LoggerAnalyzer
- 9f23bdc4 - Create the new AST RecursionAnalyzer
- c57606e8 - Prepare to remove spec once graphql_interpreter
- 0162a6e7 - rubocop
- 88d17711 - Fix some specs
- ee992956 - override unauthorized_object(unauthorized_error)
- b3ded70b - Update some specs that raise an error
- 48ccae20 - wip
- e34e75fc - Fix specs checking for an error to be raised
- 85ea49c8 - Fix arg handlling in GraphQL::Helpers
- dc2614dd - Fix specs checking for an error to be raised
- 0d0b27d7 - Must override == in the clas itself
- a9161fe2 - Fix error in schema
- 82a576d9 - Try using latest 1.12.21
- 96094cb9 - Fix spec error
- 6b9fb18f - Procs are no longer supported
- c3fa3f65 - GraphQL::Pagination::Connections is now a default
- b398f4b5 - Fix log tracer spec
- 15fae582 - Check for object in FindClosest
- e9156a1c - Work in progress
Toggle commit list-
c9b2aecc...4ef62907 - 185 commits from branch
changed milestone to %14.7
added missed:14.6 label
mentioned in merge request !77184 (closed)
rspec ./spec/requests/api/graphql/mutations/issues/set_due_date_spec.rb:57
is currently failing. This seems to be due to therequired: :nullable
ability we added. Specificallyargument :due_date, Types::TimeType, required: :nullable, description: 'Desired due date for the issue. Due date is removed if null.'
in
app/graphql/mutations/issues/set_due_date.rb
. Arguments seem to be validated a little differently now, and sonil
gets passed intoTimeType::coerce_input
, which throws an error when trying to parsenil
The
graphql
base types returnnil
when there is invalid input, including https://github.com/rmosolgo/graphql-ruby/blob/master/lib/graphql/types/iso_8601_date_time.rb#L53. So I've opened !77184 (closed) in order to align our implementation with the gem's versionadded 747 commits
-
57bca3c6...013c320f - 724 commits from branch
master
- 8d28b560 - Initial move to the new GraphQL interpreter
- a1f55910 - Create the new AST LoggerAnalyzer
- 9edb59ef - Create the new AST RecursionAnalyzer
- 08a83846 - Prepare to remove spec once graphql_interpreter
- e5e56f74 - rubocop
- 339b59b3 - Fix some specs
- b96bd245 - override unauthorized_object(unauthorized_error)
- 8d028b9d - Update some specs that raise an error
- 1ffff1e3 - wip
- db140d57 - Fix specs checking for an error to be raised
- 2f9aa401 - Fix arg handlling in GraphQL::Helpers
- 62b9cc52 - Fix specs checking for an error to be raised
- 082cf443 - Must override == in the clas itself
- 3d8c1bae - Fix error in schema
- 6fd92cd8 - Try using latest 1.12.21
- 418dc97a - Fix spec error
- 5e472ac0 - Procs are no longer supported
- fcf04714 - GraphQL::Pagination::Connections is now a default
- b4553647 - Fix log tracer spec
- 8b90d135 - Check for object in FindClosest
- 76e16a7a - Update to graphql 1.12.23
- 8a4ff18c - Fix for detailed_status_type.rb
- 3081cdff - Fix more specs
Toggle commit list-
57bca3c6...013c320f - 724 commits from branch
changed milestone to %14.8
added missed:14.7 label
changed milestone to %14.9
added 2543 commits
-
3081cdff...5c90a359 - 2520 commits from branch
master
- 74195b94 - Initial move to the new GraphQL interpreter
- 2a352ae1 - Create the new AST LoggerAnalyzer
- 7fbf626c - Create the new AST RecursionAnalyzer
- b03e9c71 - Prepare to remove spec once graphql_interpreter
- 942ab740 - rubocop
- cd2156c7 - Fix some specs
- 1d2314b3 - override unauthorized_object(unauthorized_error)
- 585ee760 - Update some specs that raise an error
- 84a9346f - wip
- e75c3fce - Fix specs checking for an error to be raised
- d71e3194 - Fix arg handlling in GraphQL::Helpers
- 61fcee4a - Fix specs checking for an error to be raised
- 5654f34e - Must override == in the clas itself
- 5dbbc824 - Fix error in schema
- e8f99c5a - Try using latest 1.12.21
- cf801ac3 - Fix spec error
- 1d43743f - Procs are no longer supported
- 9513fb46 - GraphQL::Pagination::Connections is now a default
- 2bf60103 - Fix log tracer spec
- d3a92e46 - Check for object in FindClosest
- 8ef5b440 - Update to graphql 1.12.23
- 6c43c1a4 - Fix for detailed_status_type.rb
- 8ec4d00c - Fix more specs
Toggle commit list-
3081cdff...5c90a359 - 2520 commits from branch
mentioned in issue #349240 (closed)
mentioned in issue #322933
- Resolved by Brett Walker
Upgrading to
1.13.8
introduced Dynamic types. So at the moment I'm gettingDuplicateNamesError
forCreateInput
andUpdateInput
, stemming fromgraphql-1.13.8/lib/graphql/schema.rb:1036
.This causes all specs to fail at the moment. So working on that...
added 3558 commits
-
4c8fb14d...ef7e6556 - 3534 commits from branch
master
- 24d366dd - Initial move to the new GraphQL interpreter
- d2ac8b7d - Create the new AST LoggerAnalyzer
- e86cf9bd - Create the new AST RecursionAnalyzer
- 4e5c5793 - Prepare to remove spec once graphql_interpreter
- dbe289c6 - rubocop
- 757950c4 - Fix some specs
- c138e4b1 - override unauthorized_object(unauthorized_error)
- 4b17d951 - Update some specs that raise an error
- 3526aef1 - wip
- f7b3c32c - Fix specs checking for an error to be raised
- f9cb24ec - Fix arg handlling in GraphQL::Helpers
- 5260ab52 - Fix specs checking for an error to be raised
- 3cfdb0e5 - Must override == in the clas itself
- 5c68d4cd - Fix error in schema
- 66ca354a - Try using latest 1.12.21
- caed7f20 - Fix spec error
- d81602d1 - Procs are no longer supported
- 9889b0ef - GraphQL::Pagination::Connections is now a default
- 3a1e3bcb - Fix log tracer spec
- 5e55c4dc - Check for object in FindClosest
- ea9757a7 - Update to graphql 1.12.23
- 5760e7de - Fix for detailed_status_type.rb
- 1c1c168e - Fix more specs
- b95b2562 - Upgrade to 1.13.8 (from 1.12.23)
Toggle commit list-
4c8fb14d...ef7e6556 - 3534 commits from branch
removed missed:13.12 label
removed missed:14.2 label
removed missed:14.3 label
removed missed:14.4 label
removed missed:14.5 label
removed missed:14.6 label
removed missed:14.7 label
added 413 commits
-
b95b2562...6b983bcb - 389 commits from branch
master
- 15be6588 - Initial move to the new GraphQL interpreter
- 63e1287b - Create the new AST LoggerAnalyzer
- d1269837 - Create the new AST RecursionAnalyzer
- bd4fa59c - Prepare to remove spec once graphql_interpreter
- 67886e88 - rubocop
- 7eae09c6 - Fix some specs
- 52523e53 - override unauthorized_object(unauthorized_error)
- 63d17e4a - Update some specs that raise an error
- 678eb68a - wip
- bb818dc1 - Fix specs checking for an error to be raised
- 883848d3 - Fix arg handlling in GraphQL::Helpers
- a3c4cd5b - Fix specs checking for an error to be raised
- 108439da - Must override == in the clas itself
- 234fcac1 - Fix error in schema
- 57dd7656 - Try using latest 1.12.21
- edbc0234 - Fix spec error
- 723fdda3 - Procs are no longer supported
- ac31185a - GraphQL::Pagination::Connections is now a default
- dae0fc7e - Fix log tracer spec
- 753b055f - Check for object in FindClosest
- 6e5006a1 - Update to graphql 1.12.23
- d0daffdf - Fix for detailed_status_type.rb
- 4ac13d76 - Fix more specs
- 1df4286d - Upgrade to 1.13.8 (from 1.12.23)
Toggle commit list-
b95b2562...6b983bcb - 389 commits from branch
In order to save some CI minutes, I'm removing the pipeline:run-all-rspec and pipeline:run-as-if-foss labels. There is still a lot of work to do on this MR, and it's mostly a waste of time and resource running all those specs. We will need to add them back in once we're closer.
removed pipeline:run-all-rspec label
removed pipeline:run-as-if-foss label
added 207 commits
-
1df4286d...6d33a4b8 - 182 commits from branch
master
- e6bede5e - Initial move to the new GraphQL interpreter
- 22519875 - Create the new AST LoggerAnalyzer
- 1736bab8 - Create the new AST RecursionAnalyzer
- f97fd5ab - Prepare to remove spec once graphql_interpreter
- 33124b91 - rubocop
- 9d3d767b - Fix some specs
- b834749f - override unauthorized_object(unauthorized_error)
- 7e613860 - Update some specs that raise an error
- 1a6ba8da - wip
- e0bdc58f - Fix specs checking for an error to be raised
- 98335428 - Fix arg handlling in GraphQL::Helpers
- 01855fcc - Fix specs checking for an error to be raised
- abddc69d - Must override == in the clas itself
- 5683043a - Fix error in schema
- 73d67715 - Try using latest 1.12.21
- eb98ac48 - Fix spec error
- 33888eac - Procs are no longer supported
- f6ba5aa3 - GraphQL::Pagination::Connections is now a default
- 17c7d0c3 - Fix log tracer spec
- b918fa50 - Check for object in FindClosest
- 28d43a43 - Update to graphql 1.12.23
- 2b29fb2d - Fix for detailed_status_type.rb
- 47c94add - Fix more specs
- a38eb3e4 - Upgrade to 1.13.8 (from 1.12.23)
- 08bab9a3 - Casues a GraphQL::Schema::DuplicateNamesError
Toggle commit list-
1df4286d...6d33a4b8 - 182 commits from branch
mentioned in merge request !73603 (merged)
mentioned in issue #353504
added 883 commits
-
08bab9a3...060d5d36 - 858 commits from branch
master
- 94dad1c3 - Initial move to the new GraphQL interpreter
- 74a8b5e0 - Create the new AST LoggerAnalyzer
- 07a69971 - Create the new AST RecursionAnalyzer
- ee7bde86 - Prepare to remove spec once graphql_interpreter
- b210d686 - rubocop
- f94432d9 - Fix some specs
- 641e6462 - override unauthorized_object(unauthorized_error)
- ef472d48 - Update some specs that raise an error
- c122573b - wip
- 1eed6091 - Fix specs checking for an error to be raised
- 2ef513bf - Fix arg handlling in GraphQL::Helpers
- 48c93856 - Fix specs checking for an error to be raised
- 49821b9e - Must override == in the clas itself
- 6dd7fbf9 - Fix error in schema
- f2255e16 - Try using latest 1.12.21
- caa82c50 - Fix spec error
- 6a12637d - Procs are no longer supported
- 29e8819e - GraphQL::Pagination::Connections is now a default
- bb9dadd3 - Fix log tracer spec
- 74c6c80c - Check for object in FindClosest
- 09b3e8c7 - Update to graphql 1.12.23
- 4f3d070d - Fix for detailed_status_type.rb
- bda37ee6 - Fix more specs
- 1a740531 - Upgrade to 1.13.8 (from 1.12.23)
- 18a3c90c - Casues a GraphQL::Schema::DuplicateNamesError
Toggle commit list-
08bab9a3...060d5d36 - 858 commits from branch
mentioned in commit daa5c48b
added 1583 commits
-
18a3c90c...641cda46 - 1557 commits from branch
master
- 74f89a7b - Initial move to the new GraphQL interpreter
- 46a6f9c7 - Create the new AST LoggerAnalyzer
- 300b38c1 - Create the new AST RecursionAnalyzer
- 477d888c - Prepare to remove spec once graphql_interpreter
- c40bea23 - rubocop
- 2f087d08 - Fix some specs
- 1b9bc2a6 - override unauthorized_object(unauthorized_error)
- 8aac4f74 - Update some specs that raise an error
- 73bb0864 - wip
- 6952eb3a - Fix specs checking for an error to be raised
- 8bdcdfb8 - Fix arg handlling in GraphQL::Helpers
- bcc11346 - Fix specs checking for an error to be raised
- 3d8f7129 - Must override == in the clas itself
- 42626217 - Fix error in schema
- 0b9b3367 - Try using latest 1.12.21
- 79c7160c - Fix spec error
- 368c26fc - Procs are no longer supported
- af771c29 - GraphQL::Pagination::Connections is now a default
- 3c0645ff - Fix log tracer spec
- b28a1851 - Check for object in FindClosest
- baa9aa73 - Update to graphql 1.12.23
- c6493f90 - Fix for detailed_status_type.rb
- 9032fc0c - Fix more specs
- 1bdd658e - Upgrade to 1.13.8 (from 1.12.23)
- fc811d94 - Casues a GraphQL::Schema::DuplicateNamesError
- 6209c187 - Add new expect_graphql_error_to_be_created
Toggle commit list-
18a3c90c...641cda46 - 1557 commits from branch
added 23 commits
- 2e6d5d7c - Create the new AST LoggerAnalyzer
- 5a1abe48 - Create the new AST RecursionAnalyzer
- 4e9eed88 - Fix some specs
- 27cc9efe - override unauthorized_object(unauthorized_error)
- e7be1c51 - Update some specs that raise an error
- ed38f25c - wip
- 6a8f207d - Fix specs checking for an error to be raised
- 57125b27 - Fix arg handlling in GraphQL::Helpers
- 830c4605 - Fix specs checking for an error to be raised
- 0687c529 - Must override == in the clas itself
- 5073d21e - Fix error in schema
- 7730c063 - Try using latest 1.12.21
- e59a2ded - Fix spec error
- 76e3f1f9 - Procs are no longer supported
- bc51fe4a - GraphQL::Pagination::Connections is now a default
- 41265bbc - Fix log tracer spec
- 818d6433 - Check for object in FindClosest
- 60ff96da - Update to graphql 1.12.23
- 2bc76ef5 - Fix for detailed_status_type.rb
- 3901bc9d - Fix more specs
- beb429fd - Upgrade to 1.13.8 (from 1.12.23)
- c567b660 - Casues a GraphQL::Schema::DuplicateNamesError
- 2a11ea49 - Add new expect_graphql_error_to_be_created
Toggle commit list- Resolved by Brett Walker
When doing
rspec spec/graphql/resolvers/user_resolver_spec.rb
(and many other specs), consistently getting an error withTypes::GroupType
An error occurred while loading ./spec/graphql/resolvers/user_resolver_spec.rb. Failure/Error: base.class_eval(&@_prepended_block) NameError: uninitialized constant Types::EpicType::GroupType Did you mean? Types::GroupType GroupTree
This seems to be from a circular definition.
Types::GroupType
, which is a subclass ofTypes::NamespaceType
, has the fieldfield :projects, Types::ProjectType.connection_type
.Type::ProjectType
has the fieldfield :group, Types::GroupType
. And round and round we go.
mentioned in merge request !82651 (merged)
added 338 commits
Toggle commit listmentioned in merge request !75373 (merged)
mentioned in merge request !82739 (merged)
added 2 commits
added 1 commit
- e359bdbc - Method to_graphql is deprecated, begin removing
added 293 commits
-
e359bdbc...58c71c08 - 286 commits from branch
master
- 654a8303 - Initial move to the new GraphQL interpreter
- 70355c03 - Create the new AST LoggerAnalyzer
- 0498c14e - Create the new AST RecursionAnalyzer
- 1fa06fd3 - Update to graphql 1.13.8 and much more
- 52759bde - Adjust how args are built for testing
- 084d58fb - Additional removal of to_graphql
- f18d4706 - Method to_graphql is deprecated, begin removing
Toggle commit list-
e359bdbc...58c71c08 - 286 commits from branch
mentioned in merge request !82928 (merged)
added 274 commits
-
da8ea4ef...2f06ef37 - 265 commits from branch
master
- 12d56885 - Initial move to the new GraphQL interpreter
- 1ee40c85 - Create the new AST LoggerAnalyzer
- ee3da3c6 - Create the new AST RecursionAnalyzer
- 839b17c6 - Update to graphql 1.13.8 and much more
- 691f0c0c - Adjust how args are built for testing
- 69aa8152 - Removal of to_graphql only possible on this branch
- 7b2b38b9 - Fix signature of get_type
- d96afa74 - Method to_graphql is deprecated, begin removing
- 5cc028dc - FIx one of many specs
Toggle commit list-
da8ea4ef...2f06ef37 - 265 commits from branch
removed feature flag label
changed milestone to %15.0
removed documentation label
added 607 commits
-
5cc028dc...3dbb300d - 598 commits from branch
master
- 32fb49c1 - Initial move to the new GraphQL interpreter
- acdb2a27 - Create the new AST LoggerAnalyzer
- c23485be - Create the new AST RecursionAnalyzer
- bd333909 - Update to graphql 1.13.8 and much more
- 4e323af4 - Adjust how args are built for testing
- 980958b7 - Removal of to_graphql only possible on this branch
- ca60b718 - Fix signature of get_type
- c16663d6 - Method to_graphql is deprecated, begin removing
- a34d880b - FIx one of many specs
Toggle commit list-
5cc028dc...3dbb300d - 598 commits from branch
added 265 commits
-
f0cc01a7...03ec52ec - 257 commits from branch
master
- 0eaad917 - Initial move to the new GraphQL interpreter
- 676cbbce - Create the new AST LoggerAnalyzer
- a268ecf6 - Create the new AST RecursionAnalyzer
- ec972115 - Update to graphql 1.13.8 and much more
- 6b3bdf5c - Adjust how args are built for testing
- 462e027d - Removal of to_graphql only possible on this branch
- 58957505 - Fix signature of get_type
- e8d0f880 - FIx one of many specs
Toggle commit list-
f0cc01a7...03ec52ec - 257 commits from branch
- Resolved by Brett Walker
4 Warnings This merge request is quite big (1007 lines changed), please consider splitting it into multiple merge requests. This merge request includes more than 10 commits. Each commit should meet the following criteria: - Have a well-written commit message.
- Has all tests passing when used on its own (e.g. when using git checkout SHA).
- Can be reverted on its own without also requiring the revert of commit that came before it.
- Is small enough that it can be reviewed in isolation in under 30 minutes or so.
If this merge request contains commits that do not meet this criteria and/or contains intermediate work, please rebase these commits into a smaller number of commits or split this merge request into multiple smaller merge requests.
ef1b520c: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 76171c5f: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. If needed, you can retry the
danger-review
job that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Tarun Vellishetty ( @tvellishetty
) (UTC+5.5, 10.5 hours ahead of@digitalmoksha
)Etienne Baqué ( @ebaque
) (UTC+3, 8 hours ahead of@digitalmoksha
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangeradded 425 commits
-
e8d0f880...56cbc645 - 417 commits from branch
master
- f7ec71a7 - Initial move to the new GraphQL interpreter
- 3f746d7d - Create the new AST LoggerAnalyzer
- 3a63c6e6 - Create the new AST RecursionAnalyzer
- 350799ad - Update to graphql 1.13.8 and much more
- 497b3130 - Adjust how args are built for testing
- 1a512080 - Removal of to_graphql only possible on this branch
- b487896d - Fix signature of get_type
- 34b7477d - FIx one of many specs
Toggle commit list-
e8d0f880...56cbc645 - 417 commits from branch
added 936 commits
-
9c922e02...3042e325 - 925 commits from branch
master
- 88430365 - Initial move to the new GraphQL interpreter
- 3c63d169 - Create the new AST LoggerAnalyzer
- 9aeb32b1 - Create the new AST RecursionAnalyzer
- 02d9a424 - Update to graphql 1.13.8 and much more
- 5e9c18b1 - Adjust how args are built for testing
- 66c0e243 - Removal of to_graphql only possible on this branch
- bf8cd142 - Fix signature of get_type
- f2aacbf8 - FIx one of many specs
- b364bd4b - Use 1.13.11 of grapql gem
- abec90a8 - Override new complexity calculation to use our own
- 74d553eb - Fix some failing specs
Toggle commit list-
9c922e02...3042e325 - 925 commits from branch
added 547 commits
-
74d553eb...57c8d634 - 536 commits from branch
master
- ce5f9a61 - Initial move to the new GraphQL interpreter
- 34236e85 - Create the new AST LoggerAnalyzer
- 9807ace2 - Create the new AST RecursionAnalyzer
- 32b7e6ea - Update to graphql 1.13.8 and much more
- 9c751929 - Adjust how args are built for testing
- 0fb77791 - Removal of to_graphql only possible on this branch
- a255fae1 - Fix signature of get_type
- 8c225ec2 - FIx one of many specs
- ef5bd254 - Use 1.13.11 of grapql gem
- a2e2cfd9 - Override new complexity calculation to use our own
- 59b7efa3 - Fix some failing specs
Toggle commit list-
74d553eb...57c8d634 - 536 commits from branch
added 1658 commits
-
59b7efa3...20c22cf0 - 1647 commits from branch
master
- 0afd39a7 - Initial move to the new GraphQL interpreter
- b193559c - Create the new AST LoggerAnalyzer
- 6239230e - Create the new AST RecursionAnalyzer
- d2a8c317 - Update to graphql 1.13.8 and much more
- 3c8cc9ed - Adjust how args are built for testing
- 34d10bd9 - Removal of to_graphql only possible on this branch
- ce1a7f4c - Fix signature of get_type
- c17319d4 - FIx one of many specs
- f65dc9ce - Use 1.13.11 of grapql gem
- 4bd5bde1 - Override new complexity calculation to use our own
- 85d13cd4 - Fix some failing specs
Toggle commit list-
59b7efa3...20c22cf0 - 1647 commits from branch
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @cablett
,@rspeicher
,@acroitor
,@.luke
,@smcgivern
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
added 206 commits
-
85d13cd4...66675c34 - 195 commits from branch
master
- c3b847ef - Initial move to the new GraphQL interpreter
- 5f0e84f6 - Create the new AST LoggerAnalyzer
- cff291f9 - Create the new AST RecursionAnalyzer
- 15caa23d - Update to graphql 1.13.8 and much more
- 31015416 - Adjust how args are built for testing
- 23b08bda - Removal of to_graphql only possible on this branch
- 645602ff - Fix signature of get_type
- 16936baf - FIx one of many specs
- 890ffa37 - Use 1.13.11 of grapql gem
- 12506b03 - Override new complexity calculation to use our own
- fe68c97d - Fix some failing specs
Toggle commit list-
85d13cd4...66675c34 - 195 commits from branch
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @cablett
,@rspeicher
,@acroitor
,@.luke
,@smcgivern
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @cablett
,@rspeicher
,@acroitor
,@.luke
,@smcgivern
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
added 764 commits
-
3196b2b1...ed2b355e - 751 commits from branch
master
- 32b1cff0 - Initial move to the new GraphQL interpreter
- 7bbfcce8 - Create the new AST LoggerAnalyzer
- f6d97d15 - Create the new AST RecursionAnalyzer
- 3622cef1 - Update to graphql 1.13.8 and much more
- 8eace71f - Adjust how args are built for testing
- 190c0a48 - Removal of to_graphql only possible on this branch
- 2dff5694 - Fix signature of get_type
- 861132b1 - FIx one of many specs
- 4c14d925 - Use 1.13.11 of grapql gem
- 2a8cba74 - Override new complexity calculation to use our own
- 4e3ab2ad - Fix some failing specs
- ef4d7ca4 - Use 1.13.12 of grapql gem
- 57976e5d - Multiple methods of handling arguments for specs
Toggle commit list-
3196b2b1...ed2b355e - 751 commits from branch
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @digitalmoksha
,@DylanGriffith
,@jprovaznik
,@.luke
,@mkozono
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Botmentioned in merge request !84093 (closed)
mentioned in issue #355926 (closed)
added 261 commits
-
57976e5d...b1f8abae - 248 commits from branch
master
- 83560fec - Initial move to the new GraphQL interpreter
- 9eb122f5 - Create the new AST LoggerAnalyzer
- 6164bd90 - Create the new AST RecursionAnalyzer
- 7064c54d - Update to graphql 1.13.8 and much more
- 2e61eb98 - Adjust how args are built for testing
- 68e54ebf - Removal of to_graphql only possible on this branch
- c4958e03 - Fix signature of get_type
- 6b100c05 - FIx one of many specs
- c0cb98c2 - Use 1.13.11 of grapql gem
- 6a1be257 - Override new complexity calculation to use our own
- 0fce2762 - Fix some failing specs
- e3a8923a - Use 1.13.12 of grapql gem
- 0cf415e9 - Multiple methods of handling arguments for specs
Toggle commit list-
57976e5d...b1f8abae - 248 commits from branch
- The
gitlab-qa-mirror
downstream pipeline for !27536 (9808ef4e) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (9808ef4e) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (1ec5dbba) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (1ec5dbba) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (c6a80ed2) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (c6a80ed2) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (a57dc2e9) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (a57dc2e9) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (7f10ae7a) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (7f10ae7a) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (3399f674) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (8a4e9ecd) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (8a4e9ecd) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (d78e8064) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (d78e8064) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (8c3fd1b1) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (396b2642) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (396b2642) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (da9c7a1c) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (da9c7a1c) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (4bba4aa8) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (4bba4aa8) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (7d509b38) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (7d509b38) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (ce553e93) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (ce553e93) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (ff4ae558) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (ff4ae558) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (ca0ce5ad) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (ca0ce5ad) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (123bb5d2) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (123bb5d2) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (100c8a5a) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (100c8a5a) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (2cb2e7d1) failed! - The
gitlab-qa-mirror
downstream pipeline for !27536 (2cb2e7d1) failed!
- The
added 261 commits
-
9808ef4e...81545146 - 243 commits from branch
master
- b2c871cf - Initial move to the new GraphQL interpreter
- 13bc8057 - Create the new AST LoggerAnalyzer
- 8645aae7 - Create the new AST RecursionAnalyzer
- b4560732 - Update to graphql 1.13.8 and much more
- dcfc189e - Adjust how args are built for testing
- acf9f4ed - Removal of to_graphql only possible on this branch
- 5605a1ec - Fix signature of get_type
- 82b4a32b - FIx one of many specs
- 88b22de9 - Use 1.13.11 of grapql gem
- 0891af82 - Override new complexity calculation to use our own
- 2e4b4640 - Fix some failing specs
- 04bbdc01 - Use 1.13.12 of grapql gem
- 944e2240 - Multiple methods of handling arguments for specs
- 85eef127 - Updates to GraphqlHelpers
- f99dc9c9 - Fix GraphQL::Schema::DuplicateNamesError errors
- 786eda9d - Remove use of GraphQL::Schema.define
- 4205f548 - Skip spec for now
- 1ec5dbba - Don’t redefine connection arguments
Toggle commit list-
9808ef4e...81545146 - 243 commits from branch
added 317 commits
-
1ec5dbba...ec322c8a - 299 commits from branch
master
- bc9456d0 - Initial move to the new GraphQL interpreter
- 97208da5 - Create the new AST LoggerAnalyzer
- 0bf79b93 - Create the new AST RecursionAnalyzer
- 9c814b00 - Update to graphql 1.13.8 and much more
- c4bb8684 - Adjust how args are built for testing
- f3e3693c - Removal of to_graphql only possible on this branch
- ddd49aa1 - Fix signature of get_type
- 2110c640 - FIx one of many specs
- 09166485 - Use 1.13.11 of grapql gem
- 0c872b72 - Override new complexity calculation to use our own
- 7d9b37ab - Fix some failing specs
- 8ef72f5b - Use 1.13.12 of grapql gem
- e9a7d82b - Multiple methods of handling arguments for specs
- 19e425a8 - Updates to GraphqlHelpers
- d4ca8d91 - Fix GraphQL::Schema::DuplicateNamesError errors
- 6a200e6b - Remove use of GraphQL::Schema.define
- 7b762238 - Skip spec for now
- c6a80ed2 - Don’t redefine connection arguments
Toggle commit list-
1ec5dbba...ec322c8a - 299 commits from branch
added 149 commits
-
c6a80ed2...bbff15ea - 131 commits from branch
master
- f6fd2e5b - Initial move to the new GraphQL interpreter
- 1c7c1f60 - Create the new AST LoggerAnalyzer
- 06f92ee5 - Create the new AST RecursionAnalyzer
- b5fdea2a - Update to graphql 1.13.8 and much more
- 3fa2742c - Adjust how args are built for testing
- c6450d7f - Removal of to_graphql only possible on this branch
- 703c1bd9 - Fix signature of get_type
- e791c0cd - FIx one of many specs
- fdc6e0f8 - Use 1.13.11 of grapql gem
- e2aab3ba - Override new complexity calculation to use our own
- 66df78ca - Fix some failing specs
- a2960616 - Use 1.13.12 of grapql gem
- 58508753 - Multiple methods of handling arguments for specs
- d3e06dc7 - Updates to GraphqlHelpers
- 8926d344 - Fix GraphQL::Schema::DuplicateNamesError errors
- b24b498f - Remove use of GraphQL::Schema.define
- 19f7d3b8 - Skip spec for now
- a57dc2e9 - Don’t redefine connection arguments
Toggle commit list-
c6a80ed2...bbff15ea - 131 commits from branch
added 585 commits
-
a57dc2e9...4c71d6e1 - 567 commits from branch
master
- 1b7ad976 - Initial move to the new GraphQL interpreter
- b52f2bce - Create the new AST LoggerAnalyzer
- 7292c517 - Create the new AST RecursionAnalyzer
- 3d41818b - Update to graphql 1.13.8 and much more
- 33bc073b - Adjust how args are built for testing
- ba8569ad - Removal of to_graphql only possible on this branch
- 2a8c7f1d - Fix signature of get_type
- 99e91d71 - FIx one of many specs
- bf6a0b49 - Use 1.13.11 of grapql gem
- 2d47cecb - Override new complexity calculation to use our own
- aca73012 - Fix some failing specs
- 57dd0b7e - Use 1.13.12 of grapql gem
- 05101ba4 - Multiple methods of handling arguments for specs
- 5a0b464c - Updates to GraphqlHelpers
- 33435093 - Fix GraphQL::Schema::DuplicateNamesError errors
- 134126de - Remove use of GraphQL::Schema.define
- eca98d2b - Skip spec for now
- 7f10ae7a - Don’t redefine connection arguments
Toggle commit list-
a57dc2e9...4c71d6e1 - 567 commits from branch
added 195 commits
-
7f10ae7a...f5344f1e - 177 commits from branch
master
- 35802539 - Initial move to the new GraphQL interpreter
- 332a2ca6 - Create the new AST LoggerAnalyzer
- f7dda33c - Create the new AST RecursionAnalyzer
- b5dc1a13 - Update to graphql 1.13.8 and much more
- 09c69a6b - Adjust how args are built for testing
- 28491cca - Removal of to_graphql only possible on this branch
- 1126093f - Fix signature of get_type
- 99ce2d88 - FIx one of many specs
- a5b21a9a - Use 1.13.11 of grapql gem
- 9cfc240f - Override new complexity calculation to use our own
- 2cc7ef32 - Fix some failing specs
- 5d61fece - Use 1.13.12 of grapql gem
- 4de0a9d5 - Multiple methods of handling arguments for specs
- 5a804f16 - Updates to GraphqlHelpers
- 174d8258 - Fix GraphQL::Schema::DuplicateNamesError errors
- 5eb2a165 - Remove use of GraphQL::Schema.define
- c51f15b7 - Skip spec for now
- 3399f674 - Don’t redefine connection arguments
Toggle commit list-
7f10ae7a...f5344f1e - 177 commits from branch
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits f5344f1e and 8c3fd1b1
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.46 MB 3.45 MB -6.38 KB -0.2 % mainChunk 1.93 MB 1.93 MB - 0.0 % Significant Reduction: 4Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.edit 2.81 MB 2.16 MB -674.21 KB -23.4 % pages.projects.merge_requests.creations.diffs 2.33 MB 1.68 MB -673.18 KB -28.2 % pages.projects.merge_requests.edit 2.33 MB 1.68 MB -673.18 KB -28.2 % pages.projects.merge_requests.creations.new 2.39 MB 1.73 MB -672.66 KB -27.5 %
Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Brett Walker
- Resolved by Brett Walker
- Resolved by Brett Walker
added 682 commits
-
8c3fd1b1...57b3f319 - 649 commits from branch
master
- 8b434005 - Initial move to the new GraphQL interpreter
- ffee7a34 - Create the new AST LoggerAnalyzer
- b0d8f0a5 - Create the new AST RecursionAnalyzer
- 3560441e - Update to graphql 1.13.8 and much more
- e2a5e014 - Adjust how args are built for testing
- 099dd00f - Removal of to_graphql only possible on this branch
- d500cd16 - Fix signature of get_type
- 8bea38be - FIx one of many specs
- 64e349d1 - Use 1.13.11 of grapql gem
- 697ce64b - Override new complexity calculation to use our own
- 2bad841b - Fix some failing specs
- 1741ca53 - Use 1.13.12 of grapql gem
- f67246ad - Multiple methods of handling arguments for specs
- d14b8f93 - Updates to GraphqlHelpers
- 1738d65f - Fix GraphQL::Schema::DuplicateNamesError errors
- 61bd1cbf - Remove use of GraphQL::Schema.define
- 0a0e2933 - Skip spec for now
- be68080a - Don’t redefine connection arguments
- 41d53b73 - Various spec fixes
- b430aa49 - BaseInputObject must return super from `prepare`
- dfde1dc8 - Fix for api/graphql/iteration_spec.rb
- 129a607c - Attempt to fix find_closest
- 224e8553 - Remove prepare from NegatedBoardIssueInputType
- 16c89713 - Fix CI specs
- 7798cb05 - Fix for merge_request_spec.rb
- 11c50397 - Return nil if TimeType is nil
- 4e03082e - Fix the reposition_image_diff_note_spec.rb
- a81a9215 - Fix spec design_management/delete_spec.rb
- c62e6cfc - Check for keyword_arguments
- dd1f42bb - Default value should be same type as argument
- f5e0284c - Fix for graphql_spec
- ed4533cd - Fix for iterations/create_spec.rb
- 396b2642 - DEBUG_GRAPHQL=1 now ignores graphql tracers
Toggle commit list-
8c3fd1b1...57b3f319 - 649 commits from branch
added 1505 commits
-
396b2642...f3e60983 - 1472 commits from branch
master
- f0812b41 - Initial move to the new GraphQL interpreter
- ea915831 - Create the new AST LoggerAnalyzer
- 5c880d8e - Create the new AST RecursionAnalyzer
- b440130b - Update to graphql 1.13.8 and much more
- 1b0a01e4 - Adjust how args are built for testing
- 915276a3 - Removal of to_graphql only possible on this branch
- 8d6bd866 - Fix signature of get_type
- 2f4fed40 - FIx one of many specs
- a92098dd - Use 1.13.11 of grapql gem
- a142c969 - Override new complexity calculation to use our own
- ccf71266 - Fix some failing specs
- a06fca46 - Use 1.13.12 of grapql gem
- 88ea5265 - Multiple methods of handling arguments for specs
- b09183ea - Updates to GraphqlHelpers
- 1825706f - Fix GraphQL::Schema::DuplicateNamesError errors
- cfdd37b1 - Remove use of GraphQL::Schema.define
- 34b380f0 - Skip spec for now
- 88811008 - Don’t redefine connection arguments
- 6a397fe1 - Various spec fixes
- 186d075b - BaseInputObject must return super from `prepare`
- 2edbc0c6 - Fix for api/graphql/iteration_spec.rb
- bf3a7edf - Attempt to fix find_closest
- 43d7ba26 - Remove prepare from NegatedBoardIssueInputType
- 8aeaad68 - Fix CI specs
- e903e397 - Fix for merge_request_spec.rb
- f3b5dd4d - Return nil if TimeType is nil
- d3daba7f - Fix the reposition_image_diff_note_spec.rb
- 00ed1940 - Fix spec design_management/delete_spec.rb
- f4c464b7 - Check for keyword_arguments
- ff4d32f7 - Default value should be same type as argument
- 0097f411 - Fix for graphql_spec
- ffc2e93a - Fix for iterations/create_spec.rb
- da9c7a1c - DEBUG_GRAPHQL=1 now ignores graphql tracers
Toggle commit list-
396b2642...f3e60983 - 1472 commits from branch
changed milestone to %15.1
added 2 commits
added 2 commits
mentioned in merge request !87295 (merged)
added 507 commits
-
ce553e93...a6c8a083 - 469 commits from branch
master
- 000dafcf - Initial move to the new GraphQL interpreter
- fa47861e - Create the new AST LoggerAnalyzer
- 9768fbfa - Create the new AST RecursionAnalyzer
- 7712a378 - Update to graphql 1.13.8 and much more
- 1fb433f3 - Adjust how args are built for testing
- 73ee87e4 - Removal of to_graphql only possible on this branch
- a4480dc6 - Fix signature of get_type
- 6b963b4d - FIx one of many specs
- 0ba571ef - Use 1.13.11 of grapql gem
- 2378e870 - Override new complexity calculation to use our own
- e105b71b - Fix some failing specs
- 198fc25f - Use 1.13.12 of grapql gem
- 8720fecf - Multiple methods of handling arguments for specs
- 39a163e5 - Updates to GraphqlHelpers
- 46a1ed3b - Fix GraphQL::Schema::DuplicateNamesError errors
- 0b223482 - Remove use of GraphQL::Schema.define
- 7905c0d5 - Skip spec for now
- 50591247 - Don’t redefine connection arguments
- 4d4e7bda - Various spec fixes
- 77428ef0 - BaseInputObject must return super from `prepare`
- 2a0c4279 - Fix for api/graphql/iteration_spec.rb
- 4ef4ca4a - Attempt to fix find_closest
- 7b98cee2 - Remove prepare from NegatedBoardIssueInputType
- b75812a1 - Fix CI specs
- 3708cffb - Fix for merge_request_spec.rb
- bf038281 - Return nil if TimeType is nil
- fad79f3d - Fix the reposition_image_diff_note_spec.rb
- b39123d8 - Fix spec design_management/delete_spec.rb
- ec197397 - Check for keyword_arguments
- f1e6fbb3 - Default value should be same type as argument
- ca09140f - Fix for graphql_spec
- c743d986 - Fix for iterations/create_spec.rb
- c0fef2d4 - DEBUG_GRAPHQL=1 now ignores graphql tracers
- 19aacf0a - Remove a binding.pry
- 5326d42c - See if infitine recursion check is really needed
- 9edd42a1 - Fix specs for TimeType and StatusActionType
- 69e9e1d4 - Fix repository_spec.rb and rubocop
- ff4ae558 - Fix spec with NegatedIssueFilterInputType
Toggle commit list-
ce553e93...a6c8a083 - 469 commits from branch
added 44 commits
-
ff4ae558...d13bb990 - 9 commits from branch
master
- bbfe61c4 - Initial move to the new GraphQL interpreter
- 6247f1f0 - Create the new AST LoggerAnalyzer
- aaeb4ca4 - Create the new AST RecursionAnalyzer
- a5dab4c9 - Update to graphql 1.13.8 and much more
- 4a676f1c - Adjust how args are built for testing
- 0c6ea632 - Removal of to_graphql only possible on this branch
- 4ed48b5e - Fix signature of get_type
- 59a51943 - FIx one of many specs
- ac78ad23 - Use 1.13.11 of grapql gem
- 55449a98 - Override new complexity calculation to use our own
- 475e4b21 - Fix some failing specs
- 09fecc3a - Use 1.13.12 of grapql gem
- 66028de2 - Multiple methods of handling arguments for specs
- d2233c45 - Updates to GraphqlHelpers
- a7d21202 - Remove use of GraphQL::Schema.define
- 58d6e781 - Skip spec for now
- 5796bc6d - Don’t redefine connection arguments
- c4da4002 - Various spec fixes
- 326a49f1 - BaseInputObject must return super from `prepare`
- 85bc3fa0 - Fix for api/graphql/iteration_spec.rb
- 5a9b46e0 - Attempt to fix find_closest
- a0384a7f - Remove prepare from NegatedBoardIssueInputType
- 02accdde - Fix CI specs
- 583ec0ce - Fix for merge_request_spec.rb
- 2d2fcca3 - Return nil if TimeType is nil
- cbc9f954 - Fix the reposition_image_diff_note_spec.rb
- eee0281e - Fix spec design_management/delete_spec.rb
- a9e8a0f4 - Check for keyword_arguments
- e59b9082 - Fix for graphql_spec
- f683ab46 - Fix for iterations/create_spec.rb
- 8df4b49b - DEBUG_GRAPHQL=1 now ignores graphql tracers
- 2636c006 - See if infitine recursion check is really needed
- b8193a18 - Fix specs for TimeType and StatusActionType
- bbeff0e5 - Fix repository_spec.rb and rubocop
- ca0ce5ad - Fix spec with NegatedIssueFilterInputType
Toggle commit list-
ff4ae558...d13bb990 - 9 commits from branch
added 2 commits
added pipeline:run-as-if-foss label
added 1 commit
- 2cb2e7d1 - Change since an exception is no longer raised
mentioned in issue #363130 (closed)
added 1 commit
- 8e2ea9f2 - Remove feature flag as it’s not currently used
added 2 commits
added 78 commits
-
c15a28a1...35978329 - 37 commits from branch
master
- 15d2f25a - Initial move to the new GraphQL interpreter
- 5edf2802 - Create the new AST LoggerAnalyzer
- b8f2d428 - Create the new AST RecursionAnalyzer
- e1b3a4dd - Update to graphql 1.13.8 and much more
- 99413422 - Adjust how args are built for testing
- c5025962 - Removal of to_graphql only possible on this branch
- 1ef68a46 - Fix signature of get_type
- 132a2a68 - FIx one of many specs
- 896304a6 - Use 1.13.11 of grapql gem
- ba3955fd - Override new complexity calculation to use our own
- 20fdc0b5 - Fix some failing specs
- d08ad48a - Use 1.13.12 of grapql gem
- 3baab308 - Multiple methods of handling arguments for specs
- 74d9d476 - Updates to GraphqlHelpers
- 59f37aba - Remove use of GraphQL::Schema.define
- b99fb3c0 - Skip spec for now
- ff57ebf6 - Don’t redefine connection arguments
- e0420504 - Various spec fixes
- 3a97b3a1 - BaseInputObject must return super from `prepare`
- 71d7a101 - Fix for api/graphql/iteration_spec.rb
- 762c5dae - Attempt to fix find_closest
- 6a31f00b - Remove prepare from NegatedBoardIssueInputType
- ef8ebef6 - Fix CI specs
- 1e18cc8d - Fix for merge_request_spec.rb
- a673c2ce - Return nil if TimeType is nil
- bfa53717 - Fix the reposition_image_diff_note_spec.rb
- 31103bc2 - Fix spec design_management/delete_spec.rb
- f1be68fd - Check for keyword_arguments
- b134ed23 - Fix for graphql_spec
- b33f2310 - Fix for iterations/create_spec.rb
- 9c1db0ff - DEBUG_GRAPHQL=1 now ignores graphql tracers
- 7eabb1da - See if infitine recursion check is really needed
- 1019c11b - Fix specs for TimeType and StatusActionType
- cb5eb2ce - Fix repository_spec.rb and rubocop
- 47f12143 - Fix spec with NegatedIssueFilterInputType
- fe03aadf - Remove some no longer needed changes
- c3c4ab68 - Fix for tree_resolver
- c6752a58 - Change since an exception is no longer raised
- 78e05997 - Remove feature flag as it’s not currently used
- 2d32948f - Remove use of metadata[:type_class]
- c372ec9b - Remove some cruft
Toggle commit list-
c15a28a1...35978329 - 37 commits from branch
added 143 commits
-
c372ec9b...ba1b4b96 - 106 commits from branch
master
- 438e89cf - Initial move to the new GraphQL interpreter
- 88249b60 - Create the new AST LoggerAnalyzer
- ce658d14 - Create the new AST RecursionAnalyzer
- 19e6e589 - Update to graphql 1.13.8 and much more
- 31b5730a - Adjust how args are built for testing
- 23c82b38 - Removal of to_graphql only possible on this branch
- c286b763 - Fix signature of get_type
- 7b025bc4 - FIx one of many specs
- 497befdf - Use 1.13.11 of grapql gem
- 9e37f9a9 - Override new complexity calculation to use our own
- a368bae3 - Fix some failing specs
- da6b3b11 - Use 1.13.12 of grapql gem
- a90e2f4e - Multiple methods of handling arguments for specs
- 42180ce5 - Updates to GraphqlHelpers
- 40730043 - Skip spec for now
- e72ee175 - Don’t redefine connection arguments
- 5f35c228 - Various spec fixes
- 1ef865aa - BaseInputObject must return super from `prepare`
- 0c4f739d - Fix for api/graphql/iteration_spec.rb
- edc517ad - Attempt to fix find_closest
- 6ef2a299 - Remove prepare from NegatedBoardIssueInputType
- 5c6e6725 - Fix CI specs
- 161679fa - Fix for merge_request_spec.rb
- 75e22a21 - Return nil if TimeType is nil
- bc3e999a - Fix the reposition_image_diff_note_spec.rb
- 9707dd89 - Fix spec design_management/delete_spec.rb
- 3c9bed47 - Check for keyword_arguments
- 9095b09f - Fix for graphql_spec
- 190b7b18 - Fix for iterations/create_spec.rb
- e6711e59 - DEBUG_GRAPHQL=1 now ignores graphql tracers
- 95c0064a - See if infitine recursion check is really needed
- d645b1dd - Fix specs for TimeType and StatusActionType
- 4e83152a - Fix repository_spec.rb and rubocop
- 968af708 - Remove some no longer needed changes
- 5ca1911b - Remove feature flag as it’s not currently used
- 1fc8b010 - Remove use of metadata[:type_class]
- efa5b6cb - Remove some cruft
Toggle commit list-
c372ec9b...ba1b4b96 - 106 commits from branch
added pipeline:skip-undercoverage label
added 2 commits
- Resolved by Brett Walker
@alexkalderimis wasn't quite sure we'd get here, but can you do the initial backend review?
requested review from @alexkalderimis
- Resolved by Brett Walker
- Resolved by Brett Walker
- Resolved by charlie ablett
- Resolved by Alex Kalderimis
- Resolved by Brett Walker
- Resolved by Brett Walker
- Resolved by Brett Walker
- Resolved by Brett Walker
- Resolved by Brett Walker
- Resolved by Brett Walker
- Resolved by Brett Walker
- Resolved by Alex Kalderimis
- Resolved by Brett Walker
- Resolved by Brett Walker
This is simply fantastic. Thanks so much @digitalmoksha; you have done amazing work on keeping this going.
I have a few comments, but nothing blocking at all, and nothing significant; mostly questions and requests for explanations.
Back to you for discussion - chapeau!
added 1 commit
- 3844b73f - Rename method to as_graphql_argument_literals
mentioned in issue #363240 (closed)
- Resolved by Alex Kalderimis
Ok, question for both of you (@alexkalderimis, @.luke)
There is no way to feature flag this. And I had originally thought we might need some extended testing through staging or something in order to merge this.
But after pushing so much into
master
before, the tests running cleanly and many of the remaining changes relatively small, I'm wondering if we can just proceed as normal. Though I would probably announce this in the#production
channel.
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added 101 commits
-
fb019ef6...268f25b0 - 100 commits from branch
master
- f3423368 - Move to the new GraphQL interpreter
-
fb019ef6...268f25b0 - 100 commits from branch
- Resolved by Alex Kalderimis
Thanks @digitalmoksha - I do have one serious blocking concern
To demonstrate this, I created !88371 (closed), which adds the missing specification for
FindParent
(see 760a35bc). This test passes onmaster
, and fails on this branch with:FindClosest alpha.beta.alpha.gamma (FAILED - 1) beta.alpha.beta.gamma (FAILED - 2) can run a simple query Failures: 1) FindClosest alpha.beta.alpha.gamma Failure/Error: closest_parent([alpha_t], parent)[:id] NoMethodError: undefined method `[]' for nil:NilClass # ./spec/graphql/types/concerns/find_closest_spec.rb:80:in `block (3 levels) in <top (required)>' # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:826:in `public_send' # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:826:in `block in public_send_field' # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:911:in `with_extensions' # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:803:in `public_send_field' # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:717:in `block in resolve' # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema.rb:118:in `after_lazy' # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:715:in `resolve' ... # elided for clarity # ./spec/graphql/types/concerns/find_closest_spec.rb:120:in `block (2 levels) in <top (required)>' 2) FindClosest beta.alpha.beta.gamma Failure/Error: closest_parent([alpha_t], parent)[:id] NoMethodError: undefined method `[]' for nil:NilClass # ./spec/graphql/types/concerns/find_closest_spec.rb:80:in `block (3 levels) in <top (required)>' # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:826:in `public_send' # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:826:in `block in public_send_field' # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:911:in `with_extensions' # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:803:in `public_send_field' # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:717:in `block in resolve' # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema.rb:118:in `after_lazy' # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:715:in `resolve' ... # elided for clarity # ./spec/graphql/types/concerns/find_closest_spec.rb:147:in `block (2 levels) in <top (required)>' Finished in 0.01378 seconds (files took 4.66 seconds to load) 3 examples, 2 failures Failed examples: rspec ./spec/graphql/types/concerns/find_closest_spec.rb:102 # FindClosest alpha.beta.alpha.gamma rspec ./spec/graphql/types/concerns/find_closest_spec.rb:129 # FindClosest beta.alpha.beta.gamma
I think this demonstrates pretty clearly that this is broken, and right now my suspicion is that it cannot work and we need to rethink this. I hoped that maybe
Context#path
would work as a replacement, but in this test it always returns[]
.I am also more than a little concerned that our
request
tests don't cover any of this, and we need to (separately) add request specs for fields that use this functionality, which by my count is (thankfully) just the following two files:-
app/graphql/types/ci/runner_web_url_edge.rb
:RunnerWebUrlEdge.runner_url
-
app/graphql/types/merge_requests/interacts_with_merge_request.rb
:User.merge_request_interaction
We can probably replace them with some variant on the scoped-context value passing we used to deal with this in passing down design versions, if the interpreter does not support general introspection.
Thoughts @digitalmoksha
-
mentioned in commit 92e5919a
mentioned in merge request !88477 (closed)
added 221 commits
-
f3423368...31e7d396 - 220 commits from branch
master
- 021121a5 - Move to the new GraphQL interpreter
-
f3423368...31e7d396 - 220 commits from branch
added 35 commits
Toggle commit listadded 108 commits
Toggle commit listadded 10 commits
Toggle commit list- Resolved by Brett Walker
OK, so it looks like we have a green pipeline again, so I will proceed to a maintainer review.
@cablett - do you have capacity to give this MR its maintainer review?
requested review from @cablett and removed review request for @alexkalderimis
@alexkalderimis
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added 85 commits
Toggle commit list- Resolved by Brett Walker
@.luke you've been involved quite a bit too, I would love to have your take on the changes if you find you have time.
requested review from @.luke
added 146 commits
Toggle commit list- Resolved by Luke Duncalfe
- Resolved by Brett Walker
- Resolved by Luke Duncalfe
removed review request for @.luke
added 38 commits
Toggle commit listadded 9 commits
-
0b4e90c6...3c9803ca - 2 commits from branch
master
- 740bb10a - Move to the new GraphQL interpreter
- 76cf4d5e - Remove FindClosest module
- 0b331168 - Add spec for Group.runners
- 2c048750 - Remove uses of FindClosest
- 6a327cff - Remove dead code
- 8631ccd1 - Handle parenting in connections
- 2a66332d - Remove duplicate fields from logger
Toggle commit list-
0b4e90c6...3c9803ca - 2 commits from branch
requested review from @.luke
added 10 commits
-
a3cee09b...290f0dab - 2 commits from branch
master
- f77fe392 - Move to the new GraphQL interpreter
- ccca64f2 - Remove FindClosest module
- 4d4981be - Add spec for Group.runners
- a64d8589 - Remove uses of FindClosest
- e265103c - Remove dead code
- 8998bc63 - Handle parenting in connections
- e831f127 - Remove duplicate fields from logger
- 77ec96bc - Remove unnecessary ENV['DEBUG_GRAPHQL']
Toggle commit list-
a3cee09b...290f0dab - 2 commits from branch
removed review request for @.luke
- Resolved by Brett Walker
@digitalmoksha I notice that links to https://graphql-ruby.org/queries/interpreter.html are now pointing to 404. Do you know where the updated resource is, if it still exists? I couldn't find by searching https://graphql-ruby.org/
Edited by charlie ablett
- Resolved by Brett Walker
- Resolved by charlie ablett
- Resolved by charlie ablett
- Resolved by Brett Walker
- Resolved by Brett Walker
- Resolved by charlie ablett
- Resolved by Brett Walker
- Resolved by Brett Walker
- Resolved by Brett Walker
- Resolved by Brett Walker
- Resolved by Brett Walker
- Resolved by charlie ablett
- Resolved by charlie ablett
- Resolved by Brett Walker
requested review from @furkanayhan
removed review request for @cablett
added 407 commits
-
77ec96bc...4be271c5 - 399 commits from branch
master
- 0d302a0c - Move to the new GraphQL interpreter
- e26c407b - Remove FindClosest module
- 69e9f398 - Add spec for Group.runners
- 68b653f9 - Remove uses of FindClosest
- ed001a43 - Remove dead code
- 0091bb0e - Handle parenting in connections
- 6d36ea94 - Remove duplicate fields from logger
- d143ceeb - Remove unnecessary ENV['DEBUG_GRAPHQL']
Toggle commit list-
77ec96bc...4be271c5 - 399 commits from branch
removed review request for @furkanayhan
mentioned in issue #364059
mentioned in issue #364061
@digitalmoksha This MR depends on one closed MR according to the widget above:
This is sorted, so you might want to remove the MR dependency
- Resolved by Brett Walker
- Resolved by Brett Walker
added 155 commits
-
3a7529e3...46b037d2 - 141 commits from branch
master
- 7721ae20 - Move to the new GraphQL interpreter
- a0893c14 - Remove FindClosest module
- 01f041ba - Add spec for Group.runners
- 07e69e50 - Remove uses of FindClosest
- 6c8b9785 - Remove dead code
- 8312456a - Handle parenting in connections
- a7ab0835 - Remove duplicate fields from logger
- 58fcdbb9 - Remove unnecessary ENV['DEBUG_GRAPHQL']
- 7b29c772 - Add clarification comment in status_action_type.rb
- 56f3d6c3 - Adjust loggers to original output
- 3ab94372 - Minor refactors based on suggestions
- 0c1aa534 - Fix flakiness due to dates
- f1b8bb36 - Set RequestStore same as the old logger does
- aab0e82f - Use query_double instead of double(‘query’)
Toggle commit list-
3a7529e3...46b037d2 - 141 commits from branch
- Resolved by Brett Walker
@cablett I think I've covered everything. And it looks like the pipeline failed due to an issue with
master
, so I've rebased. Back to you
requested review from @cablett
added 82 commits
-
aab0e82f...3abf3aa8 - 68 commits from branch
master
- 76171c5f - Move to the new GraphQL interpreter
- 3b70d694 - Remove FindClosest module
- 3eb44f67 - Add spec for Group.runners
- 82fab95a - Remove uses of FindClosest
- 06e516e8 - Remove dead code
- 286ccd66 - Handle parenting in connections
- 65ec8801 - Remove duplicate fields from logger
- 2f52ff35 - Remove unnecessary ENV['DEBUG_GRAPHQL']
- 49f8fe8f - Add clarification comment in status_action_type.rb
- ef1b520c - Adjust loggers to original output
- 992329d6 - Minor refactors based on suggestions
- 1afb3e92 - Fix flakiness due to dates
- 169c6d2c - Set RequestStore same as the old logger does
- e9d56ab6 - Use query_double instead of double(‘query’)
Toggle commit list-
aab0e82f...3abf3aa8 - 68 commits from branch
- Resolved by Alex Kalderimis
Thanks @alexkalderimis @.luke @cablett for reviewing this behemoth
All threads are resolved, approvals collected, and the pipeline was green 9 hours ago.
I've gone ahead and rebased to check the latest code.
@alexkalderimis I think our work days overlap - would you be up for setting MWPS if you think it's ready?
enabled an automatic merge when the pipeline for 82f8b853 succeeds
- Resolved by Brett Walker
To be sent to the
#production
,#development
, and#f_graphql
slack channels.
We will soon be merging an upgrade to the GraphQL gem. It utilizes a new underlying architecture, so there was a bit of work to start using it. There are no user facing changes to worry about. We will be monitoring the upgrade as it progresses through deployment.
Some benefits:
- we can use runtime directives! (see for example a new
@modelId
directive). - we can use validators!
- faster! better!
Developers may need to rebase their branches once the merge happens. If you're writing vanilla code, there should be no changes needed. Documentation will be updated soon. You can get the very rough notes at !88694 (merged)
@alexkalderimis anything we should change?
Edited by Brett Walker - we can use runtime directives! (see for example a new
mentioned in commit 031723aa
Fantastic - I have discovered probably our first follow-up:
Legacy `.graphql_definition` objects are deprecated and will be removed in GraphQL-Ruby 2.0. Use a class-based definition instead. Called on GitlabSchema from: /home/git/gitlab/tooling/graphql/docs/renderer.rb:25:in `initialize' /home/git/gitlab/lib/tasks/gitlab/graphql.rake:114:in `new' /home/git/gitlab/lib/tasks/gitlab/graphql.rake:114:in `block (3 levels) in <main>' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:281:in `block in execute' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:281:in `each' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:281:in `execute' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/sentry-ruby-core-5.1.1/lib/sentry/rake.rb:26:in `execute' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:219:in `block in invoke_with_call_chain' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:199:in `synchronize' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:199:in `invoke_with_call_chain' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:188:in `invoke' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:160:in `invoke_task' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:116:in `block (2 levels) in top_level' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:116:in `each' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:116:in `block in top_level' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:125:in `run_with_threads' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:110:in `top_level' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:83:in `block in run' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:186:in `standard_exception_handling' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:80:in `run' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/exe/rake:27:in `<top (required)>' /data/cache/bundle-2.7.5/ruby/2.7.0/bin/rake:23:in `load' /data/cache/bundle-2.7.5/ruby/2.7.0/bin/rake:23:in `<top (required)>' /usr/local/lib/ruby/2.7.0/bundler/cli/exec.rb:63:in `load' /usr/local/lib/ruby/2.7.0/bundler/cli/exec.rb:63:in `kernel_load' Legacy `.to_graphql` objects are deprecated and will be removed in GraphQL-Ruby 2.0. Remove `.to_graphql` to use a class-based definition instead. Called on GitlabSchema from: /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema.rb:921:in `graphql_definition' /home/git/gitlab/tooling/graphql/docs/renderer.rb:25:in `initialize' /home/git/gitlab/lib/tasks/gitlab/graphql.rake:114:in `new' /home/git/gitlab/lib/tasks/gitlab/graphql.rake:114:in `block (3 levels) in <main>' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:281:in `block in execute' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:281:in `each' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:281:in `execute' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/sentry-ruby-core-5.1.1/lib/sentry/rake.rb:26:in `execute' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:219:in `block in invoke_with_call_chain' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:199:in `synchronize' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:199:in `invoke_with_call_chain' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:188:in `invoke' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:160:in `invoke_task' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:116:in `block (2 levels) in top_level' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:116:in `each' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:116:in `block in top_level' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:125:in `run_with_threads' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:110:in `top_level' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:83:in `block in run' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:186:in `standard_exception_handling' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:80:in `run' /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/exe/rake:27:in `<top (required)>' /data/cache/bundle-2.7.5/ruby/2.7.0/bin/rake:23:in `load' /data/cache/bundle-2.7.5/ruby/2.7.0/bin/rake:23:in `<top (required)>' /usr/local/lib/ruby/2.7.0/bundler/cli/exec.rb:63:in `load' Documentation compiled.
when compiling the docs
Yep - one of many on the road to
2.0.x
&8119 (closed)I really think we should try and keep up the momentum to get to
2.0
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
mentioned in issue #364156 (closed)
added workflowproduction label and removed workflowstaging label
mentioned in issue #364141 (closed)
- Resolved by Brett Walker
This seems to have caused an e2e test to fail: #364141 (closed)
SAST custom variables are missing in the config files. Is this intended behavior?
mentioned in issue gitlab-org/quality/pipeline-triage#144 (closed)
mentioned in merge request !89263 (merged)
mentioned in merge request !88694 (merged)
added releasedcandidate label
mentioned in issue #382190 (closed)