Skip to content
Snippets Groups Projects

[graphql] Convert to using the new query interpreter runtime

Merged Brett Walker requested to merge bw-graphql-interpreter into master
1 unresolved thread

What does this MR do?

Convert to using the GraphQL - Interpreter

Going straight to the latest, 1.13.12

Related to: #210556 (closed)

Screenshots

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Brett Walker

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Brett Walker added 4 commits

    added 4 commits

    • 4aa2d608 - Fix specs checking for an error to be raised
    • 14ae2b9d - Fix arg handlling in GraphQL::Helpers
    • 32e97ec4 - Fix specs checking for an error to be raised
    • 5ca178ce - Must override == in the clas itself

    Compare with previous version

  • 🤖 GitLab Bot 🤖 changed milestone to %14.5

    changed milestone to %14.5

  • Brett Walker added 2708 commits

    added 2708 commits

    • 5ca178ce...1fb310c9 - 2695 commits from branch master
    • af5fc502 - Initial move to the new GraphQL interpreter
    • f55079dc - Create the new AST LoggerAnalyzer
    • 031c9782 - Create the new AST RecursionAnalyzer
    • 09e70af7 - Prepare to remove spec once graphql_interpreter
    • e5f75f66 - rubocop
    • 63497cbc - Fix some specs
    • b186f7e0 - override unauthorized_object(unauthorized_error)
    • 0d0dd990 - Update some specs that raise an error
    • 9edeeed2 - wip
    • 9f2a7383 - Fix specs checking for an error to be raised
    • 7c1e60a7 - Fix arg handlling in GraphQL::Helpers
    • bf8900ad - Fix specs checking for an error to be raised
    • 8b907646 - Must override == in the clas itself

    Compare with previous version

  • Brett Walker changed title from WIP: GraphQL: Convert to using the new query interpreter runtime... [RUN ALL RSPEC] [RUN AS-IF-FOSS] to WIP: GraphQL: Convert to using the new query interpreter runtime

    changed title from WIP: GraphQL: Convert to using the new query interpreter runtime... [RUN ALL RSPEC] [RUN AS-IF-FOSS] to WIP: GraphQL: Convert to using the new query interpreter runtime

  • 🤖 GitLab Bot 🤖 changed milestone to %14.6

    changed milestone to %14.6

  • Brett Walker added 3625 commits

    added 3625 commits

    • 8b907646...25a12464 - 3612 commits from branch master
    • e9bbd8f4 - Initial move to the new GraphQL interpreter
    • 1649252b - Create the new AST LoggerAnalyzer
    • 8a97924d - Create the new AST RecursionAnalyzer
    • 4a1ecd91 - Prepare to remove spec once graphql_interpreter
    • 7cb89341 - rubocop
    • 7ca1676c - Fix some specs
    • 119fb1e0 - override unauthorized_object(unauthorized_error)
    • 5187d03e - Update some specs that raise an error
    • 95760bfe - wip
    • 444e1afc - Fix specs checking for an error to be raised
    • d1e512e5 - Fix arg handlling in GraphQL::Helpers
    • be7e37b7 - Fix specs checking for an error to be raised
    • 12851a4e - Must override == in the clas itself

    Compare with previous version

  • Brett Walker added 1 commit

    added 1 commit

    Compare with previous version

  • Brett Walker added 1315 commits

    added 1315 commits

    • b4bdbe47...59e5e1f7 - 1300 commits from branch master
    • 500f4a71 - Initial move to the new GraphQL interpreter
    • 63f3c101 - Create the new AST LoggerAnalyzer
    • 43b31213 - Create the new AST RecursionAnalyzer
    • 73d16bb9 - Prepare to remove spec once graphql_interpreter
    • 65d4966f - rubocop
    • 8afd47a8 - Fix some specs
    • c613bce6 - override unauthorized_object(unauthorized_error)
    • a4b6e001 - Update some specs that raise an error
    • 177f5e5e - wip
    • 7979a768 - Fix specs checking for an error to be raised
    • 89992ba7 - Fix arg handlling in GraphQL::Helpers
    • dc9fcab3 - Fix specs checking for an error to be raised
    • a949157b - Must override == in the clas itself
    • 7abaa7a6 - Fix error in schema
    • dc3a0520 - Try using latest 1.12.21

    Compare with previous version

  • Allure report

    allure-report-publisher generated test report!

    package-and-qa: :pencil: test report
    package-and-qa-ff-disabled: :pencil: test report
    package-and-qa-ff-enabled: :pencil: test report

    package-and-qa-ff-enabled: :x: test report for 2cb2e7d1

    expand test summary
    +-------------------------------------------------------------------+
    |                          suites summary                           |
    +----------------------+--------+--------+---------+-------+--------+
    |                      | passed | failed | skipped | flaky | result |
    +----------------------+--------+--------+---------+-------+--------+
    | Verify               | 68     | 0      | 16      | 10    | ❗     |
    | Configure            | 0      | 0      | 6       | 0     | ➖     |
    | Plan                 | 106    | 0      | 0       | 2     | ❗     |
    | Create               | 296    | 0      | 14      | 12    | ❗     |
    | Secure               | 36     | 2      | 4       | 14    | ❌     |
    | Release              | 12     | 0      | 0       | 0     | ✅     |
    | Manage               | 182    | 0      | 12      | 0     | ✅     |
    | Protect              | 4      | 0      | 0       | 0     | ✅     |
    | Fulfillment          | 4      | 0      | 22      | 0     | ✅     |
    | Package              | 0      | 0      | 6       | 0     | ➖     |
    | Non-devops           | 4      | 0      | 0       | 0     | ✅     |
    | Version sanity check | 0      | 0      | 2       | 2     | ➖     |
    +----------------------+--------+--------+---------+-------+--------+
    | Total                | 712    | 2      | 82      | 40    | ❌     |
    +----------------------+--------+--------+---------+-------+--------+
    **package-and-qa-ff-disabled**: :x: test report for 2cb2e7d1
    expand test summary
    +-------------------------------------------------------------------+
    |                          suites summary                           |
    +----------------------+--------+--------+---------+-------+--------+
    |                      | passed | failed | skipped | flaky | result |
    +----------------------+--------+--------+---------+-------+--------+
    | Package              | 0      | 0      | 6       | 0     | ➖     |
    | Create               | 296    | 0      | 14      | 12    | ❗     |
    | Plan                 | 106    | 0      | 0       | 2     | ❗     |
    | Manage               | 182    | 0      | 12      | 0     | ✅     |
    | Secure               | 36     | 2      | 4       | 14    | ❌     |
    | Fulfillment          | 4      | 0      | 22      | 0     | ✅     |
    | Verify               | 68     | 0      | 16      | 10    | ❗     |
    | Non-devops           | 4      | 0      | 0       | 0     | ✅     |
    | Configure            | 0      | 0      | 6       | 0     | ➖     |
    | Release              | 12     | 0      | 0       | 0     | ✅     |
    | Version sanity check | 0      | 0      | 2       | 2     | ➖     |
    | Protect              | 4      | 0      | 0       | 0     | ✅     |
    +----------------------+--------+--------+---------+-------+--------+
    | Total                | 712    | 2      | 82      | 40    | ❌     |
    +----------------------+--------+--------+---------+-------+--------+
    **review-qa-blocking**: :exclamation: test report for e9d56ab6
    expand test summary
    +-------------------------------------------------------------------+
    |                          suites summary                           |
    +----------------------+--------+--------+---------+-------+--------+
    |                      | passed | failed | skipped | flaky | result |
    +----------------------+--------+--------+---------+-------+--------+
    | Manage               | 36     | 0      | 2       | 38    | ❗     |
    | Plan                 | 41     | 0      | 1       | 41    | ❗     |
    | Create               | 22     | 0      | 3       | 23    | ❗     |
    | Verify               | 12     | 0      | 1       | 12    | ❗     |
    | Configure            | 0      | 0      | 1       | 0     | ➖     |
    | Package              | 0      | 0      | 1       | 0     | ➖     |
    | Version sanity check | 0      | 0      | 1       | 0     | ➖     |
    | Protect              | 2      | 0      | 0       | 2     | ❗     |
    +----------------------+--------+--------+---------+-------+--------+
    | Total                | 113    | 0      | 10      | 116   | ❗     |
    +----------------------+--------+--------+---------+-------+--------+
  • Brett Walker mentioned in merge request !75950 (merged)

    mentioned in merge request !75950 (merged)

  • Brett Walker added 1 commit

    added 1 commit

    Compare with previous version

  • Brett Walker added 1 commit

    added 1 commit

    Compare with previous version

  • Brett Walker added 6 commits

    added 6 commits

    Compare with previous version

  • Brett Walker added 1728 commits

    added 1728 commits

    Compare with previous version

  • Brett Walker added 7 commits

    added 7 commits

    • 38087632 - Fix specs checking for an error to be raised
    • 5065d026 - Must override == in the clas itself
    • 759432aa - Fix error in schema
    • 25169d00 - Try using latest 1.12.21
    • 97b4b95e - Fix spec error
    • 63f8839d - Procs are no longer supported
    • f9f57e38 - GraphQL::Pagination::Connections is now a default

    Compare with previous version

  • Brett Walker added 1 commit

    added 1 commit

    Compare with previous version

  • Brett Walker added 1 commit

    added 1 commit

    • 4b4af40b - Check for object in FindClosest

    Compare with previous version

  • closed

  • reopened

  • Brett Walker added 420 commits

    added 420 commits

    • 4b4af40b...3142c5d9 - 399 commits from branch master
    • ee9fd938 - Initial move to the new GraphQL interpreter
    • 8666ca1e - Create the new AST LoggerAnalyzer
    • b61203c7 - Create the new AST RecursionAnalyzer
    • 96cb9676 - Prepare to remove spec once graphql_interpreter
    • 137bea5b - rubocop
    • a2a2d51f - Fix some specs
    • df1da884 - override unauthorized_object(unauthorized_error)
    • 56372b3e - Update some specs that raise an error
    • e03c4b3d - wip
    • f4f6ef1d - Fix specs checking for an error to be raised
    • 3aec0890 - Fix arg handlling in GraphQL::Helpers
    • e8ad0ad3 - Fix specs checking for an error to be raised
    • 6b7b87d1 - Must override == in the clas itself
    • 2edc6595 - Fix error in schema
    • d1f2ed23 - Try using latest 1.12.21
    • ad3c757a - Fix spec error
    • 86a4d8ca - Procs are no longer supported
    • d0dfa423 - GraphQL::Pagination::Connections is now a default
    • 0921df87 - Fix log tracer spec
    • eb86f9de - Check for object in FindClosest
    • c9b2aecc - Work in progress

    Compare with previous version

  • Brett Walker added 206 commits

    added 206 commits

    • c9b2aecc...4ef62907 - 185 commits from branch master
    • a2f766fb - Initial move to the new GraphQL interpreter
    • 3633149f - Create the new AST LoggerAnalyzer
    • 9f23bdc4 - Create the new AST RecursionAnalyzer
    • c57606e8 - Prepare to remove spec once graphql_interpreter
    • 0162a6e7 - rubocop
    • 88d17711 - Fix some specs
    • ee992956 - override unauthorized_object(unauthorized_error)
    • b3ded70b - Update some specs that raise an error
    • 48ccae20 - wip
    • e34e75fc - Fix specs checking for an error to be raised
    • 85ea49c8 - Fix arg handlling in GraphQL::Helpers
    • dc2614dd - Fix specs checking for an error to be raised
    • 0d0b27d7 - Must override == in the clas itself
    • a9161fe2 - Fix error in schema
    • 82a576d9 - Try using latest 1.12.21
    • 96094cb9 - Fix spec error
    • 6b9fb18f - Procs are no longer supported
    • c3fa3f65 - GraphQL::Pagination::Connections is now a default
    • b398f4b5 - Fix log tracer spec
    • 15fae582 - Check for object in FindClosest
    • e9156a1c - Work in progress

    Compare with previous version

  • Brett Walker added 1 commit

    added 1 commit

    Compare with previous version

  • Brett Walker added 1 commit

    added 1 commit

    Compare with previous version

  • 🤖 GitLab Bot 🤖 changed milestone to %14.7

    changed milestone to %14.7

  • Brett Walker mentioned in merge request !77184 (closed)

    mentioned in merge request !77184 (closed)

  • rspec ./spec/requests/api/graphql/mutations/issues/set_due_date_spec.rb:57 is currently failing. This seems to be due to the required: :nullable ability we added. Specifically

          argument :due_date,
                   Types::TimeType,
                   required: :nullable,
                   description: 'Desired due date for the issue. Due date is removed if null.'

    in app/graphql/mutations/issues/set_due_date.rb. Arguments seem to be validated a little differently now, and so nil gets passed into TimeType::coerce_input, which throws an error when trying to parse nil

    The graphql base types return nil when there is invalid input, including https://github.com/rmosolgo/graphql-ruby/blob/master/lib/graphql/types/iso_8601_date_time.rb#L53. So I've opened !77184 (closed) in order to align our implementation with the gem's version

  • Brett Walker added 747 commits

    added 747 commits

    Compare with previous version

  • 🤖 GitLab Bot 🤖 changed milestone to %14.8

    changed milestone to %14.8

  • Brett Walker changed milestone to %14.9

    changed milestone to %14.9

  • Brett Walker added 2543 commits

    added 2543 commits

    Compare with previous version

  • mentioned in issue #349240 (closed)

  • Brett Walker marked this merge request as ready

    marked this merge request as ready

  • Brett Walker marked this merge request as draft

    marked this merge request as draft

  • Brett Walker mentioned in issue #322933

    mentioned in issue #322933

  • Brett Walker added 1 commit

    added 1 commit

    • 4c8fb14d - Upgrade to 1.13.8 (from 1.12.23)

    Compare with previous version

  • Brett Walker changed the description

    changed the description

    • Resolved by Brett Walker

      Upgrading to 1.13.8 introduced Dynamic types. So at the moment I'm getting DuplicateNamesError for CreateInput and UpdateInput, stemming from graphql-1.13.8/lib/graphql/schema.rb:1036.

      This causes all specs to fail at the moment. So working on that...

  • Brett Walker marked this merge request as ready

    marked this merge request as ready

  • Brett Walker changed title from Draft: GraphQL: Convert to using the new query interpreter runtime to [graphql] Convert to using the new query interpreter runtime

    changed title from Draft: GraphQL: Convert to using the new query interpreter runtime to [graphql] Convert to using the new query interpreter runtime

  • Brett Walker changed title from [graphql] Convert to using the new query interpreter runtime to [graphql] ~graphql Convert to using the new query interpreter runtime

    changed title from [graphql] Convert to using the new query interpreter runtime to [graphql] ~graphql Convert to using the new query interpreter runtime

  • Brett Walker changed title from [graphql] ~graphql Convert to using the new query interpreter runtime to [graphql] ~GraphQL Convert to using the new query interpreter runtime

    changed title from [graphql] ~graphql Convert to using the new query interpreter runtime to [graphql] ~GraphQL Convert to using the new query interpreter runtime

  • Brett Walker changed title from [graphql] ~GraphQL Convert to using the new query interpreter runtime to [graphql] Convert to using the new query interpreter runtime

    changed title from [graphql] ~GraphQL Convert to using the new query interpreter runtime to [graphql] Convert to using the new query interpreter runtime

  • Brett Walker added 3558 commits

    added 3558 commits

    • 4c8fb14d...ef7e6556 - 3534 commits from branch master
    • 24d366dd - Initial move to the new GraphQL interpreter
    • d2ac8b7d - Create the new AST LoggerAnalyzer
    • e86cf9bd - Create the new AST RecursionAnalyzer
    • 4e5c5793 - Prepare to remove spec once graphql_interpreter
    • dbe289c6 - rubocop
    • 757950c4 - Fix some specs
    • c138e4b1 - override unauthorized_object(unauthorized_error)
    • 4b17d951 - Update some specs that raise an error
    • 3526aef1 - wip
    • f7b3c32c - Fix specs checking for an error to be raised
    • f9cb24ec - Fix arg handlling in GraphQL::Helpers
    • 5260ab52 - Fix specs checking for an error to be raised
    • 3cfdb0e5 - Must override == in the clas itself
    • 5c68d4cd - Fix error in schema
    • 66ca354a - Try using latest 1.12.21
    • caed7f20 - Fix spec error
    • d81602d1 - Procs are no longer supported
    • 9889b0ef - GraphQL::Pagination::Connections is now a default
    • 3a1e3bcb - Fix log tracer spec
    • 5e55c4dc - Check for object in FindClosest
    • ea9757a7 - Update to graphql 1.12.23
    • 5760e7de - Fix for detailed_status_type.rb
    • 1c1c168e - Fix more specs
    • b95b2562 - Upgrade to 1.13.8 (from 1.12.23)

    Compare with previous version

  • removed missed:13.12 label

  • removed missed:14.2 label

  • removed missed:14.3 label

  • removed missed:14.4 label

  • removed missed:14.5 label

  • removed missed:14.6 label

  • removed missed:14.7 label

  • Brett Walker added 413 commits

    added 413 commits

    • b95b2562...6b983bcb - 389 commits from branch master
    • 15be6588 - Initial move to the new GraphQL interpreter
    • 63e1287b - Create the new AST LoggerAnalyzer
    • d1269837 - Create the new AST RecursionAnalyzer
    • bd4fa59c - Prepare to remove spec once graphql_interpreter
    • 67886e88 - rubocop
    • 7eae09c6 - Fix some specs
    • 52523e53 - override unauthorized_object(unauthorized_error)
    • 63d17e4a - Update some specs that raise an error
    • 678eb68a - wip
    • bb818dc1 - Fix specs checking for an error to be raised
    • 883848d3 - Fix arg handlling in GraphQL::Helpers
    • a3c4cd5b - Fix specs checking for an error to be raised
    • 108439da - Must override == in the clas itself
    • 234fcac1 - Fix error in schema
    • 57dd7656 - Try using latest 1.12.21
    • edbc0234 - Fix spec error
    • 723fdda3 - Procs are no longer supported
    • ac31185a - GraphQL::Pagination::Connections is now a default
    • dae0fc7e - Fix log tracer spec
    • 753b055f - Check for object in FindClosest
    • 6e5006a1 - Update to graphql 1.12.23
    • d0daffdf - Fix for detailed_status_type.rb
    • 4ac13d76 - Fix more specs
    • 1df4286d - Upgrade to 1.13.8 (from 1.12.23)

    Compare with previous version

  • In order to save some CI minutes, I'm removing the pipeline:run-all-rspec and pipeline:run-as-if-foss labels. There is still a lot of work to do on this MR, and it's mostly a waste of time and resource running all those specs. We will need to add them back in once we're closer.

  • Brett Walker changed the description

    changed the description

  • Brett Walker added 207 commits

    added 207 commits

    • 1df4286d...6d33a4b8 - 182 commits from branch master
    • e6bede5e - Initial move to the new GraphQL interpreter
    • 22519875 - Create the new AST LoggerAnalyzer
    • 1736bab8 - Create the new AST RecursionAnalyzer
    • f97fd5ab - Prepare to remove spec once graphql_interpreter
    • 33124b91 - rubocop
    • 9d3d767b - Fix some specs
    • b834749f - override unauthorized_object(unauthorized_error)
    • 7e613860 - Update some specs that raise an error
    • 1a6ba8da - wip
    • e0bdc58f - Fix specs checking for an error to be raised
    • 98335428 - Fix arg handlling in GraphQL::Helpers
    • 01855fcc - Fix specs checking for an error to be raised
    • abddc69d - Must override == in the clas itself
    • 5683043a - Fix error in schema
    • 73d67715 - Try using latest 1.12.21
    • eb98ac48 - Fix spec error
    • 33888eac - Procs are no longer supported
    • f6ba5aa3 - GraphQL::Pagination::Connections is now a default
    • 17c7d0c3 - Fix log tracer spec
    • b918fa50 - Check for object in FindClosest
    • 28d43a43 - Update to graphql 1.12.23
    • 2b29fb2d - Fix for detailed_status_type.rb
    • 47c94add - Fix more specs
    • a38eb3e4 - Upgrade to 1.13.8 (from 1.12.23)
    • 08bab9a3 - Casues a GraphQL::Schema::DuplicateNamesError

    Compare with previous version

  • Luke Duncalfe mentioned in merge request !73603 (merged)

    mentioned in merge request !73603 (merged)

  • Kev mentioned in issue #353504

    mentioned in issue #353504

  • Brett Walker added 883 commits

    added 883 commits

    • 08bab9a3...060d5d36 - 858 commits from branch master
    • 94dad1c3 - Initial move to the new GraphQL interpreter
    • 74a8b5e0 - Create the new AST LoggerAnalyzer
    • 07a69971 - Create the new AST RecursionAnalyzer
    • ee7bde86 - Prepare to remove spec once graphql_interpreter
    • b210d686 - rubocop
    • f94432d9 - Fix some specs
    • 641e6462 - override unauthorized_object(unauthorized_error)
    • ef472d48 - Update some specs that raise an error
    • c122573b - wip
    • 1eed6091 - Fix specs checking for an error to be raised
    • 2ef513bf - Fix arg handlling in GraphQL::Helpers
    • 48c93856 - Fix specs checking for an error to be raised
    • 49821b9e - Must override == in the clas itself
    • 6dd7fbf9 - Fix error in schema
    • f2255e16 - Try using latest 1.12.21
    • caa82c50 - Fix spec error
    • 6a12637d - Procs are no longer supported
    • 29e8819e - GraphQL::Pagination::Connections is now a default
    • bb9dadd3 - Fix log tracer spec
    • 74c6c80c - Check for object in FindClosest
    • 09b3e8c7 - Update to graphql 1.12.23
    • 4f3d070d - Fix for detailed_status_type.rb
    • bda37ee6 - Fix more specs
    • 1a740531 - Upgrade to 1.13.8 (from 1.12.23)
    • 18a3c90c - Casues a GraphQL::Schema::DuplicateNamesError

    Compare with previous version

  • Brett Walker mentioned in commit daa5c48b

    mentioned in commit daa5c48b

  • Brett Walker added 1583 commits

    added 1583 commits

    • 18a3c90c...641cda46 - 1557 commits from branch master
    • 74f89a7b - Initial move to the new GraphQL interpreter
    • 46a6f9c7 - Create the new AST LoggerAnalyzer
    • 300b38c1 - Create the new AST RecursionAnalyzer
    • 477d888c - Prepare to remove spec once graphql_interpreter
    • c40bea23 - rubocop
    • 2f087d08 - Fix some specs
    • 1b9bc2a6 - override unauthorized_object(unauthorized_error)
    • 8aac4f74 - Update some specs that raise an error
    • 73bb0864 - wip
    • 6952eb3a - Fix specs checking for an error to be raised
    • 8bdcdfb8 - Fix arg handlling in GraphQL::Helpers
    • bcc11346 - Fix specs checking for an error to be raised
    • 3d8f7129 - Must override == in the clas itself
    • 42626217 - Fix error in schema
    • 0b9b3367 - Try using latest 1.12.21
    • 79c7160c - Fix spec error
    • 368c26fc - Procs are no longer supported
    • af771c29 - GraphQL::Pagination::Connections is now a default
    • 3c0645ff - Fix log tracer spec
    • b28a1851 - Check for object in FindClosest
    • baa9aa73 - Update to graphql 1.12.23
    • c6493f90 - Fix for detailed_status_type.rb
    • 9032fc0c - Fix more specs
    • 1bdd658e - Upgrade to 1.13.8 (from 1.12.23)
    • fc811d94 - Casues a GraphQL::Schema::DuplicateNamesError
    • 6209c187 - Add new expect_graphql_error_to_be_created

    Compare with previous version

  • Brett Walker added 23 commits

    added 23 commits

    • 2e6d5d7c - Create the new AST LoggerAnalyzer
    • 5a1abe48 - Create the new AST RecursionAnalyzer
    • 4e9eed88 - Fix some specs
    • 27cc9efe - override unauthorized_object(unauthorized_error)
    • e7be1c51 - Update some specs that raise an error
    • ed38f25c - wip
    • 6a8f207d - Fix specs checking for an error to be raised
    • 57125b27 - Fix arg handlling in GraphQL::Helpers
    • 830c4605 - Fix specs checking for an error to be raised
    • 0687c529 - Must override == in the clas itself
    • 5073d21e - Fix error in schema
    • 7730c063 - Try using latest 1.12.21
    • e59a2ded - Fix spec error
    • 76e3f1f9 - Procs are no longer supported
    • bc51fe4a - GraphQL::Pagination::Connections is now a default
    • 41265bbc - Fix log tracer spec
    • 818d6433 - Check for object in FindClosest
    • 60ff96da - Update to graphql 1.12.23
    • 2bc76ef5 - Fix for detailed_status_type.rb
    • 3901bc9d - Fix more specs
    • beb429fd - Upgrade to 1.13.8 (from 1.12.23)
    • c567b660 - Casues a GraphQL::Schema::DuplicateNamesError
    • 2a11ea49 - Add new expect_graphql_error_to_be_created

    Compare with previous version

  • Brett Walker added 5 commits

    added 5 commits

    • b0128730 - Update to graphql 1.13.8
    • 680e2627 - Fix for detailed_status_type.rb
    • b864b7c7 - Fix more specs
    • 8828e893 - Casues a GraphQL::Schema::DuplicateNamesError
    • 3aeeac05 - Add new expect_graphql_error_to_be_created

    Compare with previous version

  • Brett Walker added 1 commit

    added 1 commit

    • 41e9af9b - Update to graphql 1.13.8 and much more

    Compare with previous version

    • Resolved by Brett Walker

      When doing rspec spec/graphql/resolvers/user_resolver_spec.rb (and many other specs), consistently getting an error with Types::GroupType

      An error occurred while loading ./spec/graphql/resolvers/user_resolver_spec.rb.
      Failure/Error: base.class_eval(&@_prepended_block)
      
      NameError:
        uninitialized constant Types::EpicType::GroupType
        Did you mean?  Types::GroupType
                       GroupTree

      This seems to be from a circular definition. Types::GroupType, which is a subclass of Types::NamespaceType, has the field field :projects, Types::ProjectType.connection_type. Type::ProjectType has the field field :group, Types::GroupType. And round and round we go.

  • Brett Walker added 1 commit

    added 1 commit

    • 1bad2001 - Use quotes for circular field definitions

    Compare with previous version

  • charlie ablett mentioned in merge request !82651 (merged)

    mentioned in merge request !82651 (merged)

  • Brett Walker added 338 commits

    added 338 commits

    • 1bad2001...2d5c86dd - 333 commits from branch master
    • ef65132e - Initial move to the new GraphQL interpreter
    • ddc36126 - Create the new AST LoggerAnalyzer
    • a9485111 - Create the new AST RecursionAnalyzer
    • c21e721e - Update to graphql 1.13.8 and much more
    • bb992ee9 - Adjust how args are built for testing

    Compare with previous version

  • Brett Walker mentioned in merge request !75373 (merged)

    mentioned in merge request !75373 (merged)

  • Brett Walker mentioned in merge request !82739 (merged)

    mentioned in merge request !82739 (merged)

  • Brett Walker added 1 commit

    added 1 commit

    • 619a0ec0 - Additional removal of to_graphql

    Compare with previous version

  • Brett Walker added 1 commit

    added 1 commit

    • 37092375 - to_graphql is deprecated, begin removing

    Compare with previous version

  • Brett Walker added 2 commits

    added 2 commits

    • 345d9874 - Additional removal of to_graphql
    • 46c080e8 - to_graphql is deprecated, begin removing

    Compare with previous version

  • Brett Walker added 1 commit

    added 1 commit

    • e359bdbc - Method to_graphql is deprecated, begin removing

    Compare with previous version

  • Brett Walker added 293 commits

    added 293 commits

    • e359bdbc...58c71c08 - 286 commits from branch master
    • 654a8303 - Initial move to the new GraphQL interpreter
    • 70355c03 - Create the new AST LoggerAnalyzer
    • 0498c14e - Create the new AST RecursionAnalyzer
    • 1fa06fd3 - Update to graphql 1.13.8 and much more
    • 52759bde - Adjust how args are built for testing
    • 084d58fb - Additional removal of to_graphql
    • f18d4706 - Method to_graphql is deprecated, begin removing

    Compare with previous version

  • Brett Walker mentioned in merge request !82928 (merged)

    mentioned in merge request !82928 (merged)

  • Brett Walker added 5 commits

    added 5 commits

    • 7c64f0b2 - Removal of to_graphql only possible on this branch
    • cf788ed4 - Method to_graphql is deprecated, begin removing
    • 37674f59 - Fix signature of get_type
    • 61350993 - Method to_graphql is deprecated, begin removing
    • da8ea4ef - FIx one of many specs

    Compare with previous version

  • Brett Walker added 274 commits

    added 274 commits

    • da8ea4ef...2f06ef37 - 265 commits from branch master
    • 12d56885 - Initial move to the new GraphQL interpreter
    • 1ee40c85 - Create the new AST LoggerAnalyzer
    • ee3da3c6 - Create the new AST RecursionAnalyzer
    • 839b17c6 - Update to graphql 1.13.8 and much more
    • 691f0c0c - Adjust how args are built for testing
    • 69aa8152 - Removal of to_graphql only possible on this branch
    • 7b2b38b9 - Fix signature of get_type
    • d96afa74 - Method to_graphql is deprecated, begin removing
    • 5cc028dc - FIx one of many specs

    Compare with previous version

  • removed feature flag label

  • Brett Walker changed milestone to %15.0

    changed milestone to %15.0

  • Brett Walker added 607 commits

    added 607 commits

    • 5cc028dc...3dbb300d - 598 commits from branch master
    • 32fb49c1 - Initial move to the new GraphQL interpreter
    • acdb2a27 - Create the new AST LoggerAnalyzer
    • c23485be - Create the new AST RecursionAnalyzer
    • bd333909 - Update to graphql 1.13.8 and much more
    • 4e323af4 - Adjust how args are built for testing
    • 980958b7 - Removal of to_graphql only possible on this branch
    • ca60b718 - Fix signature of get_type
    • c16663d6 - Method to_graphql is deprecated, begin removing
    • a34d880b - FIx one of many specs

    Compare with previous version

  • Brett Walker added 3 commits

    added 3 commits

    • 7e70ba21 - Removal of to_graphql only possible on this branch
    • 4c9615e1 - Fix signature of get_type
    • f0cc01a7 - FIx one of many specs

    Compare with previous version

  • Brett Walker added 265 commits

    added 265 commits

    • f0cc01a7...03ec52ec - 257 commits from branch master
    • 0eaad917 - Initial move to the new GraphQL interpreter
    • 676cbbce - Create the new AST LoggerAnalyzer
    • a268ecf6 - Create the new AST RecursionAnalyzer
    • ec972115 - Update to graphql 1.13.8 and much more
    • 6b3bdf5c - Adjust how args are built for testing
    • 462e027d - Removal of to_graphql only possible on this branch
    • 58957505 - Fix signature of get_type
    • e8d0f880 - FIx one of many specs

    Compare with previous version

  • Ghost User
  • 4 Warnings
    :warning: This merge request is quite big (1007 lines changed), please consider splitting it into multiple merge requests.
    :warning: This merge request includes more than 10 commits. Each commit should meet the following criteria:
    1. Have a well-written commit message.
    2. Has all tests passing when used on its own (e.g. when using git checkout SHA).
    3. Can be reverted on its own without also requiring the revert of commit that came before it.
    4. Is small enough that it can be reviewed in isolation in under 30 minutes or so.

    If this merge request contains commits that do not meet this criteria and/or contains intermediate work, please rebase these commits into a smaller number of commits or split this merge request into multiple smaller merge requests.

    :warning: ef1b520c: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
    :warning: 76171c5f: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Tarun Vellishetty (@tvellishetty) (UTC+5.5, 10.5 hours ahead of @digitalmoksha) Etienne Baqué (@ebaque) (UTC+3, 8 hours ahead of @digitalmoksha)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    Generated by :no_entry_sign: Danger

  • Brett Walker added 425 commits

    added 425 commits

    • e8d0f880...56cbc645 - 417 commits from branch master
    • f7ec71a7 - Initial move to the new GraphQL interpreter
    • 3f746d7d - Create the new AST LoggerAnalyzer
    • 3a63c6e6 - Create the new AST RecursionAnalyzer
    • 350799ad - Update to graphql 1.13.8 and much more
    • 497b3130 - Adjust how args are built for testing
    • 1a512080 - Removal of to_graphql only possible on this branch
    • b487896d - Fix signature of get_type
    • 34b7477d - FIx one of many specs

    Compare with previous version

  • Brett Walker added 4 commits

    added 4 commits

    • 6105990c - Will get fixed in master
    • f373e8ce - Use 1.13.11 of grapql gem
    • cc753857 - Override new complexity calculation to use our own
    • 9c922e02 - Fix some failing specs

    Compare with previous version

  • Brett Walker added 936 commits

    added 936 commits

    • 9c922e02...3042e325 - 925 commits from branch master
    • 88430365 - Initial move to the new GraphQL interpreter
    • 3c63d169 - Create the new AST LoggerAnalyzer
    • 9aeb32b1 - Create the new AST RecursionAnalyzer
    • 02d9a424 - Update to graphql 1.13.8 and much more
    • 5e9c18b1 - Adjust how args are built for testing
    • 66c0e243 - Removal of to_graphql only possible on this branch
    • bf8cd142 - Fix signature of get_type
    • f2aacbf8 - FIx one of many specs
    • b364bd4b - Use 1.13.11 of grapql gem
    • abec90a8 - Override new complexity calculation to use our own
    • 74d553eb - Fix some failing specs

    Compare with previous version

  • Brett Walker added 547 commits

    added 547 commits

    • 74d553eb...57c8d634 - 536 commits from branch master
    • ce5f9a61 - Initial move to the new GraphQL interpreter
    • 34236e85 - Create the new AST LoggerAnalyzer
    • 9807ace2 - Create the new AST RecursionAnalyzer
    • 32b7e6ea - Update to graphql 1.13.8 and much more
    • 9c751929 - Adjust how args are built for testing
    • 0fb77791 - Removal of to_graphql only possible on this branch
    • a255fae1 - Fix signature of get_type
    • 8c225ec2 - FIx one of many specs
    • ef5bd254 - Use 1.13.11 of grapql gem
    • a2e2cfd9 - Override new complexity calculation to use our own
    • 59b7efa3 - Fix some failing specs

    Compare with previous version

  • Brett Walker added 1658 commits

    added 1658 commits

    • 59b7efa3...20c22cf0 - 1647 commits from branch master
    • 0afd39a7 - Initial move to the new GraphQL interpreter
    • b193559c - Create the new AST LoggerAnalyzer
    • 6239230e - Create the new AST RecursionAnalyzer
    • d2a8c317 - Update to graphql 1.13.8 and much more
    • 3c8cc9ed - Adjust how args are built for testing
    • 34d10bd9 - Removal of to_graphql only possible on this branch
    • ce1a7f4c - Fix signature of get_type
    • c17319d4 - FIx one of many specs
    • f65dc9ce - Use 1.13.11 of grapql gem
    • 4bd5bde1 - Override new complexity calculation to use our own
    • 85d13cd4 - Fix some failing specs

    Compare with previous version

  • Suggested Reviewers (beta)

    This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

    The individuals below may be good candidates to participate in the review based on various factors.

    After you review all recommendations, please assign reviewers manually, as this is not done automatically.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Reviewers
    @cablett, @rspeicher, @acroitor, @.luke, @smcgivern

    If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot

  • Brett Walker added 206 commits

    added 206 commits

    • 85d13cd4...66675c34 - 195 commits from branch master
    • c3b847ef - Initial move to the new GraphQL interpreter
    • 5f0e84f6 - Create the new AST LoggerAnalyzer
    • cff291f9 - Create the new AST RecursionAnalyzer
    • 15caa23d - Update to graphql 1.13.8 and much more
    • 31015416 - Adjust how args are built for testing
    • 23b08bda - Removal of to_graphql only possible on this branch
    • 645602ff - Fix signature of get_type
    • 16936baf - FIx one of many specs
    • 890ffa37 - Use 1.13.11 of grapql gem
    • 12506b03 - Override new complexity calculation to use our own
    • fe68c97d - Fix some failing specs

    Compare with previous version

  • Suggested Reviewers (beta)

    This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

    The individuals below may be good candidates to participate in the review based on various factors.

    After you review all recommendations, please assign reviewers manually, as this is not done automatically.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Reviewers
    @cablett, @rspeicher, @acroitor, @.luke, @smcgivern

    If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot

  • Brett Walker added 1 commit

    added 1 commit

    Compare with previous version

  • Suggested Reviewers (beta)

    This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

    The individuals below may be good candidates to participate in the review based on various factors.

    After you review all recommendations, please assign reviewers manually, as this is not done automatically.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Reviewers
    @cablett, @rspeicher, @acroitor, @.luke, @smcgivern

    If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot

  • Brett Walker added 764 commits

    added 764 commits

    • 3196b2b1...ed2b355e - 751 commits from branch master
    • 32b1cff0 - Initial move to the new GraphQL interpreter
    • 7bbfcce8 - Create the new AST LoggerAnalyzer
    • f6d97d15 - Create the new AST RecursionAnalyzer
    • 3622cef1 - Update to graphql 1.13.8 and much more
    • 8eace71f - Adjust how args are built for testing
    • 190c0a48 - Removal of to_graphql only possible on this branch
    • 2dff5694 - Fix signature of get_type
    • 861132b1 - FIx one of many specs
    • 4c14d925 - Use 1.13.11 of grapql gem
    • 2a8cba74 - Override new complexity calculation to use our own
    • 4e3ab2ad - Fix some failing specs
    • ef4d7ca4 - Use 1.13.12 of grapql gem
    • 57976e5d - Multiple methods of handling arguments for specs

    Compare with previous version

  • Suggested Reviewers (beta)

    The individuals below may be good candidates to participate in the review based on various factors.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Suggested Reviewers
    @digitalmoksha, @DylanGriffith, @jprovaznik, @.luke, @mkozono

    If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".

    Edited by GitLab Reviewer-Recommender Bot
  • Brett Walker mentioned in merge request !84093 (closed)

    mentioned in merge request !84093 (closed)

  • mentioned in issue #355926 (closed)

  • Brett Walker added 261 commits

    added 261 commits

    • 57976e5d...b1f8abae - 248 commits from branch master
    • 83560fec - Initial move to the new GraphQL interpreter
    • 9eb122f5 - Create the new AST LoggerAnalyzer
    • 6164bd90 - Create the new AST RecursionAnalyzer
    • 7064c54d - Update to graphql 1.13.8 and much more
    • 2e61eb98 - Adjust how args are built for testing
    • 68e54ebf - Removal of to_graphql only possible on this branch
    • c4958e03 - Fix signature of get_type
    • 6b100c05 - FIx one of many specs
    • c0cb98c2 - Use 1.13.11 of grapql gem
    • 6a1be257 - Override new complexity calculation to use our own
    • 0fce2762 - Fix some failing specs
    • e3a8923a - Use 1.13.12 of grapql gem
    • 0cf415e9 - Multiple methods of handling arguments for specs

    Compare with previous version

  • Brett Walker added 2 commits

    added 2 commits

    • 99effd7e - Updates to GraphqlHelpers
    • 9767e50d - Merge branch 'bw-graphql-interpreter-mutations-fix' into bw-graphql-interpreter

    Compare with previous version

  • Brett Walker added 2 commits

    added 2 commits

    • facc30a8 - Fix GraphQL::Schema::DuplicateNamesError errors
    • 9808ef4e - Merge branch 'bw-graphql-interpreter-features-fix' into bw-graphql-interpreter

    Compare with previous version

  • Brett Walker added 261 commits

    added 261 commits

    • 9808ef4e...81545146 - 243 commits from branch master
    • b2c871cf - Initial move to the new GraphQL interpreter
    • 13bc8057 - Create the new AST LoggerAnalyzer
    • 8645aae7 - Create the new AST RecursionAnalyzer
    • b4560732 - Update to graphql 1.13.8 and much more
    • dcfc189e - Adjust how args are built for testing
    • acf9f4ed - Removal of to_graphql only possible on this branch
    • 5605a1ec - Fix signature of get_type
    • 82b4a32b - FIx one of many specs
    • 88b22de9 - Use 1.13.11 of grapql gem
    • 0891af82 - Override new complexity calculation to use our own
    • 2e4b4640 - Fix some failing specs
    • 04bbdc01 - Use 1.13.12 of grapql gem
    • 944e2240 - Multiple methods of handling arguments for specs
    • 85eef127 - Updates to GraphqlHelpers
    • f99dc9c9 - Fix GraphQL::Schema::DuplicateNamesError errors
    • 786eda9d - Remove use of GraphQL::Schema.define
    • 4205f548 - Skip spec for now
    • 1ec5dbba - Don’t redefine connection arguments

    Compare with previous version

  • Brett Walker changed the description

    changed the description

  • Brett Walker added 317 commits

    added 317 commits

    • 1ec5dbba...ec322c8a - 299 commits from branch master
    • bc9456d0 - Initial move to the new GraphQL interpreter
    • 97208da5 - Create the new AST LoggerAnalyzer
    • 0bf79b93 - Create the new AST RecursionAnalyzer
    • 9c814b00 - Update to graphql 1.13.8 and much more
    • c4bb8684 - Adjust how args are built for testing
    • f3e3693c - Removal of to_graphql only possible on this branch
    • ddd49aa1 - Fix signature of get_type
    • 2110c640 - FIx one of many specs
    • 09166485 - Use 1.13.11 of grapql gem
    • 0c872b72 - Override new complexity calculation to use our own
    • 7d9b37ab - Fix some failing specs
    • 8ef72f5b - Use 1.13.12 of grapql gem
    • e9a7d82b - Multiple methods of handling arguments for specs
    • 19e425a8 - Updates to GraphqlHelpers
    • d4ca8d91 - Fix GraphQL::Schema::DuplicateNamesError errors
    • 6a200e6b - Remove use of GraphQL::Schema.define
    • 7b762238 - Skip spec for now
    • c6a80ed2 - Don’t redefine connection arguments

    Compare with previous version

  • Brett Walker added 149 commits

    added 149 commits

    • c6a80ed2...bbff15ea - 131 commits from branch master
    • f6fd2e5b - Initial move to the new GraphQL interpreter
    • 1c7c1f60 - Create the new AST LoggerAnalyzer
    • 06f92ee5 - Create the new AST RecursionAnalyzer
    • b5fdea2a - Update to graphql 1.13.8 and much more
    • 3fa2742c - Adjust how args are built for testing
    • c6450d7f - Removal of to_graphql only possible on this branch
    • 703c1bd9 - Fix signature of get_type
    • e791c0cd - FIx one of many specs
    • fdc6e0f8 - Use 1.13.11 of grapql gem
    • e2aab3ba - Override new complexity calculation to use our own
    • 66df78ca - Fix some failing specs
    • a2960616 - Use 1.13.12 of grapql gem
    • 58508753 - Multiple methods of handling arguments for specs
    • d3e06dc7 - Updates to GraphqlHelpers
    • 8926d344 - Fix GraphQL::Schema::DuplicateNamesError errors
    • b24b498f - Remove use of GraphQL::Schema.define
    • 19f7d3b8 - Skip spec for now
    • a57dc2e9 - Don’t redefine connection arguments

    Compare with previous version

  • Brett Walker added 585 commits

    added 585 commits

    • a57dc2e9...4c71d6e1 - 567 commits from branch master
    • 1b7ad976 - Initial move to the new GraphQL interpreter
    • b52f2bce - Create the new AST LoggerAnalyzer
    • 7292c517 - Create the new AST RecursionAnalyzer
    • 3d41818b - Update to graphql 1.13.8 and much more
    • 33bc073b - Adjust how args are built for testing
    • ba8569ad - Removal of to_graphql only possible on this branch
    • 2a8c7f1d - Fix signature of get_type
    • 99e91d71 - FIx one of many specs
    • bf6a0b49 - Use 1.13.11 of grapql gem
    • 2d47cecb - Override new complexity calculation to use our own
    • aca73012 - Fix some failing specs
    • 57dd0b7e - Use 1.13.12 of grapql gem
    • 05101ba4 - Multiple methods of handling arguments for specs
    • 5a0b464c - Updates to GraphqlHelpers
    • 33435093 - Fix GraphQL::Schema::DuplicateNamesError errors
    • 134126de - Remove use of GraphQL::Schema.define
    • eca98d2b - Skip spec for now
    • 7f10ae7a - Don’t redefine connection arguments

    Compare with previous version

  • Brett Walker added 195 commits

    added 195 commits

    • 7f10ae7a...f5344f1e - 177 commits from branch master
    • 35802539 - Initial move to the new GraphQL interpreter
    • 332a2ca6 - Create the new AST LoggerAnalyzer
    • f7dda33c - Create the new AST RecursionAnalyzer
    • b5dc1a13 - Update to graphql 1.13.8 and much more
    • 09c69a6b - Adjust how args are built for testing
    • 28491cca - Removal of to_graphql only possible on this branch
    • 1126093f - Fix signature of get_type
    • 99ce2d88 - FIx one of many specs
    • a5b21a9a - Use 1.13.11 of grapql gem
    • 9cfc240f - Override new complexity calculation to use our own
    • 2cc7ef32 - Fix some failing specs
    • 5d61fece - Use 1.13.12 of grapql gem
    • 4de0a9d5 - Multiple methods of handling arguments for specs
    • 5a804f16 - Updates to GraphqlHelpers
    • 174d8258 - Fix GraphQL::Schema::DuplicateNamesError errors
    • 5eb2a165 - Remove use of GraphQL::Schema.define
    • c51f15b7 - Skip spec for now
    • 3399f674 - Don’t redefine connection arguments

    Compare with previous version

  • Brett Walker added 1 commit

    added 1 commit

    Compare with previous version

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits f5344f1e and 8c3fd1b1

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.46 MB 3.45 MB -6.38 KB -0.2 %
    mainChunk 1.93 MB 1.93 MB - 0.0 %

    :tada: Significant Reduction: 4

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.projects.edit 2.81 MB 2.16 MB -674.21 KB -23.4 %
    pages.projects.merge_requests.creations.diffs 2.33 MB 1.68 MB -673.18 KB -28.2 %
    pages.projects.merge_requests.edit 2.33 MB 1.68 MB -673.18 KB -28.2 %
    pages.projects.merge_requests.creations.new 2.39 MB 1.73 MB -672.66 KB -27.5 %

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Brett Walker added 1 commit

    added 1 commit

    Compare with previous version

  • Brett Walker added 1 commit

    added 1 commit

    Compare with previous version

  • Ghost User
  • Ghost User
  • Ghost User
  • Brett Walker added 682 commits

    added 682 commits

    • 8c3fd1b1...57b3f319 - 649 commits from branch master
    • 8b434005 - Initial move to the new GraphQL interpreter
    • ffee7a34 - Create the new AST LoggerAnalyzer
    • b0d8f0a5 - Create the new AST RecursionAnalyzer
    • 3560441e - Update to graphql 1.13.8 and much more
    • e2a5e014 - Adjust how args are built for testing
    • 099dd00f - Removal of to_graphql only possible on this branch
    • d500cd16 - Fix signature of get_type
    • 8bea38be - FIx one of many specs
    • 64e349d1 - Use 1.13.11 of grapql gem
    • 697ce64b - Override new complexity calculation to use our own
    • 2bad841b - Fix some failing specs
    • 1741ca53 - Use 1.13.12 of grapql gem
    • f67246ad - Multiple methods of handling arguments for specs
    • d14b8f93 - Updates to GraphqlHelpers
    • 1738d65f - Fix GraphQL::Schema::DuplicateNamesError errors
    • 61bd1cbf - Remove use of GraphQL::Schema.define
    • 0a0e2933 - Skip spec for now
    • be68080a - Don’t redefine connection arguments
    • 41d53b73 - Various spec fixes
    • b430aa49 - BaseInputObject must return super from `prepare`
    • dfde1dc8 - Fix for api/graphql/iteration_spec.rb
    • 129a607c - Attempt to fix find_closest
    • 224e8553 - Remove prepare from NegatedBoardIssueInputType
    • 16c89713 - Fix CI specs
    • 7798cb05 - Fix for merge_request_spec.rb
    • 11c50397 - Return nil if TimeType is nil
    • 4e03082e - Fix the reposition_image_diff_note_spec.rb
    • a81a9215 - Fix spec design_management/delete_spec.rb
    • c62e6cfc - Check for keyword_arguments
    • dd1f42bb - Default value should be same type as argument
    • f5e0284c - Fix for graphql_spec
    • ed4533cd - Fix for iterations/create_spec.rb
    • 396b2642 - DEBUG_GRAPHQL=1 now ignores graphql tracers

    Compare with previous version

  • Brett Walker changed the description

    changed the description

  • Brett Walker added 1505 commits

    added 1505 commits

    • 396b2642...f3e60983 - 1472 commits from branch master
    • f0812b41 - Initial move to the new GraphQL interpreter
    • ea915831 - Create the new AST LoggerAnalyzer
    • 5c880d8e - Create the new AST RecursionAnalyzer
    • b440130b - Update to graphql 1.13.8 and much more
    • 1b0a01e4 - Adjust how args are built for testing
    • 915276a3 - Removal of to_graphql only possible on this branch
    • 8d6bd866 - Fix signature of get_type
    • 2f4fed40 - FIx one of many specs
    • a92098dd - Use 1.13.11 of grapql gem
    • a142c969 - Override new complexity calculation to use our own
    • ccf71266 - Fix some failing specs
    • a06fca46 - Use 1.13.12 of grapql gem
    • 88ea5265 - Multiple methods of handling arguments for specs
    • b09183ea - Updates to GraphqlHelpers
    • 1825706f - Fix GraphQL::Schema::DuplicateNamesError errors
    • cfdd37b1 - Remove use of GraphQL::Schema.define
    • 34b380f0 - Skip spec for now
    • 88811008 - Don’t redefine connection arguments
    • 6a397fe1 - Various spec fixes
    • 186d075b - BaseInputObject must return super from `prepare`
    • 2edbc0c6 - Fix for api/graphql/iteration_spec.rb
    • bf3a7edf - Attempt to fix find_closest
    • 43d7ba26 - Remove prepare from NegatedBoardIssueInputType
    • 8aeaad68 - Fix CI specs
    • e903e397 - Fix for merge_request_spec.rb
    • f3b5dd4d - Return nil if TimeType is nil
    • d3daba7f - Fix the reposition_image_diff_note_spec.rb
    • 00ed1940 - Fix spec design_management/delete_spec.rb
    • f4c464b7 - Check for keyword_arguments
    • ff4d32f7 - Default value should be same type as argument
    • 0097f411 - Fix for graphql_spec
    • ffc2e93a - Fix for iterations/create_spec.rb
    • da9c7a1c - DEBUG_GRAPHQL=1 now ignores graphql tracers

    Compare with previous version

  • Brett Walker changed milestone to %15.1

    changed milestone to %15.1

  • Brett Walker added 2 commits

    added 2 commits

    • 97dd1739 - Remove a binding.pry
    • 4bba4aa8 - See if infitine recursion check is really needed

    Compare with previous version

  • Brett Walker added 1 commit

    added 1 commit

    • 7d509b38 - Fix specs for TimeType and StatusActionType

    Compare with previous version

  • Brett Walker added 2 commits

    added 2 commits

    • 3285333a - Fix repository_spec.rb and rubocop
    • ce553e93 - Fix spec with NegatedIssueFilterInputType

    Compare with previous version

  • Brett Walker mentioned in merge request !87295 (merged)

    mentioned in merge request !87295 (merged)

  • Brett Walker added 507 commits

    added 507 commits

    • ce553e93...a6c8a083 - 469 commits from branch master
    • 000dafcf - Initial move to the new GraphQL interpreter
    • fa47861e - Create the new AST LoggerAnalyzer
    • 9768fbfa - Create the new AST RecursionAnalyzer
    • 7712a378 - Update to graphql 1.13.8 and much more
    • 1fb433f3 - Adjust how args are built for testing
    • 73ee87e4 - Removal of to_graphql only possible on this branch
    • a4480dc6 - Fix signature of get_type
    • 6b963b4d - FIx one of many specs
    • 0ba571ef - Use 1.13.11 of grapql gem
    • 2378e870 - Override new complexity calculation to use our own
    • e105b71b - Fix some failing specs
    • 198fc25f - Use 1.13.12 of grapql gem
    • 8720fecf - Multiple methods of handling arguments for specs
    • 39a163e5 - Updates to GraphqlHelpers
    • 46a1ed3b - Fix GraphQL::Schema::DuplicateNamesError errors
    • 0b223482 - Remove use of GraphQL::Schema.define
    • 7905c0d5 - Skip spec for now
    • 50591247 - Don’t redefine connection arguments
    • 4d4e7bda - Various spec fixes
    • 77428ef0 - BaseInputObject must return super from `prepare`
    • 2a0c4279 - Fix for api/graphql/iteration_spec.rb
    • 4ef4ca4a - Attempt to fix find_closest
    • 7b98cee2 - Remove prepare from NegatedBoardIssueInputType
    • b75812a1 - Fix CI specs
    • 3708cffb - Fix for merge_request_spec.rb
    • bf038281 - Return nil if TimeType is nil
    • fad79f3d - Fix the reposition_image_diff_note_spec.rb
    • b39123d8 - Fix spec design_management/delete_spec.rb
    • ec197397 - Check for keyword_arguments
    • f1e6fbb3 - Default value should be same type as argument
    • ca09140f - Fix for graphql_spec
    • c743d986 - Fix for iterations/create_spec.rb
    • c0fef2d4 - DEBUG_GRAPHQL=1 now ignores graphql tracers
    • 19aacf0a - Remove a binding.pry
    • 5326d42c - See if infitine recursion check is really needed
    • 9edd42a1 - Fix specs for TimeType and StatusActionType
    • 69e9e1d4 - Fix repository_spec.rb and rubocop
    • ff4ae558 - Fix spec with NegatedIssueFilterInputType

    Compare with previous version

  • Brett Walker added 44 commits

    added 44 commits

    • ff4ae558...d13bb990 - 9 commits from branch master
    • bbfe61c4 - Initial move to the new GraphQL interpreter
    • 6247f1f0 - Create the new AST LoggerAnalyzer
    • aaeb4ca4 - Create the new AST RecursionAnalyzer
    • a5dab4c9 - Update to graphql 1.13.8 and much more
    • 4a676f1c - Adjust how args are built for testing
    • 0c6ea632 - Removal of to_graphql only possible on this branch
    • 4ed48b5e - Fix signature of get_type
    • 59a51943 - FIx one of many specs
    • ac78ad23 - Use 1.13.11 of grapql gem
    • 55449a98 - Override new complexity calculation to use our own
    • 475e4b21 - Fix some failing specs
    • 09fecc3a - Use 1.13.12 of grapql gem
    • 66028de2 - Multiple methods of handling arguments for specs
    • d2233c45 - Updates to GraphqlHelpers
    • a7d21202 - Remove use of GraphQL::Schema.define
    • 58d6e781 - Skip spec for now
    • 5796bc6d - Don’t redefine connection arguments
    • c4da4002 - Various spec fixes
    • 326a49f1 - BaseInputObject must return super from `prepare`
    • 85bc3fa0 - Fix for api/graphql/iteration_spec.rb
    • 5a9b46e0 - Attempt to fix find_closest
    • a0384a7f - Remove prepare from NegatedBoardIssueInputType
    • 02accdde - Fix CI specs
    • 583ec0ce - Fix for merge_request_spec.rb
    • 2d2fcca3 - Return nil if TimeType is nil
    • cbc9f954 - Fix the reposition_image_diff_note_spec.rb
    • eee0281e - Fix spec design_management/delete_spec.rb
    • a9e8a0f4 - Check for keyword_arguments
    • e59b9082 - Fix for graphql_spec
    • f683ab46 - Fix for iterations/create_spec.rb
    • 8df4b49b - DEBUG_GRAPHQL=1 now ignores graphql tracers
    • 2636c006 - See if infitine recursion check is really needed
    • b8193a18 - Fix specs for TimeType and StatusActionType
    • bbeff0e5 - Fix repository_spec.rb and rubocop
    • ca0ce5ad - Fix spec with NegatedIssueFilterInputType

    Compare with previous version

  • Brett Walker added 2 commits

    added 2 commits

    • a1b6a801 - Remove some no longer needed changes
    • 123bb5d2 - Fix for tree_resolver

    Compare with previous version

  • Brett Walker added 3 commits

    added 3 commits

    • d0d7ddf6 - Fix spec with NegatedIssueFilterInputType
    • a800e3f7 - Remove some no longer needed changes
    • 100c8a5a - Fix for tree_resolver

    Compare with previous version

  • Brett Walker added 1 commit

    added 1 commit

    • 2cb2e7d1 - Change since an exception is no longer raised

    Compare with previous version

  • mentioned in issue #363130 (closed)

  • Oh my gosh, we've got green on the major pipeline!! :tada:

    Screen_Shot_2022-05-22_at_2.04.06_PM

  • Brett Walker added 1 commit

    added 1 commit

    • 8e2ea9f2 - Remove feature flag as it’s not currently used

    Compare with previous version

  • Brett Walker added 2 commits

    added 2 commits

    Compare with previous version

  • Brett Walker added 1 commit

    added 1 commit

    Compare with previous version

  • Brett Walker added 1 commit

    added 1 commit

    Compare with previous version

  • Brett Walker added 78 commits

    added 78 commits

    • c15a28a1...35978329 - 37 commits from branch master
    • 15d2f25a - Initial move to the new GraphQL interpreter
    • 5edf2802 - Create the new AST LoggerAnalyzer
    • b8f2d428 - Create the new AST RecursionAnalyzer
    • e1b3a4dd - Update to graphql 1.13.8 and much more
    • 99413422 - Adjust how args are built for testing
    • c5025962 - Removal of to_graphql only possible on this branch
    • 1ef68a46 - Fix signature of get_type
    • 132a2a68 - FIx one of many specs
    • 896304a6 - Use 1.13.11 of grapql gem
    • ba3955fd - Override new complexity calculation to use our own
    • 20fdc0b5 - Fix some failing specs
    • d08ad48a - Use 1.13.12 of grapql gem
    • 3baab308 - Multiple methods of handling arguments for specs
    • 74d9d476 - Updates to GraphqlHelpers
    • 59f37aba - Remove use of GraphQL::Schema.define
    • b99fb3c0 - Skip spec for now
    • ff57ebf6 - Don’t redefine connection arguments
    • e0420504 - Various spec fixes
    • 3a97b3a1 - BaseInputObject must return super from `prepare`
    • 71d7a101 - Fix for api/graphql/iteration_spec.rb
    • 762c5dae - Attempt to fix find_closest
    • 6a31f00b - Remove prepare from NegatedBoardIssueInputType
    • ef8ebef6 - Fix CI specs
    • 1e18cc8d - Fix for merge_request_spec.rb
    • a673c2ce - Return nil if TimeType is nil
    • bfa53717 - Fix the reposition_image_diff_note_spec.rb
    • 31103bc2 - Fix spec design_management/delete_spec.rb
    • f1be68fd - Check for keyword_arguments
    • b134ed23 - Fix for graphql_spec
    • b33f2310 - Fix for iterations/create_spec.rb
    • 9c1db0ff - DEBUG_GRAPHQL=1 now ignores graphql tracers
    • 7eabb1da - See if infitine recursion check is really needed
    • 1019c11b - Fix specs for TimeType and StatusActionType
    • cb5eb2ce - Fix repository_spec.rb and rubocop
    • 47f12143 - Fix spec with NegatedIssueFilterInputType
    • fe03aadf - Remove some no longer needed changes
    • c3c4ab68 - Fix for tree_resolver
    • c6752a58 - Change since an exception is no longer raised
    • 78e05997 - Remove feature flag as it’s not currently used
    • 2d32948f - Remove use of metadata[:type_class]
    • c372ec9b - Remove some cruft

    Compare with previous version

  • Brett Walker added 143 commits

    added 143 commits

    • c372ec9b...ba1b4b96 - 106 commits from branch master
    • 438e89cf - Initial move to the new GraphQL interpreter
    • 88249b60 - Create the new AST LoggerAnalyzer
    • ce658d14 - Create the new AST RecursionAnalyzer
    • 19e6e589 - Update to graphql 1.13.8 and much more
    • 31b5730a - Adjust how args are built for testing
    • 23c82b38 - Removal of to_graphql only possible on this branch
    • c286b763 - Fix signature of get_type
    • 7b025bc4 - FIx one of many specs
    • 497befdf - Use 1.13.11 of grapql gem
    • 9e37f9a9 - Override new complexity calculation to use our own
    • a368bae3 - Fix some failing specs
    • da6b3b11 - Use 1.13.12 of grapql gem
    • a90e2f4e - Multiple methods of handling arguments for specs
    • 42180ce5 - Updates to GraphqlHelpers
    • 40730043 - Skip spec for now
    • e72ee175 - Don’t redefine connection arguments
    • 5f35c228 - Various spec fixes
    • 1ef865aa - BaseInputObject must return super from `prepare`
    • 0c4f739d - Fix for api/graphql/iteration_spec.rb
    • edc517ad - Attempt to fix find_closest
    • 6ef2a299 - Remove prepare from NegatedBoardIssueInputType
    • 5c6e6725 - Fix CI specs
    • 161679fa - Fix for merge_request_spec.rb
    • 75e22a21 - Return nil if TimeType is nil
    • bc3e999a - Fix the reposition_image_diff_note_spec.rb
    • 9707dd89 - Fix spec design_management/delete_spec.rb
    • 3c9bed47 - Check for keyword_arguments
    • 9095b09f - Fix for graphql_spec
    • 190b7b18 - Fix for iterations/create_spec.rb
    • e6711e59 - DEBUG_GRAPHQL=1 now ignores graphql tracers
    • 95c0064a - See if infitine recursion check is really needed
    • d645b1dd - Fix specs for TimeType and StatusActionType
    • 4e83152a - Fix repository_spec.rb and rubocop
    • 968af708 - Remove some no longer needed changes
    • 5ca1911b - Remove feature flag as it’s not currently used
    • 1fc8b010 - Remove use of metadata[:type_class]
    • efa5b6cb - Remove some cruft

    Compare with previous version

  • Brett Walker added 1 commit

    added 1 commit

    • 1a6b8122 - Remove some unnecessary code

    Compare with previous version

  • Brett Walker added 2 commits

    added 2 commits

    • 31cc4a19 - Remove some unnecessary code
    • e3845bb7 - Try removing overridden complexity

    Compare with previous version

  • Brett Walker added 1 commit

    added 1 commit

    • 42dd7ff9 - Remove some unnecessary code

    Compare with previous version

  • requested review from @alexkalderimis

  • Alex Kalderimis
  • Alex Kalderimis
  • Alex Kalderimis
  • Alex Kalderimis
  • Alex Kalderimis
  • Brett Walker added 1 commit

    added 1 commit

    • 3844b73f - Rename method to as_graphql_argument_literals

    Compare with previous version

  • Brett Walker added 1 commit

    added 1 commit

    • 32864ba3 - Link to removal of GenericTracing

    Compare with previous version

  • mentioned in issue #363240 (closed)

  • Brett Walker added 1 commit

    added 1 commit

    • fb019ef6 - Refactor into find_parent_object

    Compare with previous version

    • Resolved by Alex Kalderimis

      Ok, question for both of you (@alexkalderimis, @.luke)

      There is no way to feature flag this. And I had originally thought we might need some extended testing through staging or something in order to merge this.

      But after pushing so much into master before, the tests running cleanly and many of the remaining changes relatively small, I'm wondering if we can just proceed as normal. Though I would probably announce this in the #production channel.

  • Brett Walker marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Brett Walker added 101 commits

    added 101 commits

    Compare with previous version

  • Squashed and rebased...

    • Resolved by Alex Kalderimis

      Thanks @digitalmoksha - I do have one serious blocking concern

      To demonstrate this, I created !88371 (closed), which adds the missing specification for FindParent (see 760a35bc). This test passes on master, and fails on this branch with:

      FindClosest
        alpha.beta.alpha.gamma (FAILED - 1)
        beta.alpha.beta.gamma (FAILED - 2)
        can run a simple query
      
      Failures:
      
        1) FindClosest alpha.beta.alpha.gamma
           Failure/Error: closest_parent([alpha_t], parent)[:id]
      
           NoMethodError:
             undefined method `[]' for nil:NilClass
           # ./spec/graphql/types/concerns/find_closest_spec.rb:80:in `block (3 levels) in <top (required)>'
           # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:826:in `public_send'
           # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:826:in `block in public_send_field'
           # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:911:in `with_extensions'
           # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:803:in `public_send_field'
           # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:717:in `block in resolve'
           # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema.rb:118:in `after_lazy'
           # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:715:in `resolve'
           ... # elided for clarity
           # ./spec/graphql/types/concerns/find_closest_spec.rb:120:in `block (2 levels) in <top (required)>'
      
        2) FindClosest beta.alpha.beta.gamma
           Failure/Error: closest_parent([alpha_t], parent)[:id]
      
           NoMethodError:
             undefined method `[]' for nil:NilClass
           # ./spec/graphql/types/concerns/find_closest_spec.rb:80:in `block (3 levels) in <top (required)>'
           # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:826:in `public_send'
           # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:826:in `block in public_send_field'
           # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:911:in `with_extensions'
           # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:803:in `public_send_field'
           # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:717:in `block in resolve'
           # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema.rb:118:in `after_lazy'
           # /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema/field.rb:715:in `resolve'
           ... # elided for clarity
           # ./spec/graphql/types/concerns/find_closest_spec.rb:147:in `block (2 levels) in <top (required)>'
      
      Finished in 0.01378 seconds (files took 4.66 seconds to load)
      3 examples, 2 failures
      
      Failed examples:
      
      rspec ./spec/graphql/types/concerns/find_closest_spec.rb:102 # FindClosest alpha.beta.alpha.gamma
      rspec ./spec/graphql/types/concerns/find_closest_spec.rb:129 # FindClosest beta.alpha.beta.gamma

      I think this demonstrates pretty clearly that this is broken, and right now my suspicion is that it cannot work and we need to rethink this. I hoped that maybe Context#path would work as a replacement, but in this test it always returns [].

      I am also more than a little concerned that our request tests don't cover any of this, and we need to (separately) add request specs for fields that use this functionality, which by my count is (thankfully) just the following two files:

      • app/graphql/types/ci/runner_web_url_edge.rb: RunnerWebUrlEdge.runner_url
      • app/graphql/types/merge_requests/interacts_with_merge_request.rb: User.merge_request_interaction

      We can probably replace them with some variant on the scoped-context value passing we used to deal with this in passing down design versions, if the interpreter does not support general introspection.

      Thoughts @digitalmoksha

  • Alex Kalderimis mentioned in commit 92e5919a

    mentioned in commit 92e5919a

  • Alex Kalderimis mentioned in merge request !88477 (closed)

    mentioned in merge request !88477 (closed)

  • Brett Walker added 221 commits

    added 221 commits

    Compare with previous version

  • Alex Kalderimis added 3 commits

    added 3 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 03ce3d47 - Handle parenting in connections

    Compare with previous version

  • Rebasing...

  • Brett Walker added 35 commits

    added 35 commits

    Compare with previous version

  • Brett Walker added 108 commits

    added 108 commits

    Compare with previous version

  • Rebasing again to fix broken master

  • Alex Kalderimis added 10 commits

    added 10 commits

    Compare with previous version

  • Alex Kalderimis approved this merge request

    approved this merge request

  • Alex Kalderimis requested review from @cablett and removed review request for @alexkalderimis

    requested review from @cablett and removed review request for @alexkalderimis

  • :wave: @alexkalderimis, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Looks like an unrelated pipeline failure...again...rebasing...

  • Brett Walker added 85 commits

    added 85 commits

    Compare with previous version

  • I think it's a flaky time based problem, but don't have the energy to deal with it right now. Will restart the spec later, it'll probably clear up.

  • Brett Walker requested review from @.luke

    requested review from @.luke

  • Pipeline is geeen!! Go go go!! :grin::joy:

  • Brett Walker added 146 commits

    added 146 commits

    Compare with previous version

  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe removed review request for @.luke

    removed review request for @.luke

  • Brett Walker added 38 commits

    added 38 commits

    Compare with previous version

  • Brett Walker added 9 commits

    added 9 commits

    Compare with previous version

  • Brett Walker requested review from @.luke

    requested review from @.luke

  • Brett Walker added 1 commit

    added 1 commit

    • a3cee09b - Remove duplicate fields from logger

    Compare with previous version

  • Brett Walker added 10 commits

    added 10 commits

    Compare with previous version

  • Luke Duncalfe removed review request for @.luke

    removed review request for @.luke

  • charlie ablett
  • charlie ablett
  • charlie ablett
  • charlie ablett
  • charlie ablett
  • charlie ablett
  • charlie ablett
  • charlie ablett
  • charlie ablett
  • charlie ablett
  • charlie ablett
  • charlie ablett requested review from @furkanayhan

    requested review from @furkanayhan

  • charlie ablett removed review request for @cablett

    removed review request for @cablett

  • charlie ablett requested review from @lauraX

    requested review from @lauraX

  • Brett Walker added 407 commits

    added 407 commits

    Compare with previous version

  • Furkan Ayhan removed review request for @furkanayhan

    removed review request for @furkanayhan

  • Brett Walker mentioned in issue #364059

    mentioned in issue #364059

  • Brett Walker changed the description

    changed the description

  • charlie ablett mentioned in issue #364061

    mentioned in issue #364061

  • @digitalmoksha This MR depends on one closed MR according to the widget above:

    image

    This is sorted, so you might want to remove the MR dependency :smile:

  • Brett Walker added 3 commits

    added 3 commits

    • 9907c909 - Add clarification comment in status_action_type.rb
    • fc07dcc2 - Adjust loggers to original output
    • 099813cf - Minor refactors based on suggestions

    Compare with previous version

  • Luke Duncalfe approved this merge request

    approved this merge request

  • Brett Walker added 5 commits

    added 5 commits

    • 47517e46 - Adjust loggers to original output
    • a4e726b5 - Minor refactors based on suggestions
    • d686cc05 - Fix flakiness due to dates
    • 98072095 - Set RequestStore same as the old logger does
    • 3a7529e3 - Use query_double instead of double(‘query’)

    Compare with previous version

  • Ghost User
  • Ghost User
  • Brett Walker added 155 commits

    added 155 commits

    • 3a7529e3...46b037d2 - 141 commits from branch master
    • 7721ae20 - Move to the new GraphQL interpreter
    • a0893c14 - Remove FindClosest module
    • 01f041ba - Add spec for Group.runners
    • 07e69e50 - Remove uses of FindClosest
    • 6c8b9785 - Remove dead code
    • 8312456a - Handle parenting in connections
    • a7ab0835 - Remove duplicate fields from logger
    • 58fcdbb9 - Remove unnecessary ENV['DEBUG_GRAPHQL']
    • 7b29c772 - Add clarification comment in status_action_type.rb
    • 56f3d6c3 - Adjust loggers to original output
    • 3ab94372 - Minor refactors based on suggestions
    • 0c1aa534 - Fix flakiness due to dates
    • f1b8bb36 - Set RequestStore same as the old logger does
    • aab0e82f - Use query_double instead of double(‘query’)

    Compare with previous version

  • Brett Walker requested review from @cablett

    requested review from @cablett

  • charlie ablett approved this merge request

    approved this merge request

  • Brett Walker resolved all threads

    resolved all threads

  • Brett Walker added 82 commits

    added 82 commits

    • aab0e82f...3abf3aa8 - 68 commits from branch master
    • 76171c5f - Move to the new GraphQL interpreter
    • 3b70d694 - Remove FindClosest module
    • 3eb44f67 - Add spec for Group.runners
    • 82fab95a - Remove uses of FindClosest
    • 06e516e8 - Remove dead code
    • 286ccd66 - Handle parenting in connections
    • 65ec8801 - Remove duplicate fields from logger
    • 2f52ff35 - Remove unnecessary ENV['DEBUG_GRAPHQL']
    • 49f8fe8f - Add clarification comment in status_action_type.rb
    • ef1b520c - Adjust loggers to original output
    • 992329d6 - Minor refactors based on suggestions
    • 1afb3e92 - Fix flakiness due to dates
    • 169c6d2c - Set RequestStore same as the old logger does
    • e9d56ab6 - Use query_double instead of double(‘query’)

    Compare with previous version

  • Alex Kalderimis resolved all threads

    resolved all threads

  • Alex Kalderimis enabled an automatic merge when the pipeline for 82f8b853 succeeds

    enabled an automatic merge when the pipeline for 82f8b853 succeeds

    • Resolved by Brett Walker

      To be sent to the #production, #development, and #f_graphql slack channels.


      We will soon be merging an upgrade to the GraphQL gem. It utilizes a new underlying architecture, so there was a bit of work to start using it. There are no user facing changes to worry about. We will be monitoring the upgrade as it progresses through deployment.

      !27536 (merged)

      Some benefits:

      • we can use runtime directives! (see for example a new @modelId directive).
      • we can use validators!
      • faster! better!

      Developers may need to rebase their branches once the merge happens. If you're writing vanilla code, there should be no changes needed. Documentation will be updated soon. You can get the very rough notes at !88694 (merged)


      @alexkalderimis anything we should change?

      Edited by Brett Walker
  • Brett Walker resolved all threads

    resolved all threads

  • Alex Kalderimis mentioned in commit 031723aa

    mentioned in commit 031723aa

    • Sweet - it's merged and the pipeline on master finished green. Woohoo! :tada:

    • Fantastic - I have discovered probably our first follow-up:

      Legacy `.graphql_definition` objects are deprecated and will be removed in GraphQL-Ruby 2.0. Use a class-based definition instead.
      
      Called on GitlabSchema from:
         /home/git/gitlab/tooling/graphql/docs/renderer.rb:25:in `initialize'
        /home/git/gitlab/lib/tasks/gitlab/graphql.rake:114:in `new'
        /home/git/gitlab/lib/tasks/gitlab/graphql.rake:114:in `block (3 levels) in <main>'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:281:in `block in execute'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:281:in `each'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:281:in `execute'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/sentry-ruby-core-5.1.1/lib/sentry/rake.rb:26:in `execute'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:219:in `block in invoke_with_call_chain'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:199:in `synchronize'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:199:in `invoke_with_call_chain'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:188:in `invoke'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:160:in `invoke_task'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:116:in `block (2 levels) in top_level'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:116:in `each'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:116:in `block in top_level'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:125:in `run_with_threads'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:110:in `top_level'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:83:in `block in run'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:186:in `standard_exception_handling'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:80:in `run'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
        /data/cache/bundle-2.7.5/ruby/2.7.0/bin/rake:23:in `load'
        /data/cache/bundle-2.7.5/ruby/2.7.0/bin/rake:23:in `<top (required)>'
        /usr/local/lib/ruby/2.7.0/bundler/cli/exec.rb:63:in `load'
        /usr/local/lib/ruby/2.7.0/bundler/cli/exec.rb:63:in `kernel_load'
      Legacy `.to_graphql` objects are deprecated and will be removed in GraphQL-Ruby 2.0. Remove `.to_graphql` to use a class-based definition instead.
      
      Called on GitlabSchema from:
         /data/cache/bundle-2.7.5/ruby/2.7.0/gems/graphql-1.13.12/lib/graphql/schema.rb:921:in `graphql_definition'
        /home/git/gitlab/tooling/graphql/docs/renderer.rb:25:in `initialize'
        /home/git/gitlab/lib/tasks/gitlab/graphql.rake:114:in `new'
        /home/git/gitlab/lib/tasks/gitlab/graphql.rake:114:in `block (3 levels) in <main>'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:281:in `block in execute'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:281:in `each'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:281:in `execute'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/sentry-ruby-core-5.1.1/lib/sentry/rake.rb:26:in `execute'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:219:in `block in invoke_with_call_chain'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:199:in `synchronize'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:199:in `invoke_with_call_chain'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:188:in `invoke'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:160:in `invoke_task'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:116:in `block (2 levels) in top_level'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:116:in `each'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:116:in `block in top_level'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:125:in `run_with_threads'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:110:in `top_level'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:83:in `block in run'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:186:in `standard_exception_handling'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:80:in `run'
        /data/cache/bundle-2.7.5/ruby/2.7.0/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
        /data/cache/bundle-2.7.5/ruby/2.7.0/bin/rake:23:in `load'
        /data/cache/bundle-2.7.5/ruby/2.7.0/bin/rake:23:in `<top (required)>'
        /usr/local/lib/ruby/2.7.0/bundler/cli/exec.rb:63:in `load'
      Documentation compiled.

      when compiling the docs

    • Yep - one of many on the road to 2.0.x &8119 (closed)

      I really think we should try and keep up the momentum to get to 2.0

    • Please register or sign in to reply
  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #364156 (closed)

  • mentioned in issue #364141 (closed)

  • Brett Walker mentioned in merge request !89263 (merged)

    mentioned in merge request !89263 (merged)

  • Brett Walker mentioned in merge request !88694 (merged)

    mentioned in merge request !88694 (merged)

  • mentioned in issue #382190 (closed)

  • Please register or sign in to reply
    Loading