Backport of 'Index SBOM occurrences for parent lookup in graph build' into 19.4
What does this MR do and why?
This MR backports !257547 (merged) to 19.4. It is a clean cherry-pick of the default branch commit 6ecca2b8, and the diff is identical. The 19.5 backport is !262206 (merged).
Sbom::BuildDependencyGraph looked up the parent of each dependency with a linear scan over all occurrences of the project. This made the graph build quadratic in the number of occurrences. The change builds an in-memory index once and looks up each parent in constant time. The behavior does not change.
This is part of the fix for #593156 (closed) (severity1). On large dependency graphs, Sbom::BuildDependencyGraphWorker jobs run for hours and block other Sidekiq jobs. A GitLab Dedicated customer on 19.4 is affected (INC-15911).
!257547 (merged) has the typemaintenance label, but it fixes part of the typebug issue #593156 (closed).
This is the first of three 19.4 backports for #593156 (closed). The second (!257548 (merged)) and third (!257733 (merged)) are stacked on this MR. Merge them in order.
Testing
On a GDK sandbox, with RAILS_ENV=test, with this change applied to 19-4-stable-ee at ad668d36:
| Spec | Result |
|---|---|
build_dependency_graph_spec, build_dependency_graph_worker_spec, graph_path_spec |
50 examples, 0 failures |
rubocopon the changed files reports no offenses.
Pushed with all pre-push hooks passing. The hooks in lefthook.yml compute their file list from git merge-base origin/master HEAD, so on a stable branch they would lint every file where 19.4 differs from master. A local, gitignored lefthook-local.yml pointed that merge base at origin/19-4-stable-ee instead, so the hooks checked only this change.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
- This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
- The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
- The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
- Required labels have been applied to this merge request
- severity label and bug subtype labels (if applicable)
- If this MR fixes a bug that affects customers, the customer label has been applied.
- This MR has been approved by a maintainer (only one approval is required).
- Ensure the
E2E Omnibus GitLab EEpipeline (triggered by thee2e:test-on-omnibus-eejob) has succeeded. If it has failed (or shows warnings), investigate the failures. If you determine the failures are unrelated, you may proceed. If you need assistance investigating, request help in the #s_developer_experience Slack channel to confirm the failures are unrelated to the merge request.
Note to the merge request author and maintainer
If you have questions about the patch release process, please:
- Refer to the patch release runbook for engineers and maintainers for guidance.
- Ask questions on the
#releasesSlack channel (internal only). - Once the backport has been merged, the commit changes will be automatically deployed to a release environment that can be used for manual validation. See after merging runbook for details.