Backport of 'Index SBOM occurrences for parent lookup in graph build' into 19.5

What does this MR do and why?

This MR backports !257547 (merged) to 19.5. It is a clean cherry-pick of the default branch commit, and the diff is identical.

Sbom::BuildDependencyGraph looked up the parent of each dependency with a linear scan over all occurrences of the project. This made the graph build quadratic in the number of occurrences. The change builds an in-memory index once and looks up each parent in constant time. The behavior does not change.

This is part of the fix for #593156 (severity1). On large dependency graphs, Sbom::BuildDependencyGraphWorker jobs run for hours and block other Sidekiq jobs. This affects GitLab Dedicated and self-managed instances. This MR targets the first 19.5 patch release.

!257547 (merged) has the typemaintenance label, but it fixes part of the typebug issue #593156.

This is the first of three backports for #593156. Separate backport MRs for !257548 (merged) and !257733 follow after !257733 merges on the default branch.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
  • Required labels have been applied to this merge request
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the E2E Omnibus GitLab EE pipeline (triggered by thee2e:test-on-omnibus-ee job) has succeeded. If it has failed (or shows warnings), investigate the failures. If you determine the failures are unrelated, you may proceed. If you need assistance investigating, request help in the #s_developer_experience Slack channel to confirm the failures are unrelated to the merge request.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Edited by Lucas Charles

Merge request reports

Loading
Loading