Skip to content

Geo Replication - Parameterized API

Zack Cuddy requested to merge 208470_02-geo-replication-api into master

What does this MR do?

Currently, the UI components for Geo Replicable Items is isolated to Geo Designs Only. As we move forward, it will be easier if we have a generalized place in the UI to house different replicable data types, without spinning up additional UI components when possible.

This MR is an effort to implement the above describe changes in a readable and MVC type change.

This MR splits off from: !26410 (closed)

This MR in particular adds the prop replicationType. This prop is used in the geo_replication api to denote which type of replicable we are using.

It also updates the ee/api to use the replicableType as a param

This MR also removes an un-used prop designManagementLink which had been removed use but not removed from the data props.

GIF

Existing Functionality still works Kapture_2020-03-06_at_15.06.21

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Zack Cuddy

Merge request reports