Draft: [skip ci] Remove REST fallbacks from the pipelines table rows
What does this MR do and why?
This MR removes the REST fallbacks from the pipelines table rows.
It is the last MR of the mr_pipelines_graphql feature flag removal, and it is stacked on !266232.
ci/common/pipelines_table.vue and its row components accepted REST rows and GraphQL rows.
The legacy REST table was the last caller that passed REST rows, and the previous MR deletes it.
These are the callers that remain, and all of them pass GraphQL nodes:
- The project pipelines page,
pipelines_app.vue - The commit Pipelines tab and the new merge request page,
commit_pipelines_list.vue - The merge request Pipelines tab,
pipelines_table_wrapper.vue
So the MR removes each snake_case, flags.* and details.* branch, and keeps the GraphQL branch next to it.
The changed components are:
pipelines_table.vuepipeline_url.vuepipeline_labels.vuepipeline_operations.vue. The REST-to-GraphQL adapter for the stop modal is removed.pipeline_triggerer.vuepipeline_status_badge.vuepipelines_timeago.vue
Knip cannot find this kind of dead code, because the components are still in use.
Each removed branch was checked against the GraphQL fields that the callers query.
Their fragments share PipelineListItemBase.
The specs of these components now use GraphQL-shaped rows, built on mockBranchPipeline.
The table specs (CE and EE) no longer use the REST fixture pipelines/pipelines.json.
commit_pipeline_status_spec.js still uses that fixture, so the fixture stays.
The REST mocks mockPipeline, mockPipelineBranch and mockPipelineTag have no users left, so the MR deletes them.
Not in this MR
pipeline_url.vuebuilds the branch link as the relative pathcommits/<ref>. That link is wrong on the commit Pipelines tab. This MR keeps the behaviour unchanged. #637016 tracks the fix.
Screenshots or screen recordings
No visual change is intended. GraphQL rows render the same as before. Not verified in GDK, because another session holds the GDK checkout.
How to set up and validate locally
- Open Build > Pipelines for a project. The badges (
latest,branch,merge request,merged results,fork) show as before. - On a pipeline row, select Cancel. The confirmation modal shows the pipeline ID, ref and commit.
- Open the Pipelines tab of a merge request and of a commit. The table renders.
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Local verification
- Jest passes, 882 tests:
spec/frontend/ci/commonspec/frontend/ci/pipelines_page/componentsspec/frontend/ci/merge_requestsspec/frontend/merge_request_tabs_spec.jsee/spec/frontend/ci/common
commit_pipelines_list_spec.js,pipelines_app_spec.jsandpipeline_header_spec.jsfail in my local worktree. They fail the same way without these MRs, so CI is the check for them.- ESLint, Prettier and the
unused-spec-codecheck pass. - Knip reports no new unused production code after this MR.
- A separate review agent found no production caller that still passes REST rows, and no GraphQL behaviour that lost coverage in the spec rewrites.
References
- Last MR of the stack:
- Feature specs for the new merge request page: !266595 (merged)
- GraphQL field for the new merge request page: !266573 (merged)
- Mount the Pipelines tab with
initVueApp: !269491 (merged) - New merge request page on GraphQL: !266580
- Remove the flag: !266232
- This MR
- Rollout issue: #419726
- New merge request page work: #637319
- Found here and left unchanged, wrong branch link on the commit Pipelines tab: #637016