Allow selecting all queues with sidekiq-cluster

What does this MR do?

Because it was designed for selecting specific queues, sidekiq-cluster didn't have a convenient method to select all queues. As we want this to become the default sidekiq entry point for all GitLab installations, and the default is to handle all queues in a single process, we need that option.

(This was possible before: using --experimental-queue-selector, you could ask for something like has_external_dependencies=true,false, but that's not obvious.)

Instead of making * a wildcard anywhere, which would be more general, this commit just allows a single * in a queue group to represent all queues. While this is less general, it's also simpler to implement, and we can assume that YAGNI for the wildcards.

For gitlab-com/gl-infra/scalability#169.

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry
• Documentation (if required)

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.

changed milestone to %12.9

added Background Processing groupscalability typefeature labels

added 1 commit

• aef1cc0b - Allow selecting all queues with sidekiq-cluster

Compare with previous version

mentioned in issue gitlab-com/gl-infra/scalability#169

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

Category	Reviewer	Maintainer
backend	Matthias Käppler (@mkaeppler)	Heinrich Lee Yu (@engwan)

Generated by Danger

@mkaeppler roulette picked you, which is handy, as you've got some context here. Could you take a look and let me know what you think, please? (Not just of the code, but the approach overall.)

@eread could you review the docs side, please?

assigned to @eread and @mkaeppler and unassigned @smcgivern

approved this merge request

unassigned @eread

added Technical Writing docsfeature documentation labels

unapproved this merge request

assigned to @smcgivern

approved this merge request

unassigned @mkaeppler

added 1 commit

• a1cb85f1 - Apply suggestion to doc/administration/operations/extra_sidekiq_processes.md

Compare with previous version