Skip to content

Ensure RepositoryLinkFilter handles Gitaly failures gracefully

What does this MR do?

We do this by setting all paths to :blob type if we get either GRPC::Unavailable or GRPC::DeadlineExceeded when calling GitalyClient. This means we don't embed images/videos, but that's ok as we don't have access to the underlying object anyways if Gitaly is down

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Refs #196883 (closed)

Edited by Mario de la Ossa

Merge request reports