Skip to content

Partly support `monaco-editor` in Jest

Himanshu Kapoor requested to merge 119194-jest-monaco-partial-support into master

What does this MR do?

This MR partly fixes the issue: #119194 (closed) as per the comment #119194 (comment 276517494).

Current situation: A jest test fails even if monaco-editor is imported in the file, even if it isn't used.

After this MR: Files that import files that import monaco-editor can be tested, even if monaco editor itself isn't used in the test. This will fix the job https://gitlab.com/gitlab-org/gitlab/-/jobs/457212129 and unblock MR !26360 (merged)

This still wont completely fix everything, but at least allow us to port a few more files to Jest (including the tests in MR !26360 (merged)) until we come up with a proper fix (or a good mock for Monaco).

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Himanshu Kapoor

Merge request reports