Skip to content

Fix MIME / encoding related issues in Web IDE file uploader

Himanshu Kapoor requested to merge 26113-file-type-issue into master

What does this MR do?

Fix issues with non-ASCII plain text files being incorrectly uploaded as binary in the Web IDE. The issue is fixed by asking Monaco whether this file is in the list of supported file types based on MIME or based on extension.

Issue: #26113 (closed)

Screenshots

There are four cases mentioned in #26113 (closed). The first two work fine. The fourth case was fixed in !23761 (merged). This MR fixes the case 3:

Before After
Screenshot Screenshot_2020-03-03_at_3.59.53_PM Screenshot_2020-03-03_at_4.01.44_PM
Description Valid code file with non-ASCII content is treated as binary. A code file is treated as text, regardless of its contents.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Himanshu Kapoor

Merge request reports