Fix MIME / encoding related issues in Web IDE file uploader
What does this MR do?
Fix issues with non-ASCII plain text files being incorrectly uploaded as binary in the Web IDE. The issue is fixed by asking Monaco whether this file is in the list of supported file types based on MIME or based on extension.
Issue: #26113 (closed)
Screenshots
There are four cases mentioned in #26113 (closed). The first two work fine. The fourth case was fixed in !23761 (merged). This MR fixes the case 3:
Before | After | |
---|---|---|
Screenshot | ||
Description | Valid code file with non-ASCII content is treated as binary. | A code file is treated as text, regardless of its contents. |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Himanshu Kapoor