Backport of 'Return repository_storage from internal Orbit project info' to 19.4

What does this MR do and why?

Backport of !262513 (merged) to 19.4.

It adds repository_storage to the response of the internal Orbit endpoint GET /internal/orbit/project/:project_id/info. The Orbit code indexer uses it to budget archive fetches per Gitaly storage instead of one tenant-wide budget, as a follow-up to a recent incident on GitLab.com. The consumer change is gitlab-org/orbit/knowledge-graph!2847 (merged). It treats the field as optional and falls back to the tenant-wide budget when it is missing, so older GitLab versions work without it.

This is not a bug fix. The maintenance policy allows only bug fixes in patch releases, so merging this needs a release-policy exception under the Exception Process. I have not requested one. Without it, this MR should not be merged.

The change itself is small: the field is additive and always present for an existing project, and the endpoint is hidden and internal. The docs change keeps the endpoint documentation in line with the response.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
  • Required labels have been applied to this merge request
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the E2E Omnibus GitLab EE pipeline (triggered by thee2e:test-on-omnibus-ee job) has succeeded. If it has failed (or shows warnings), investigate the failures. If you determine the failures are unrelated, you may proceed. If you need assistance investigating, request help in the #s_developer_experience Slack channel to confirm the failures are unrelated to the merge request.

The first checkbox stays unchecked because this is a maintenance change rather than a bug fix (see above). Severity, bug subtype and customer labels don't apply for the same reason. Maintainer approval and the E2E Omnibus pipeline are still pending.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Agent context
  • Cherry-picked with git cherry-pick -x from e1101138 (squash commit of the original MR).
  • Changed files: ee/lib/api/internal/orbit.rb, ee/spec/requests/api/internal/orbit_spec.rb, doc/development/internal_api/orbit.md.
  • Ran ee/spec/requests/api/internal/orbit_spec.rb on a per-worktree test database: 236 examples, 0 failures. RuboCop on the two Ruby files: no offenses.
  • The lefthook mermaidlint hook fails locally because node modules are missing, so the commit and push used LEFTHOOK=0 after the other hooks passed.
  • The template's /assign me quick action was dropped (assignee set explicitly). /label ~backport was kept as an explicit label, together with the non-workflow labels of the original MR. Milestone is the target version.
Edited by Dmitry Gruzd

Merge request reports

Loading
Loading