Remove duo_workplan_async_flow in favor of workplan flag

Stefanos Xanthopoulosrequested to merge
duo/refactor/632854-remove-duo-workplan-async-flow into master

What does this MR do and why?

Removes the duo_workplan_async_flow feature flag. Everything it gated now sits behind the existing workplan flag, so one flag turns the whole workplan feature on or off.

  • Services (GenerateWorkplanService, ResumeWorkplanService, UpdateWorkflowStatusService), the AgentPlanType questions resolver, and the workplan/v1 foundational flow catalog entry now check workplan. They still use the root_ancestor actor.
  • The project and group work item controllers now push :workplan to the frontend where they used to push :duo_workplan_async_flow.
  • Vue components (work_item_plan_cta.vue, work_item_workplan.vue, duo_question_note.vue) now read glFeatures.workplan.
  • GraphQL field and mutation descriptions are updated, along with the generated GraphQL docs and public/-/graphql/introspection_result.json.
  • ee/config/feature_flags/wip/duo_workplan_async_flow.yml is deleted.

Where this differs from the workplan: the plan assumed workplan was already pushed to the frontend and said to delete the push lines. It is not pushed anywhere (grep for push_frontend_feature_flag(:workplan finds nothing), so this MR swaps the flag in the push lines instead of deleting them. The plan also missed duo_question_note.vue and work_item_workplan.vue (and their specs), which read the old flag. Both are updated here.

Rollout risk: any environment that has workplan on and duo_workplan_async_flow off will start running the async flow. Please confirm no environment is set up that way before merging.

No changelog entry: workplan is default-off.

References

Screenshots or screen recordings

No UI changes. The same UI is now shown when workplan is enabled.

How to set up and validate locally

  1. Feature.enable(:workplan) in the Rails console. You no longer need to enable duo_workplan_async_flow.
  2. Open a project work item that has the workplan widget and check that the async "Generate workplan" path is offered.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports