Update Ingress chart version to 1.29.7
What does this MR do?
There is an issue related to clusterIP which got fixed in version 1.29.7 . In addition to bumping the version it is also required adding new fields into values.yaml.
This is going to allow us to upgrade Ingress through cluster apps.
Without this change, the following error occur:
UPGRADE FAILED
Error: Service "ingress-nginx-ingress-controller" is invalid: spec.clusterIP: Invalid value: "": field is immutable && Service "ingress-nginx-ingress-default-backend" is invalid: spec.clusterIP: Invalid value: "": field is immutable
Error: UPGRADE FAILED: Service "ingress-nginx-ingress-controller" is invalid: spec.clusterIP: Invalid value: "": field is immutable && Service "ingress-nginx-ingress-default-backend" is invalid: spec.clusterIP: Invalid value: "": field is immutable
Another option is to query the clusterIP for both services and add them into the values when updating. This approach would be costly because of the extra requests to k8s cluster.
The issue can only be reproduced on GKE. Local environments like Minikube won't be affected by it.
Related MR to update ingress in cluster application: gitlab-org/cluster-integration/cluster-applications!61 (merged)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
1.29.3
(chart 1.29.7
)
QA Checklist - Working locally with GKE but still have to be performed on staging.
-
User application routing functions as expected -
Nginx application metrics reporting as expected -
Modsecurity reporting as expected -
Cert Manager working as expected -
Ingress uninstallation cleans up relevant objects -
Check if the log size has been changed. It might require updating packet_size
for syslog export.