Skip to content
Snippets Groups Projects

Fix/x509 signed commit

Merged Roger Meier requested to merge siemens/gitlab:fix/x509-signed-commit into master

What does this MR do?

This MR fixes a bug reported within #207612 (closed)

  • crlDistributionPoints had multiple entries and this was not handled properly
  • Subjects with commas not properly displayed

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Thong Kuah

Merge request reports

Merge request pipeline #124494632 passed

Merge request pipeline passed for 6b8831d8

Test coverage 84.70% from 2 jobs

Merged by Thong KuahThong Kuah 5 years ago (Mar 10, 2020 4:08am UTC)

Loading

Pipeline #124742498 failed

Pipeline: omnibus-gitlab-mirror

#124746421

    Pipeline failed for 7d93f8ae on master

    Test coverage 71.70% from 2 jobs
    4 environments impacted.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    Please register or sign in to reply
    Loading