Remove CheckParity from ai_harness doctor tool

Denys Mishunovrequested to merge
duo/refactor/630472-doctor-remove-check-parity into master

What does this MR do and why?

Removes the CheckParity check entirely from the ai_harness doctor tool. The check existed to enforce the CLAUDE.md/AGENTS.md identical-content parity convention; with CLAUDE.md being removed across the repo, the check is obsolete. The doctor now runs three checks instead of four:

  1. .ai/ reference resolution
  2. .gitignore coverage
  3. Forbidden committed files

Changes:

  • Delete tooling/ai_harness/doctor/steps/perform_doctor_checks/check_parity.rb and deregister it from the ROP chain in perform_doctor_checks/main.rb
  • Delete spec/tooling/ai_harness/doctor/steps/perform_doctor_checks/check_parity_spec.rb
  • Rewrite parity-related scenarios in integration_spec.rb (drop the describe 'parity check' block, CLAUDE.md writes in setups, and parity-based --fix tests) and update main_spec.rb to the three-check ordered chain
  • Update all five SPECIFICATION files (00_process–04_scenarios) and tooling/ai_harness/doctor/AGENTS.md (+ its CLAUDE.md copy) to describe the three-check tool; CLAUDE.local.md entries stay (local override, not a parity copy)
  • Point stale Gitlab/NoCodeCoverageComment references (previously pointing at the deleted check_parity.rb) at check_ai_references.rb, which now carries the explanation comment inline
  • Update the .ai-harness-doctor-patterns comment in .gitlab/ci/rules.gitlab-ci.yml (the **/CLAUDE.md trigger path is kept because CLAUDE.md files still exist in the repo until the follow-up stream removes them)

References

  • Resolves #630472
  • Workplan: agent_plan widget on the linked work item (stream 1-C)

Screenshots or screen recordings

N/A — CLI tooling change, no UI.

How to set up and validate locally

  1. Run the doctor specs: 
    bin/rspec spec/tooling/ai_harness/doctor/
    Expected: 122 examples, 0 failures.
  2. Run the doctor against the real repo: 
    scripts/ai_harness/doctor
    Expected: exit 0 with three OK checks (.ai/ reference resolution, .gitignore coverage, Forbidden committed files).

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports