Skip to content

Preload associations needed by Namespace#pages_virtual_domain

What does this MR do?

While looking at the performance if the /internal/pages API endpoint we noticed that there are couple N+1 queries problems:

This MR updates Namespace#pages_virtual_domain to preload project_feature and route in order to avoid this.

Related to #207096 (closed).

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Grzegorz Bizon

Merge request reports