Fix/pipeline details invalid buttons
What does this MR do?
This MR is based on feedback received in !21365 (comment 277386544). It seems that the new Pipeline Deletion via UI feature wasn't working for pipelines with invalid YAML definitions.
An initial investigation showed, that due to the different DOM structure between invalid and valid pipeline definitions (app/views/projects/pipelines/show.html.haml:11), the initialisation of some JavaScript classes were failing. The pipeline-header (Vue component) was therefore not initialised and the Delete pipeline button hence not visible.
The feature specs weren't covering this scenario, as the invalid pipeline use-case was not in-sync with the actual pipeline behaviour.
This MR aligns the feature specs with the actual invalid pipeline behaviour and fixes both failing JavaScript class initialisations.
Screenshots
Pipeline Details Page
| State | Image |
|---|---|
| Before |  |
| After |  |
Error
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines - [-] Merge request performance guidelines
- [-] Style guides
- [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team