Skip to content

Adjust ui dropdown user role

Marc Schwede requested to merge (removed):adjust-ui-dropdown-user_role into master

What does this MR do?

Within this MR i tried to apply commonly used ui elements to a missing element in the user settings.
I utilized select2, which was already used on the other elements of this settings page. Also I noticed, that there seems to be not really consistency over all elements of GitLab. Is there a roadmap I missed or are those two competing aproaches similar to A/B tests 🤔?

Screenshots

before after
Bildschirmfoto_2020-02-13_um_22.55.58 Bildschirmfoto_2020-02-13_um_22.55.31
Bildschirmfoto_2020-02-13_um_22.56.36 Bildschirmfoto_2020-02-13_um_22.55.35

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Marc Schwede

Merge request reports