The source project of this merge request has been removed.
Adjust ui dropdown user role
What does this MR do?
Within this MR i tried to apply commonly used ui elements to a missing element in the user settings.
I utilized select2
, which was already used on the other elements of this settings page. Also I noticed, that there seems to be not really consistency over all elements of GitLab. Is there a roadmap I missed or are those two competing aproaches similar to A/B tests
Screenshots
before | after |
---|---|
![]() |
![]() |
![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Marc Schwede