Skip to content

Fix broken master by updating expected params

Luke Duncalfe requested to merge ld-fix-broken-master-update-service-spec into master

What does this MR do?

This fixes a spec that's failing in master.

The MR that introduced the spec that fails was !24296 (merged) however it's pipeline was passing when it was merged. It was interacting badly with 8d4d9705 which modified the services table to remove the instance column and add a template column (default false).

This caused the factory that was built on https://gitlab.com/gitlab-org/gitlab/-/blob/dde7be6f5cb77b7be8287c2676a015f39152775c/spec/services/projects/operations/update_service_spec.rb#L295 to return an object with different attributes from what the test expected in https://gitlab.com/gitlab-org/gitlab/-/blob/dde7be6f5cb77b7be8287c2676a015f39152775c/spec/services/projects/operations/update_service_spec.rb#L301.

The fix is to update the expected params to match the new schema of services.

I've left a note #205391 (comment 287309492) for the developer of the spec to consider making the spec less brittle to changes to the schema of services.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Luke Duncalfe

Merge request reports