Broken master in spec/services/projects/operations/update_service_spec.rb:335
Job #435488227 failed for 47d1f417:
bundle exec rspec spec/services/projects/operations/update_service_spec.rb:335
Failures:
1) Projects::Operations::UpdateService#execute prometheus integration prometheus params were passed into service uses Project#find_or_initialize_service to include instance defined defaults and pass them to Projects::UpdateService
Got 1 failure and 1 other error:
1.1) Failure/Error:
Projects::UpdateService
.new(project, current_user, project_update_params)
.execute
#<Projects::UpdateService (class)> received :new with unexpected arguments
expected: (#<Project id:1 namespace1/project1>>, #<User id:1 @user1>, {:prometheus_service_attributes=>{"active"=>true, "category"=>"monitoring", "comment_on_event_enabled...true, "tag_push_events"=>true, "title"=>nil, "type"=>"PrometheusService", "wiki_page_events"=>true}})
got: (#<Project id:1 namespace1/project1>>, #<User id:1 @user1>, {:prometheus_service_attributes=>{"active"=>true, "category"=>"monitoring", "comment_on_event_enabled...nts"=>true, "template"=>false, "title"=>nil, "type"=>"PrometheusService", "wiki_page_events"=>true}})
Diff:
@@ -10,7 +10,6 @@
"default"=>false,
"deployment_events"=>false,
"description"=>nil,
- "instance"=>false,
"issues_events"=>true,
"job_events"=>true,
"merge_requests_events"=>true,
@@ -20,6 +19,7 @@
{"api_url"=>"http://new.prometheus.com", "manual_configuration"=>"1"},
"push_events"=>true,
"tag_push_events"=>true,
+ "template"=>false,
"title"=>nil,
"type"=>"PrometheusService",
"wiki_page_events"=>true}}]
# ./app/services/projects/operations/update_service.rb:8:in `execute'
# ./spec/services/projects/operations/update_service_spec.rb:352:in `block (5 levels) in <top (required)>'
# ./spec/spec_helper.rb:236:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:236:in `block (2 levels) in <top (required)>'
1.2) Failure/Error:
Projects::UpdateService
.new(project, current_user, project_update_params)
.execute
NoMethodError:
undefined method `execute' for #<Array:0x00007f89571e5cc0>
# ./app/services/projects/operations/update_service.rb:9:in `execute'
# ./spec/services/projects/operations/update_service_spec.rb:352:in `block (5 levels) in <top (required)>'
# ./spec/spec_helper.rb:236:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:236:in `block (2 levels) in <top (required)>'
Edited by Luke Duncalfe