Backfill GraphQL descriptions (Part 7)
What does this MR do?
Continuation of !19233 (merged), !21164 (merged), !21536 (merged), !21809 (merged), !22073 (merged) and !22199 (merged)
Backfill some more GraphQL fields, and modify some existing ones to adhere to the standards.
Description standards:
-
{x} of the {y}
where possible !19233 (comment 236991402) - Booleans framed in terms of "what does this field do" i.e.
Indicates repository has a Git repository
!19233 (comment 236991402) - Always use
timestamp
when describing aTypes::TimeType
field !19233 (comment 236997153) - No
.
at end of strings - Use single quotes unless interpolation is required, then use double quotes.
Related to #31645 (closed)
Merge request reports
Activity
changed milestone to %12.8
@cablett To continue with your awesome work I have added a few descriptions that were missing, could you take the first backend review, please?
Specs are failing at master: #202678 (closed)
Edited by Eugenia Grieffassigned to @cablett
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Tyler Amos ( @tyleramos
)Ash McKenzie ( @ashmckenzie
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Evan Read
Fantastic work @egrieff ! LGTM!
@eread can you please perform documentation review?
mentioned in issue #31645 (closed)
- Resolved by Evan Read
- Resolved by Evan Read
unassigned @eread
added docsimprovement label
added 144 commits
-
dcdd12ce...be711a8d - 143 commits from branch
master
- e45bf70d - Backfill GraphQL descriptions
-
dcdd12ce...be711a8d - 143 commits from branch
assigned to @eread
mentioned in commit ae492e65
added typemaintenance label