Skip to content

Resolve "Convert Insights to ECharts"

Robert Hunt requested to merge 196184-convert-insights-to-echarts into master

What does this MR do?

This MR moves the existing chart components over to the GitLab UI chart components: GlColumnChart, GlStackedColumnChart and GlLineChart.

We don't have a corresponding pie chart so this has been removed. Any reference to these now will fall back to bar charts instead. There is great discussion about the usefulness of pie charts which shows how other graph types are better suited.

There are two other issues to resolve in future:

  1. Moving the tests from karma to jest
  2. Update the documentation screenshots

Screenshots

image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Test that /%GROUP_NAME%/%PROJECT_NAME%/insights#/issues and /groups/%GROUP_NAME%/-/insights#/issues show the charts correctly. You may need to update the configuration YML file as described in https://docs.gitlab.com/ee/user/project/insights/#writing-your-gitlabinsightsyml

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #196184 (closed), #13006 (closed)

Edited by Robert Hunt

Merge request reports