Stop validating web_hook_logs_daily sharding key constraint (19.2 backport)
What does this MR do and why?
Backport of !244166 (merged) into 19-2-stable-ee.
ValidateWebHookLogsDailyShardingKeyConstraint (19.0) aborts with PG::CheckViolation on self-managed instances doing a fast chained upgrade. Orphan web_hook_logs_daily rows whose sharding keys are all NULL (parent web_hook deleted, or instance/system hooks) violate check_19dc80d658, and the table's 14-day partition rollover has not yet cleared them when the finalize and validate migrations run back to back.
Turn the migration into a no-op so the constraint is left NOT VALID. It is still enforced on new writes; the pre-existing orphan rows are cleaned up and the constraint re-validated in a follow-up migration.
The change is a clean cherry-pick of the squashed master commit; db/structure.sql auto-merged and the sharding-key spec exemptions apply against this branch's spec.
References
- Work item: #603303
- Master MR: !244166 (merged)
- Follow-up re-validation (master): !244171 (closed)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
- This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
- The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
- The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
- Required labels have been applied to this merge request
- severity label and bug subtype labels (if applicable)
- If this MR fixes a bug that affects customers, the customer label has been applied.
- This MR has been approved by a maintainer (only one approval is required).
- Ensure the
e2e:test-on-omnibus-eejob has succeeded, or if it has failed, investigate the failures. If you determine the failures are unrelated, you may proceed. If you need assistance investigating, request help in the #s_developer_experience Slack channel to confirm the failures are unrelated to the merge request.
Note to the merge request author and maintainer
If you have questions about the patch release process, please:
- Refer to the patch release runbook for engineers and maintainers for guidance.
- Ask questions on the
#releasesSlack channel (internal only). - Once the backport has been merged, the commit changes will be automatically deployed to a release environment that can be used for manual validation. See after merging runbook for details.