Stop validating web_hook_logs_daily sharding key constraint

Tomasz Skoruparequested to merge
tskorupa/fix-web-hook-logs-daily-validate-constraint-603303 into master

What does this MR do and why?

Stop validating web_hook_logs_daily sharding key constraint

ValidateWebHookLogsDailyShardingKeyConstraint (19.0) aborts with PG::CheckViolation on self-managed instances doing a fast chained upgrade. Orphan web_hook_logs_daily rows whose sharding keys are all NULL (parent web_hook deleted, or instance/system hooks) violate check_19dc80d658, and the table's 14-day partition rollover has not yet cleared them when the finalize and validate migrations run back to back.

Turn the migration into a no-op so the constraint is left NOT VALID. It is still enforced on new writes; the pre-existing orphan rows are cleaned up and the constraint re-validated in a follow-up migration.

References

Changelog: fixed See #603303

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports