Skip to content

Group Deploy Tokens interface

Etienne Baqué requested to merge 21765-group-token-refactor into master

What does this MR do?

This MR is part of the development of group deploy tokens. This MR does two things:

  • it adds a Deploy Token section in Group > Settings > CI/CD.
  • as it reuses the same interface as for the project-scoped deploy tokens, a lot of refactoring was done in this MR:
    • partials used in the project deploy token views were moved to the app/views/shared and reused for the group deploy token views.
    • concerns and rspec shared examples were created for refactoring purposes.

Screenshots

Screenshot_from_2020-02-11_13-35-53

Screenshot_from_2020-02-11_13-34-29

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Relates to #21765 (closed)

Edited by Etienne Baqué

Merge request reports