Remove project argument from project_job_path

What does this MR do?

This merge requests resolves #37341 (closed) by removing the root cause of the error.

project_job_path() takes both a project and a job argument, even though the job is always permanently linked to a project. This meant that callers could get the project argument wrong, leading to nonsensical or not-found links. Remove the project argument, and always take it from the job, so it will always be correct.

CC @rymai @engwan @fabiopitino from the issue and previous MR.

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry
• Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers