Skip to content

Refactor Geo Node License Flash

Zack Cuddy requested to merge 11729-better-license-alert into master

What does this MR do?

Closes #11729 (closed)

This MR brings the Geo Node Invalid License Alert up to spec with the newest Alert component from Pajamas.

Important Notes

There are 2 types of interactions:

  1. If user goes to any of the default Geo routes (the ones in the Sidebar on the Primary Node), it will show the alert with button AND NOT auto redirect
  2. If the user goes to any of the hidden Geo routes (Hand typed in the URL), it will redirect to 403

Screenshots

Old License Alert: Bad_License__Old_

New License Alerts

Core Starter Mobile
New Look Screen_Shot_2020-01-13_at_4.11.58_PM Starter__New_ Mobile__New_

GIFs

Alert without Auto Redirect (geo/nodes and geo/settings): No_Redirect

403 (All hidden routes): Kapture_2020-01-24_at_14.27.50

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #11729 (closed)

Edited by Rémy Coutable

Merge request reports