Resolve "Delete an environment via UI"
What does this MR do?
Adds a UI to delete an environment https://docs.gitlab.com/ee/api/environments.html#delete-an-environment
If an environment has been stopped, it displays a delete button in both the list and detail views.
Closes #20620 (closed)
Screenshots
List View
If an environment is running, the stop button is available:
If an environment is stopped, the delete button is available:
If the delete button is clicked, a delete modal appears. Clicking delete brings the user back to the environments page.
Detail View
If an environment is running, the stop button is available:
If an environment is stopped, the delete button is available:
If the delete button is clicked, a delete modal appears. Clicking delete brings the user back to the environments page.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #20620 (closed)
Merge request reports
Activity
changed milestone to %12.7
added Category:Release Orchestration Deliverable Dogfooding DogfoodingBuild in GitLab UI polish deploy devopsrelease [DEPRECATED] direction environments frontend internal customer missed-deliverable missed:12.3 missed:12.4 missed:12.5 production request typefeature workflowready for development + 1 deleted label
mentioned in merge request gitlab-com/www-gitlab-com!38036 (merged)
Merged in commits from gitlab-foss!31032 (closed)
assigned to @jakeburden
removed Deliverable label
changed milestone to %12.8
added missed:12.7 label
added 1 commit
- a34cc4e5 - Add missing end statement to can_user_update_environment
added 1 commit
- 70c94843 - Update and fix can_user_update_environment method
added 1 commit
- 02f5dcda - Utilize can_user_update_environment helper method
added 3338 commits
-
02f5dcda...6ae01f77 - 3327 commits from branch
master - 0b490086 - Adds environments delete button and modal
- fcbe9310 - Update locales for delete env via UI
- 2bcb7c0a - Make can_user_update_environment helper method
- 94c7717d - remove check for this.model.can_stop
- 96cb00b3 - Update delete environment modal
- 157eb892 - Remove extra StopComponent import
- 02298527 - Add missing end statement to can_user_update_environment
- 19b9510f - Update and fix can_user_update_environment method
- 1e8dcb88 - Fix can_delete entity
- 956ebb9a - Fix expose :can_delete entity
- be132e35 - Utilize can_user_update_environment helper method
Toggle commit list-
02f5dcda...6ae01f77 - 3327 commits from branch
added 2 commits