Skip to content
Snippets Groups Projects

Users can apply multiple suggestions at once.

Merged Jesse Hall requested to merge jessehall3/gitlab-ee:25486-batch-suggestions into master
2 unresolved threads

What does this MR do?

This MR would fulfill the feature described in #25486 (closed) allowing users to apply multiple merge request suggestions at once.

Screenshots

BATCH_SUCCESS

Closes #25486 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • assigned to @jessehall3 and unassigned @dskim_gitlab

  • Jesse Hall added 1 commit

    added 1 commit

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    Compare with previous version

  • Marcia Ramos
  • Marcia Ramos
  • Marcia Ramos
  • Marcia Ramos
  • Marcia Ramos
  • Marcia Ramos
  • Marcia Ramos
  • Marcia Ramos
  • Marcia Ramos
  • Marcia Ramos
  • Marcia Ramos
  • Marcia Ramos
  • Marcia Ramos
  • Marcia Ramos
  • Marcia Ramos
    • Resolved by Bob Van Landuyt

      Thanks @jessehall3! I've done the 1st pass of the docs review, please assign me for a second pass when ready.

      I also looked at the UI text and suggested changing "appliable" to "applicable". I saw pieces of code using appliable and we don't have to change those, I'm only suggesting to change the text outputted to the user. :wink:

  • I guess we should ping a UXer here for review too? :smile: cc/ @pedroms :wave:

  • mentioned in issue #23718 (closed)

  • Jesse Hall added 1 commit

    added 1 commit

    • 93cc880c - New api endpoint for applying suggestion batches

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    • e305448d - Updates to docs and error messages.

    Compare with previous version

  • assigned to @pedroms

  • Jesse Hall added 1 commit

    added 1 commit

    • 6a400e17 - Updates to docs and error messages.

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    • 79936d31 - Was not hiding loading spinner after failing to apply batch.

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    • fa374c6a - Was not hiding loading spinner after failing to apply batch.

    Compare with previous version

  • Jesse Hall added 2 commits

    added 2 commits

    • 8bd77048 - Was not hiding loading spinner after failing to apply batch.
    • 3ec98584 - Updates to docs and default commit message.

    Compare with previous version

  • Jesse Hall added 1577 commits

    added 1577 commits

    • 3ec98584...e8fb1e9f - 1557 commits from branch gitlab-org:master
    • 74b627f7 - Can apply suggestions in batches.
    • 8f4a57ca - Updates to tests in apply_service_spec
    • 8dfdab9c - Changes to variable names.
    • fabf4077 - can add and remove suggestions from a batch
    • 1a3f494f - Can apply multiple suggestions through the front end.
    • 47473714 - Can get loading spinner when applying batch suggestions.
    • a3369a50 - Now clearing batch after applying suggestion batch.
    • dece0415 - Refactoring methods
    • ee386841 - added capybara tests
    • 19df72b7 - updated temporary variable names
    • 307e0c6b - added a couple of tests for the new actions. still need to the the submit batch action.
    • 47ac193b - Passiing first test for submitSuggestionBatch action.
    • 1bf41cc3 - Updated logic in submitSuggestionsBatch action. updated note actions test.
    • b5aaa14b - Updates to tests.
    • ef062a3a - Updates to vue components and tests.
    • 46216f57 - code review revisions
    • 96264527 - New api endpoint for applying suggestion batches
    • 042fd602 - Updates to docs and error messages.
    • 72b4c464 - Was not hiding loading spinner after failing to apply batch.
    • 5bc67826 - Updates to docs and default commit message.

    Compare with previous version

  • Jesse Hall added 91 commits

    added 91 commits

    • 5bc67826...b340fa7b - 71 commits from branch gitlab-org:master
    • 9e05a129 - Can apply suggestions in batches.
    • 438601f2 - Updates to tests in apply_service_spec
    • 7eb713c3 - Changes to variable names.
    • 2e9f7656 - can add and remove suggestions from a batch
    • 21eca884 - Can apply multiple suggestions through the front end.
    • 779d82a9 - Can get loading spinner when applying batch suggestions.
    • 7a1e8573 - Now clearing batch after applying suggestion batch.
    • 1dc9a3f0 - Refactoring methods
    • eca7deed - added capybara tests
    • 02403341 - updated temporary variable names
    • 92d11b7f - added a couple of tests for the new actions. still need to the the submit batch action.
    • bc1bf915 - Passiing first test for submitSuggestionBatch action.
    • 8fa86433 - Updated logic in submitSuggestionsBatch action. updated note actions test.
    • 68d6ff27 - Updates to tests.
    • 3cef32fb - Updates to vue components and tests.
    • b74caad0 - code review revisions
    • 0d8242a3 - New api endpoint for applying suggestion batches
    • 2f3a56c9 - Updates to docs and error messages.
    • a8f2d044 - Was not hiding loading spinner after failing to apply batch.
    • c98b023b - Updates to docs and default commit message.

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    • 07fc1bf4 - Refactoring apply_service.rb

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    • 06367f2c - Refactoring apply_service.rb

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    • 1cbc7398 - Refactoring apply_service.rb

    Compare with previous version

  • Jesse Hall added 317 commits

    added 317 commits

    • 1cbc7398...09233b18 - 296 commits from branch gitlab-org:master
    • 55ce6c89 - Can apply suggestions in batches.
    • 18d18a0f - Updates to tests in apply_service_spec
    • 808913cd - Changes to variable names.
    • bd52be24 - can add and remove suggestions from a batch
    • 3f14312b - Can apply multiple suggestions through the front end.
    • 3ff8b7eb - Can get loading spinner when applying batch suggestions.
    • 7ceb7394 - Now clearing batch after applying suggestion batch.
    • 926ed029 - Refactoring methods
    • 67a9d254 - added capybara tests
    • 8b1695ab - updated temporary variable names
    • 7b32e9a8 - added a couple of tests for the new actions. still need to the the submit batch action.
    • a043c408 - Passiing first test for submitSuggestionBatch action.
    • 60068ee8 - Updated logic in submitSuggestionsBatch action. updated note actions test.
    • 0755c7e2 - Updates to tests.
    • 6ca4df8f - Updates to vue components and tests.
    • 10cf1746 - code review revisions
    • dc7244b3 - New api endpoint for applying suggestion batches
    • f1032b77 - Updates to docs and error messages.
    • 896eb60e - Was not hiding loading spinner after failing to apply batch.
    • d1cfba8b - Updates to docs and default commit message.
    • 7fdab647 - Refactoring apply_service.rb

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    • 9d1ace0b - Refactoring apply_service_spec.rb

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    Compare with previous version

  • Jesse Hall added 646 commits

    added 646 commits

    • 7d4f5c83...ed3f5ff1 - 623 commits from branch gitlab-org:master
    • 1c4d3a49 - Can apply suggestions in batches.
    • d5222279 - Updates to tests in apply_service_spec
    • 12a777c0 - Changes to variable names.
    • e3f06933 - can add and remove suggestions from a batch
    • 00c9b827 - Can apply multiple suggestions through the front end.
    • dca393f8 - Can get loading spinner when applying batch suggestions.
    • f00f5019 - Now clearing batch after applying suggestion batch.
    • 6290bb1d - Refactoring methods
    • c3d52529 - added capybara tests
    • cff5c844 - updated temporary variable names
    • 865dd393 - added a couple of tests for the new actions. still need to the the submit batch action.
    • 3d16ed70 - Passiing first test for submitSuggestionBatch action.
    • fa656621 - Updated logic in submitSuggestionsBatch action. updated note actions test.
    • 078003e4 - Updates to tests.
    • 2e851b30 - Updates to vue components and tests.
    • 42879cf6 - code review revisions
    • 2ba14872 - New api endpoint for applying suggestion batches
    • 238eebc4 - Updates to docs and error messages.
    • a0ac02a3 - Was not hiding loading spinner after failing to apply batch.
    • f64143ad - Updates to docs and default commit message.
    • 875166f5 - Refactoring apply_service.rb
    • 18f3fccd - Additional refactoring
    • d36fbe78 - Updates after latest review

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    Compare with previous version

  • Jesse Hall added 46 commits

    added 46 commits

    • 7140a26d...cf7dca2b - 23 commits from branch gitlab-org:master
    • 2fee6686 - Can apply suggestions in batches.
    • 281edc0f - Updates to tests in apply_service_spec
    • 12122c85 - Changes to variable names.
    • fb0af654 - can add and remove suggestions from a batch
    • af875494 - Can apply multiple suggestions through the front end.
    • c010afcd - Can get loading spinner when applying batch suggestions.
    • 77b03564 - Now clearing batch after applying suggestion batch.
    • 2f10c4bf - Refactoring methods
    • c395b5c0 - added capybara tests
    • e486c435 - updated temporary variable names
    • 3e51fb0a - added a couple of tests for the new actions. still need to the the submit batch action.
    • c5cd0ebe - Passiing first test for submitSuggestionBatch action.
    • 6a119591 - Updated logic in submitSuggestionsBatch action. updated note actions test.
    • 428c3a29 - Updates to tests.
    • f80e1876 - Updates to vue components and tests.
    • 42aafadf - code review revisions
    • c068125e - New api endpoint for applying suggestion batches
    • 3f6c91f1 - Updates to docs and error messages.
    • 0aadf37c - Was not hiding loading spinner after failing to apply batch.
    • b13b016e - Updates to docs and default commit message.
    • aad66a9c - Refactoring apply_service.rb
    • 452a60aa - Additional refactoring
    • e279158b - Updates after latest review

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    • e8db9b83 - Changes following additional review

    Compare with previous version

  • Jesse Hall changed the description

    changed the description

  • Jesse Hall added 1 commit

    added 1 commit

    • 4709d4c1 - Missing green text within badge pill.

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    • c0eac272 - Missing green text within badge pill.

    Compare with previous version

  • Jesse Hall added 481 commits

    added 481 commits

    • c0eac272...9fc8ba36 - 455 commits from branch gitlab-org:master
    • f9a0b332 - Can apply suggestions in batches.
    • 6ab60eb5 - Updates to tests in apply_service_spec
    • a4622956 - Changes to variable names.
    • b0727aeb - can add and remove suggestions from a batch
    • 1f3f4d73 - Can apply multiple suggestions through the front end.
    • 1b78e5f1 - Can get loading spinner when applying batch suggestions.
    • 9ae6352f - Now clearing batch after applying suggestion batch.
    • 6e7abe76 - Refactoring methods
    • 77a30ba6 - added capybara tests
    • 8d4cb4e8 - updated temporary variable names
    • b77dfd45 - added a couple of tests for the new actions. still need to the the submit batch action.
    • f5d85f93 - Passiing first test for submitSuggestionBatch action.
    • c36c4466 - Updated logic in submitSuggestionsBatch action. updated note actions test.
    • 31457e0c - Updates to tests.
    • 7148174f - Updates to vue components and tests.
    • 615185b2 - code review revisions
    • 0faafbbf - New api endpoint for applying suggestion batches
    • eebf0106 - Updates to docs and error messages.
    • 7005f563 - Was not hiding loading spinner after failing to apply batch.
    • fd9e8214 - Updates to docs and default commit message.
    • 721cd74a - Refactoring apply_service.rb
    • ce349a39 - Additional refactoring
    • 859361fb - Updates after latest review
    • e7f7c35b - Changes following additional review
    • 59766a4f - Missing green text within badge pill.
    • 1e96a6fc - Added check for empty batches in api/suggestions.rb

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    • 632ca897 - Added check for empty batches in api/suggestions.rb

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    • 6816559c - Added check for empty batches in api/suggestions.rb

    Compare with previous version

  • Sincheol (David) Kim approved this merge request

    approved this merge request

    • Resolved by Bob Van Landuyt

      Cool feature @jessehall3! I've left a bigger suggestion on how we could make the service class a bit thinner, let me know what you think.

      I think the API isn't going to change much anymore, that looks pretty good, so I'd be fine starting the forntend review at the same time @andr3, who could help with that?

  • Jesse Hall changed the description

    changed the description

  • Jesse Hall added 1 commit

    added 1 commit

    • 619873bd - Fix for weird transition visuals between "applying" and "applied" states.

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    • e514cec3 - Fix for weird transition visuals between "applying" and "applied" states.

    Compare with previous version

  • Pedro Moreira da Silva approved this merge request

    approved this merge request

  • @jboyson do you have capacity to review the FE here?

  • Jesse Hall added 1 commit

    added 1 commit

    • 60099054 - Split apply_service responsibilities into different classes.

    Compare with previous version

  • Jesse Hall added 1042 commits

    added 1042 commits

    • 60099054...6a4ed940 - 1014 commits from branch gitlab-org:master
    • 350b6b4d - Can apply suggestions in batches.
    • 27feed12 - Updates to tests in apply_service_spec
    • ab70ce8e - Changes to variable names.
    • 97f65598 - can add and remove suggestions from a batch
    • ddeda9f2 - Can apply multiple suggestions through the front end.
    • bee432fc - Can get loading spinner when applying batch suggestions.
    • 5c05804b - Now clearing batch after applying suggestion batch.
    • 99439a46 - Refactoring methods
    • e405f9d3 - added capybara tests
    • dfa70529 - updated temporary variable names
    • 98763ccd - added a couple of tests for the new actions. still need to the the submit batch action.
    • 14631cbe - Passiing first test for submitSuggestionBatch action.
    • df5d4530 - Updated logic in submitSuggestionsBatch action. updated note actions test.
    • 90d2b0c4 - Updates to tests.
    • 0d257836 - Updates to vue components and tests.
    • 8491c0a4 - code review revisions
    • 49570ad5 - New api endpoint for applying suggestion batches
    • 3aaa5c3c - Updates to docs and error messages.
    • a06ab248 - Was not hiding loading spinner after failing to apply batch.
    • ffc7ab81 - Updates to docs and default commit message.
    • 55af708d - Refactoring apply_service.rb
    • 18bcb614 - Additional refactoring
    • f915231c - Updates after latest review
    • 87bcbdec - Changes following additional review
    • 05e1f711 - Missing green text within badge pill.
    • 546610b1 - Added check for empty batches in api/suggestions.rb
    • e97f2086 - Fix for weird transition visuals between "applying" and "applied" states.
    • 1cf924d5 - Split apply_service responsibilities into different classes.

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    • f1f61188 - Split apply_service responsibilities into different classes.

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    • d4bdbd07 - Split apply_service responsibilities into different classes.

    Compare with previous version

    • Author Contributor
      Resolved by Justin Boyson

      @jboyson

      For frontend review considerations:

      There is an issue I've found in both the current master branch and this fork that I would like to highlight. The behavior can be seen in the video clips below:

      Master Branch master_apply_button_jumps

      This Fork fork_apply_batch_button_jumps

      After clicking either of the apply buttons and presenting the spinner, sometimes the spinner will jump back to showing an apply button before showing the final, green, "Applied" button.

      I don't see this behavior all the time, which made capturing it on video difficult. Likewise, I have not see this on Gitlab.com, though I don't see why it should behave differently given that this behavior should rest solely on the logic on the frontend code.

      I've tried different combinations of changes to the vue template, combined with tweaks to the vuex action that controls this, but I was unable to find a solution. Given the current logic in the template, I don't believe this behavior should be possible.

      All that said, I wanted to be sure to state this here so that it can be understood as known behavior. Because I see it happen currently on the master branch, I would not consider it a blocker. However, I would understand if a reviewer feels that it requires further investigation before moving forward.

  • Jesse Hall added 1 commit

    added 1 commit

    • 0683c7fd - Resotres last commit id parameter for multi-service actions.

    Compare with previous version

    • Resolved by Bob Van Landuyt

      @jessehall3 Awesome work! I've left some comments, and a suggestion to get around the N+1. If that doesn't work we'll have to either implement a new RPC to get the last commit for multiple paths, or limit the number of different files we can apply suggestions to at one.

  • Jesse Hall added 1 commit

    added 1 commit

    Compare with previous version

  • Jesse Hall added 660 commits

    added 660 commits

    • 852ba3e3...5f46d0b1 - 630 commits from branch gitlab-org:master
    • 25cd8364 - Can apply suggestions in batches.
    • 410b83ae - Updates to tests in apply_service_spec
    • 397fa35f - Changes to variable names.
    • 3b90c245 - can add and remove suggestions from a batch
    • 2e26cdf7 - Can apply multiple suggestions through the front end.
    • aab4ea49 - Can get loading spinner when applying batch suggestions.
    • 33a8c828 - Now clearing batch after applying suggestion batch.
    • 23e989b2 - Refactoring methods
    • d4db6d68 - added capybara tests
    • e207aef5 - updated temporary variable names
    • bd84efbd - added a couple of tests for the new actions. still need to the the submit batch action.
    • 03ec12d7 - Passiing first test for submitSuggestionBatch action.
    • ff3154bd - Updated logic in submitSuggestionsBatch action. updated note actions test.
    • 56b3e352 - Updates to tests.
    • 5ebbfecd - Updates to vue components and tests.
    • f0c4ceb9 - code review revisions
    • e2995a3a - New api endpoint for applying suggestion batches
    • 52d73508 - Updates to docs and error messages.
    • 42109af0 - Was not hiding loading spinner after failing to apply batch.
    • 3a682eff - Updates to docs and default commit message.
    • 71810828 - Refactoring apply_service.rb
    • fd5e5e91 - Additional refactoring
    • 68aa4430 - Updates after latest review
    • fad02ee2 - Changes following additional review
    • 591b100c - Missing green text within badge pill.
    • 54def701 - Added check for empty batches in api/suggestions.rb
    • b5298f2c - Fix for weird transition visuals between "applying" and "applied" states.
    • cfc40a43 - Split apply_service responsibilities into different classes.
    • bd922488 - Resotres last commit id parameter for multi-service actions.
    • 2ef56a0c - code review changes

    Compare with previous version

  • Contributor

    @jessehall3 is this ready for another review? Wasn't 100% sure if you applied all suggestions :point_up:

  • Author Contributor

    @rpaik

    Thanks for checking up on this but, no, this is not ready for another review. I will ping @reprazent when it is ready.

  • Jesse Hall added 1 commit

    added 1 commit

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    Compare with previous version

  • Jesse Hall added 1247 commits

    added 1247 commits

    • 955f9deb...b6b8ee4e - 1216 commits from branch gitlab-org:master
    • 9b99fd7c - Can apply suggestions in batches.
    • 77e22db7 - Updates to tests in apply_service_spec
    • 18748593 - Changes to variable names.
    • b2679813 - can add and remove suggestions from a batch
    • 74fb70f2 - Can apply multiple suggestions through the front end.
    • 01b1b339 - Can get loading spinner when applying batch suggestions.
    • f1d92061 - Now clearing batch after applying suggestion batch.
    • dd368eb7 - Refactoring methods
    • d41b24eb - added capybara tests
    • 14354ce0 - updated temporary variable names
    • 85cf880e - added a couple of tests for the new actions. still need to the the submit batch action.
    • 0ef2e7ca - Passiing first test for submitSuggestionBatch action.
    • 9ba6b512 - Updated logic in submitSuggestionsBatch action. updated note actions test.
    • ce191f1e - Updates to tests.
    • 14a35b1b - Updates to vue components and tests.
    • 74e698b5 - code review revisions
    • 01efbd51 - New api endpoint for applying suggestion batches
    • 250acc47 - Updates to docs and error messages.
    • 290c74a2 - Was not hiding loading spinner after failing to apply batch.
    • 2e3241da - Updates to docs and default commit message.
    • 641b6f31 - Refactoring apply_service.rb
    • f9818ac2 - Additional refactoring
    • 15d6dd5c - Updates after latest review
    • d4124696 - Changes following additional review
    • 18131052 - Missing green text within badge pill.
    • c2913127 - Added check for empty batches in api/suggestions.rb
    • d0266829 - Fix for weird transition visuals between "applying" and "applied" states.
    • 9a05e8b2 - Split apply_service responsibilities into different classes.
    • 6eb603a0 - Resotres last commit id parameter for multi-service actions.
    • ffc7c133 - code review changes
    • 1fee11b8 - Code Review Changes

    Compare with previous version

  • Jesse Hall added 122 commits

    added 122 commits

    • 1fee11b8...7596dd3d - 91 commits from branch gitlab-org:master
    • e78ee748 - Can apply suggestions in batches.
    • fd270f71 - Updates to tests in apply_service_spec
    • 6d3137a2 - Changes to variable names.
    • 9321c381 - can add and remove suggestions from a batch
    • b4012444 - Can apply multiple suggestions through the front end.
    • abc93ccb - Can get loading spinner when applying batch suggestions.
    • 40836728 - Now clearing batch after applying suggestion batch.
    • ce1a1bf7 - Refactoring methods
    • 5381567e - added capybara tests
    • 7fcd4c25 - updated temporary variable names
    • 568ed712 - added a couple of tests for the new actions. still need to the the submit batch action.
    • f0203b12 - Passiing first test for submitSuggestionBatch action.
    • 2cf53ed3 - Updated logic in submitSuggestionsBatch action. updated note actions test.
    • af5e6afa - Updates to tests.
    • 382911bc - Updates to vue components and tests.
    • b00c3b96 - code review revisions
    • 5b60d49d - New api endpoint for applying suggestion batches
    • ae389c93 - Updates to docs and error messages.
    • eeced0c9 - Was not hiding loading spinner after failing to apply batch.
    • e0453e72 - Updates to docs and default commit message.
    • c4efce82 - Refactoring apply_service.rb
    • 1944b2e1 - Additional refactoring
    • df09cdc3 - Updates after latest review
    • ad277d34 - Changes following additional review
    • a7f96848 - Missing green text within badge pill.
    • 6747b353 - Added check for empty batches in api/suggestions.rb
    • 85fa2d3f - Fix for weird transition visuals between "applying" and "applied" states.
    • 01250873 - Split apply_service responsibilities into different classes.
    • dc086b92 - Resotres last commit id parameter for multi-service actions.
    • 714807c9 - code review changes
    • 05e65ec4 - Code Review Changes

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    Compare with previous version

  • Jesse Hall added 849 commits

    added 849 commits

    • 1aba3714...781363dc - 818 commits from branch gitlab-org:master
    • c80b9002 - Can apply suggestions in batches.
    • 1d040f7d - Updates to tests in apply_service_spec
    • cf1a9780 - Changes to variable names.
    • 28f9154f - can add and remove suggestions from a batch
    • f867fb1d - Can apply multiple suggestions through the front end.
    • fb6cb33d - Can get loading spinner when applying batch suggestions.
    • d07d53f4 - Now clearing batch after applying suggestion batch.
    • fdfb4d18 - Refactoring methods
    • f0844aea - added capybara tests
    • 7deadaf1 - updated temporary variable names
    • 6c908e5d - added a couple of tests for the new actions. still need to the the submit batch action.
    • fc10eb43 - Passiing first test for submitSuggestionBatch action.
    • e7affdaf - Updated logic in submitSuggestionsBatch action. updated note actions test.
    • ccf07be1 - Updates to tests.
    • d0518272 - Updates to vue components and tests.
    • aec661d4 - code review revisions
    • 96dbe5a3 - New api endpoint for applying suggestion batches
    • e9a8181a - Updates to docs and error messages.
    • b9f9c39d - Was not hiding loading spinner after failing to apply batch.
    • 19ada038 - Updates to docs and default commit message.
    • e82a48f1 - Refactoring apply_service.rb
    • 918c1de6 - Additional refactoring
    • 8d9a7998 - Updates after latest review
    • 25df175d - Missing green text within badge pill.
    • 6291f066 - Added check for empty batches in api/suggestions.rb
    • d816b543 - Fix for weird transition visuals between "applying" and "applied" states.
    • 58d515dd - Split apply_service responsibilities into different classes.
    • e45c6ced - Resotres last commit id parameter for multi-service actions.
    • 27df8c0c - code review changes
    • d7358dfc - Code Review Changes
    • cd7b9bab - Code review changes.

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    • 6261bcb1 - No longer using 'last_commit_id'.

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    • 327dbe31 - No longer using 'last_commit_id'.

    Compare with previous version

  • assigned to @jboyson

  • Jesse Hall added 1 commit

    added 1 commit

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    Compare with previous version

  • Jesse Hall added 1085 commits

    added 1085 commits

    Compare with previous version

  • Jesse Hall added 17 commits

    added 17 commits

    Compare with previous version

  • Justin Boyson
  • Jesse Hall added 882 commits

    added 882 commits

    Compare with previous version

  • Justin Boyson approved this merge request

    approved this merge request

  • Justin Boyson assigned to @markrian and unassigned @jboyson

    assigned to @markrian and unassigned @jboyson

  • Jesse Hall added 1473 commits

    added 1473 commits

    Compare with previous version

  • Mark Florian
  • Mark Florian
  • Mark Florian
  • Mark Florian
  • Mark Florian
  • Mark Florian
  • Mark Florian
  • Mark Florian
  • Mark Florian
  • Mark Florian
  • Mark Florian
  • Mark Florian
  • Mark Florian
  • Mark Florian
  • @jessehall3 This is looking great on the whole after my first review pass! I've left various comments and suggestions, so for now it's back to you :ping_pong:

    Aside: I've left various comments using the Conventional Comments style. If you have any feedback on whether this was useful to you, that'd be great!

    @pedroms I've left a couple UX questions for you as well :slight_smile:

  • Mark Florian assigned to @pedroms and unassigned @markrian

    assigned to @pedroms and unassigned @markrian

  • Author Contributor

    This is great, thanks again. I'll be going over these.

  • Jesse Hall added 1 commit

    added 1 commit

    Compare with previous version

  • Author Contributor

    @markrian
    First, I do appreciate the Conventional Comments style used here, particularly the emphasis on what is, and what is not, blocking. I'm going to be trying this style myself.

    That said, I responded to all your comments. Please let me your thoughts, thank you.

  • Mark Florian mentioned in issue #216489

    mentioned in issue #216489

  • Mark Florian
  • Jesse Hall added 798 commits

    added 798 commits

    Compare with previous version

  • Pedro Moreira da Silva unapproved this merge request

    unapproved this merge request

  • Jesse Hall added 886 commits

    added 886 commits

    Compare with previous version

  • assigned to @markrian and @pedroms

  • mentioned in epic &3280 (closed)

  • Thanks @jessehall3! I've left just one more comment; otherwise, I think the frontend is looking good!

    I want to give this another pass later this week. If I find nothing else, I'll approve.

    In any case, I think it's time to bring @marcia back in to help complete the missing documentation. After that, @reprazent said he'd like to take another look just before merging.

    Finally, I don't think this will make %13.0, and I don't think we should rush to try to fit it in, so the documentation/images will need to be updated/renamed to reflect that.

    Nearly there!

  • assigned to @marcia

  • Author Contributor

    @markrian Thanks for these updates and all your help. I'll look at this latest comment and wait to hear more later on. No problem with the docs/images, I will update them to match 13.1. Take care.

  • Daniel Gruesso changed milestone to %13.1

    changed milestone to %13.1

  • Jesse Hall added 812 commits

    added 812 commits

    Compare with previous version

  • Mark Florian
  • Mark Florian approved this merge request

    approved this merge request

  • Thanks @jessehall3!

    I've done another pass, and have added one more suggestion. Once you address that, I'll be happy to approve the frontend portion of this MR! In fact, I'll pre-emptively do so, since the suggestion is so trivial.

    Fantastic work, and I can't wait to see this released!

  • Jesse Hall added 1 commit

    added 1 commit

    Compare with previous version

  • Jesse Hall added 138 commits

    added 138 commits

    Compare with previous version

  • Pedro Moreira da Silva approved this merge request

    approved this merge request

  • Jesse Hall added 570 commits

    added 570 commits

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    Compare with previous version

  • Jesse Hall added 2 commits

    added 2 commits

    • 966c1df6 - Now pluralizing applying suggestions message.
    • 5a1d47b2 - Now reseting applying batch state after applying single suggestion or batch.

    Compare with previous version

  • Jesse Hall added 16 commits

    added 16 commits

    • 5a1d47b2...b969416f - 13 commits from branch gitlab-org:master
    • 519e5f72 - Feature for #25486 (closed), users can apply multiple suggestions at once.
    • 2651d989 - Now pluralizing applying suggestions message.
    • d41f4d5e - Now reseting applying batch state after applying single suggestion or batch.

    Compare with previous version

  • Jesse Hall added 9 commits

    added 9 commits

    • d41f4d5e...f9ac8102 - 6 commits from branch gitlab-org:master
    • 04a5b9b5 - Feature for #25486 (closed), users can apply multiple suggestions at once.
    • aa582d5d - Now pluralizing applying suggestions message.
    • d8a9947f - Now reseting applying batch state after applying single suggestion or batch.

    Compare with previous version

  • Jesse Hall
    • Author Contributor
      Resolved by Daniel Gruesso

      @markrian I was wondering if you could have a look at the last two commits. In the first one, as @pedroms pointed out, I was missing pluralization in one spot. In making this change, it seemed like a good idea to update one of the actions, that is the second commit. I put details in my latest comment.

  • Jesse Hall added 935 commits

    added 935 commits

    • d8a9947f...a91f7e32 - 932 commits from branch gitlab-org:master
    • 95ecb020 - Feature for #25486 (closed), users can apply multiple suggestions at once.
    • 6d01fa08 - Now pluralizing applying suggestions message.
    • e5cbb9b8 - Now reseting applying batch state after applying single suggestion or batch.

    Compare with previous version

  • assigned to @marcia

  • Marcia Ramos
  • Marcia Ramos
  • Marcia Ramos
  • Marcia Ramos
  • Marcia Ramos
  • Marcia Ramos
  • Marcia Ramos
  • Marcia Ramos
  • unassigned @marcia

  • Jesse Hall added 1232 commits

    added 1232 commits

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    Compare with previous version

  • mentioned in issue #30707 (closed)

  • assigned to @marcia

  • Marcia Ramos
  • unassigned @marcia

  • Daniel Gruesso added 1 commit

    added 1 commit

    • cd152239 - Apply suggestion to doc/user/discussions/index.md

    Compare with previous version

  • Daniel Gruesso resolved all threads

    resolved all threads

  • Marcia Ramos approved this merge request

    approved this merge request

  • Jesse Hall added 1035 commits

    added 1035 commits

    • cd152239...89b3e1dc - 1030 commits from branch gitlab-org:master
    • 445649ed - Feature for #25486 (closed), users can apply multiple suggestions at once.
    • c3cfe5fe - Now pluralizing applying suggestions message.
    • 38d3c91a - Now reseting applying batch state after applying single suggestion or batch.
    • 676e6e06 - doc updates
    • 38a85ef6 - Apply suggestion to doc/user/discussions/index.md

    Compare with previous version

  • Jesse Hall added 10 commits

    added 10 commits

    • 38a85ef6...92d173c7 - 5 commits from branch gitlab-org:master
    • ca7ce2e1 - Feature for #25486 (closed), users can apply multiple suggestions at once.
    • a1af19f4 - Now pluralizing applying suggestions message.
    • 0be22a60 - Now reseting applying batch state after applying single suggestion or batch.
    • 40f98041 - doc updates
    • 97dd3eb5 - Apply suggestion to doc/user/discussions/index.md

    Compare with previous version

  • Jesse Hall added 15 commits

    added 15 commits

    • 97dd3eb5...0813a73d - 10 commits from branch gitlab-org:master
    • 92890707 - Feature for #25486 (closed), users can apply multiple suggestions at once.
    • fff9df16 - Now pluralizing applying suggestions message.
    • 4f0d570d - Now reseting applying batch state after applying single suggestion or batch.
    • 782e5afb - doc updates
    • 402ed928 - Apply suggestion to doc/user/discussions/index.md

    Compare with previous version

  • Jesse Hall unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Jesse Hall added 1 commit

    added 1 commit

    Compare with previous version

  • Jesse Hall added 1 commit

    added 1 commit

    Compare with previous version

  • Bob Van Landuyt approved this merge request

    approved this merge request

  • Bob Van Landuyt resolved all threads

    resolved all threads

  • Bob Van Landuyt enabled an automatic merge when the pipeline for cac9ad10 succeeds

    enabled an automatic merge when the pipeline for cac9ad10 succeeds

  • Gave this another run, works like a charm! Thanks @jessehall3! I've triggered a new pipeline and cancelled the stuck one, I hope that does it :smile:.

  • Bob Van Landuyt mentioned in commit a7fe3895

    mentioned in commit a7fe3895

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Samantha Ming mentioned in merge request !33357 (merged)

    mentioned in merge request !33357 (merged)

  • Wow, this feature is AMAZINGGGGGGGGGGGG. Thank you so much for implementing this @jessehall3

  • André Luís mentioned in issue #221222

    mentioned in issue #221222

  • WOW! This is great work!! Thanks @jessehall3 :smiley:

  • Great work @jessehall3 - this will improve my day-to-day workflow significantly :)

  • Paul Slaughter mentioned in merge request !34782 (merged)

    mentioned in merge request !34782 (merged)

  • mentioned in issue #262637 (closed)

  • mentioned in issue #276943 (closed)

  • 🤖 GitLab Bot 🤖 changed the description

    changed the description

  • Please register or sign in to reply
    Loading