Skip to content

Remove spinner when approval require input is changed

Samantha Ming requested to merge 38090-remove-spinner-on-approval-change into master

Issue: #38090 (closed)

What does this MR do?

When "No.approvals required" is changed, there is a spinner that appears below it. This MR removes that for a better experience with no odd spinner hops.

Testing Case

  1. Navigate to General project settings
  2. Expand the Merge request approvals section
  3. Increase/decrease the no. of required approvals for any approval rule.
  4. No spinner should appear

_

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #38090 (closed)

Merge request reports