Webhooks form when editting should have the option to close
What does this MR do and why?
Fixes a problem observed where the form for updating an existing webhook doesn't close after the user saves changes AND doesn't offer a clear way to close the form.
A past MR !105703 (merged) shows that it was intentional to have the form not redirect on save (unlike when adding a new webhook).
In the absence of new info on whether we should now redirect on save, this MR just adds a close button to the action bar (instead of making the form close automatically) in:
- project hooks update page
- group hooks update page
- admin hooks update page
Also adds tests.
References
Screenshots or screen recordings
| Before | After |
|---|---|
| Screen Recording 2025-12-02 at 3.36.07 PM.mov | Screen Recording 2025-12-02 at 2.55.08 PM.mov |
How to set up and validate locally
- Navigate to a [group or project or admin] settings -> Web hooks (or System hooks)
- Add a new new webhook (if you already have one, skip to step 3)
- Open an existing hook and make a change (check or uncheck something)
- Click save. Then click close.
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #579392 (closed)
Edited by Oiza Baiye