Remove deprecated Approver and ApproverGroup models

zlirequested to merge
zl/566494 into master

What does this MR do and why?

In this MR, after we have removed all reference and usage to both models in application codebase, we mainly focus on,

  • Dropping deprecated Approver and ApproverGroup models,
  • Removing associations from Project and MergeRequest to both models

Along with this purpose, we also make some below changes.

  • Remove corresponding test factories
  • Update unit testings. Some direct related; some just legacy and removed
  • Update rubocop todo for deleted file reference
  • One doc example updated

References

Issue - Remove Approver and ApproverGroup models (#566494)

Screenshots or screen recordings

Created one MR locally, and requested two approvals, and verified some basic functionalities.

Everything looks as expected.

Screenshot_2025-10-31_at_3.42.17_pm

Screenshot_2025-10-31_at_4.09.23_pm

The auto-merging does not work, and I think it is because I do not have some workers setup yet. Merge immediately seems to be working fine as expected.

Screenshot_2025-10-31_at_4.18.03_pm

How to set up and validate locally

Not sure there would be bullet points for verifying.

The main area being impacted would be approvers and approval rules. We should try to create a MR and assign some approval rules, and see how it behaves.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by zli

Merge request reports