Skip to content

Fix change to default colors in job log

Fabio Pitino requested to merge fix-job-log-default-colors into master

What does this MR do?

In #36335 (comment 250471967) a customer reported that color changes in their job log was incorrect. It turned out that we missed changing ANSI colors to default values when [39m code is encountered for the foreground and [49m code is encountered for the background.

Expected behavior is:

  1. if job log contains [39m reset the foreground color from any values that was set before
  2. if job log contains [49m reset the background color from any values that was set before

Related issue: #36335 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kamil Trzciński

Merge request reports