Fix change to default colors in job log
What does this MR do?
In #36335 (comment 250471967) a customer reported that color changes in their job log was incorrect. It turned out that we missed changing ANSI colors to default values when [39m
code is encountered for the foreground and [49m
code is encountered for the background.
Expected behavior is:
- if job log contains
[39m
reset the foreground color from any values that was set before - if job log contains
[49m
reset the background color from any values that was set before
Related issue: #36335 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Kamil Trzciński