Skip to content

GH-472081 | fix approve / blocked / pending users workers sidekiq offenses

What does this MR do and why?

Per the cop, we want to avoid .find throwing a hard error and retrying because there is a likely chance the record has been deleted from the database. Although, for the job worked on in this MR - approve_blocked_pending_approval_users_worker.rb - it would be unexpected to lose the user before this job triggered, it still felt like a good opportunity to implement changes to adhere to the standard.

References

#472081

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading