Skip to content

Fix silenced Sidekiq/NoFindInWorkers offenses

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Goal

Fix all silenced offenses of the Sidekiq/NoFindInWorkers cop added in Add cop to avoid find in Sidekiq workers (!159112 - merged)

Implementation plan

  • Replace .find in worker with find_by_id or find_by(id: ID) and return early if the record is not found
  • You may add a log with a warning

Offenses

⚠️ After fixing the offense please don't forget to remove this file from the Sidekiq/NoFindInWorkers configuration in .rubocop_todo/gitlab/no_find_in_workers.yml in this same MR.

  • 'app/workers/approve_blocked_pending_approval_users_worker.rb'
  • 'app/workers/auto_devops/disable_worker.rb'
  • 'app/workers/bulk_imports/entity_worker.rb'
  • 'app/workers/bulk_imports/export_request_worker.rb'
  • 'app/workers/bulk_imports/finish_batched_pipeline_worker.rb'
  • 'app/workers/bulk_imports/pipeline_batch_worker.rb'
  • 'app/workers/bulk_imports/pipeline_worker.rb'
  • 'app/workers/bulk_imports/relation_batch_export_worker.rb'
  • 'app/workers/bulk_imports/relation_export_worker.rb'
  • 'app/workers/bulk_imports/user_contributions_export_worker.rb'
  • 'app/workers/concerns/cluster_applications.rb'
  • 'app/workers/concerns/project_import_options.rb'
  • 'app/workers/create_pipeline_worker.rb'
  • 'app/workers/delete_diff_files_worker.rb'
  • 'app/workers/delete_merged_branches_worker.rb'
  • 'app/workers/design_management/copy_design_collection_worker.rb'
  • 'app/workers/design_management/new_version_worker.rb'
  • 'app/workers/disallow_two_factor_for_group_worker.rb'
  • 'app/workers/disallow_two_factor_for_subgroups_worker.rb'
  • 'app/workers/emails_on_push_worker.rb'
  • 'app/workers/error_tracking_issue_link_worker.rb'
  • 'app/workers/export_csv_worker.rb'
  • 'app/workers/gitlab/bitbucket_import/advance_stage_worker.rb'
  • 'app/workers/gitlab/bitbucket_server_import/advance_stage_worker.rb'
  • 'app/workers/gitlab/github_gists_import/import_gist_worker.rb'
  • 'app/workers/gitlab/github_gists_import/start_import_worker.rb'
  • 'app/workers/gitlab/github_import/advance_stage_worker.rb'
  • 'app/workers/gitlab/jira_import/advance_stage_worker.rb'
  • 'app/workers/google_cloud/create_cloudsql_instance_worker.rb'
  • 'app/workers/group_destroy_worker.rb'
  • 'app/workers/group_export_worker.rb'
  • 'app/workers/group_import_worker.rb'
  • 'app/workers/import_issues_csv_worker.rb'
  • 'app/workers/integrations/irker_worker.rb'
  • 'app/workers/issuable/create_reminder_worker.rb'
  • 'app/workers/issuable_export_csv_worker.rb'
  • 'app/workers/issues/placement_worker.rb'
  • 'app/workers/members_destroyer/unassign_issuables_worker.rb'
  • 'app/workers/merge_requests/delete_source_branch_worker.rb'
  • 'app/workers/merge_requests/handle_assignees_change_worker.rb'
  • 'app/workers/merge_requests/resolve_todos_worker.rb'
  • 'app/workers/merge_worker.rb'
  • 'app/workers/namespaces/root_statistics_worker.rb'
  • 'app/workers/namespaces/schedule_aggregation_worker.rb'
  • 'app/workers/onboarding/user_added_worker.rb'
  • 'app/workers/packages/go/sync_packages_worker.rb'
  • 'app/workers/packages/npm/deprecate_package_worker.rb'
  • 'app/workers/project_destroy_worker.rb'
  • 'app/workers/project_export_worker.rb'
  • 'app/workers/projects/after_import_worker.rb'
  • 'app/workers/projects/git_garbage_collect_worker.rb'
  • 'app/workers/projects/import_export/parallel_project_export_worker.rb'
  • 'app/workers/projects/import_export/relation_export_worker.rb'
  • 'app/workers/projects/import_export/relation_import_worker.rb'
  • 'app/workers/projects/import_export/wait_relation_exports_worker.rb'
  • 'app/workers/projects/inactive_projects_deletion_notification_worker.rb'
  • 'app/workers/projects/update_repository_storage_worker.rb'
  • 'app/workers/rebase_worker.rb'
  • 'app/workers/repository_check/single_repository_worker.rb'
  • 'app/workers/repository_cleanup_worker.rb'
  • 'app/workers/repository_fork_worker.rb'
  • 'app/workers/snippets/update_repository_storage_worker.rb'
  • 'app/workers/upload_checksum_worker.rb'
  • 'app/workers/wikis/git_garbage_collect_worker.rb'
  • 'app/workers/work_items/import_work_items_csv_worker.rb'
  • 'ee/app/workers/abuse/new_abuse_report_worker.rb'
  • 'ee/app/workers/adjourned_project_deletion_worker.rb'
  • 'ee/app/workers/admin_emails_worker.rb'
  • 'ee/app/workers/analytics/devops_adoption/create_snapshot_worker.rb'
  • 'ee/app/workers/approval_rules/external_approval_rule_payload_worker.rb'
  • 'ee/app/workers/audit_events/audit_event_streaming_worker.rb'
  • 'ee/app/workers/ci/runners/export_usage_csv_worker.rb'
  • 'ee/app/workers/compliance_management/chain_of_custody_report_worker.rb'
  • 'ee/app/workers/compliance_management/framework_export_mailer_worker.rb'
  • 'ee/app/workers/compliance_management/pending_status_check_worker.rb'
  • 'ee/app/workers/compliance_management/project_framework_export_mailer_worker.rb'
  • 'ee/app/workers/compliance_management/standards_adherence_export_mailer_worker.rb'
  • 'ee/app/workers/compliance_management/update_default_framework_worker.rb'
  • 'ee/app/workers/compliance_management/violation_export_mailer_worker.rb'
  • 'ee/app/workers/create_github_webhook_worker.rb'
  • 'ee/app/workers/dependencies/export_worker.rb'
  • 'ee/app/workers/elastic/namespace_update_worker.rb'
  • 'ee/app/workers/elastic/project_transfer_worker.rb'
  • 'ee/app/workers/elastic_association_indexer_worker.rb'
  • 'ee/app/workers/elastic_namespace_indexer_worker.rb'
  • 'ee/app/workers/gitlab/export/segmented_export_finalisation_worker.rb'
  • 'ee/app/workers/gitlab/export/segmented_export_worker.rb'
  • 'ee/app/workers/group_wikis/git_garbage_collect_worker.rb'
  • 'ee/app/workers/groups/update_repository_storage_worker.rb'
  • 'ee/app/workers/llm/completion_worker.rb'
  • 'ee/app/workers/namespaces/cascade_duo_features_enabled_worker.rb'
  • 'ee/app/workers/namespaces/storage_usage_export_worker.rb'
  • 'ee/app/workers/repository_update_mirror_worker.rb'
  • 'ee/app/workers/requirements_management/import_requirements_csv_worker.rb'
  • 'ee/app/workers/search/zoekt/namespace_indexer_worker.rb'
  • 'ee/app/workers/work_items/rolledup_dates/bulk_update_handler.rb'
  • 'ee/app/workers/work_items/rolledup_dates/update_rolledup_dates_worker.rb'
Edited by Nourhan Hasan