Skip to content
Snippets Groups Projects

Deploy to Kubernetes namespace specified in CI template

Merged Tiger Watson requested to merge 27630-deploy-to-ci-specified-namespace into master
All threads resolved!

What does this MR do?

If an unmanaged cluster is selected for deployment and the CI template specifies a namespace (using functionality added in !20270 (merged)), use this namespace for the deployment.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

#27630 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Merge request pipeline #99133559 passed

Merge request pipeline passed for 12dc59fc

Test coverage 81.71% (0.00%) from 2 jobs

Merged by Grzegorz BizonGrzegorz Bizon 5 years ago (Dec 3, 2019 4:18pm UTC)

Loading

Pipeline #100349608 passed with warnings

Pipeline passed with warnings for 075a4ae4 on master

Test coverage 81.08% (0.00%) from 2 jobs
4 environments impacted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tiger Watson added 1 commit

    added 1 commit

    • 2bb7f7b3 - Use CI configured namespace for deployments

    Compare with previous version

  • Tiger Watson marked the checklist item Style guides as completed

    marked the checklist item Style guides as completed

  • Tiger Watson marked the checklist item Merge request performance guidelines as completed

    marked the checklist item Merge request performance guidelines as completed

  • Tiger Watson marked the checklist item Code review guidelines as completed

    marked the checklist item Code review guidelines as completed

  • Author Maintainer

    Hey @tkuah, can I trouble you for another review? No rush :slight_smile:

    Thanks!

  • Tiger Watson assigned to @tkuah and unassigned @tigerwnz

    assigned to @tkuah and unassigned @tigerwnz

  • Tiger Watson added 123 commits

    added 123 commits

    Compare with previous version

  • Thong Kuah assigned to @hfyngvason and unassigned @tkuah

    assigned to @hfyngvason and unassigned @tkuah

  • @tigerwnz This looks great! I left a few minor comments and questions :ping_pong:

  • assigned to @tigerwnz and unassigned @hfyngvason

  • Tiger Watson added 1 commit

    added 1 commit

    • 744199a0 - Use CI configured namespace for deployments

    Compare with previous version

  • Tiger Watson assigned to @hfyngvason and unassigned @tigerwnz

    assigned to @hfyngvason and unassigned @tigerwnz

  • Tiger Watson added 1 commit

    added 1 commit

    • 12dc59fc - Use CI configured namespace for deployments

    Compare with previous version

  • Hordur Freyr Yngvason approved this merge request

    approved this merge request

  • assigned to @grzesiek and unassigned @hfyngvason

  • Grzegorz Bizon approved this merge request

    approved this merge request

  • Grzegorz Bizon resolved all threads

    resolved all threads

  • Grzegorz Bizon mentioned in commit 075a4ae4

    mentioned in commit 075a4ae4

  • Thanks! Looks good to me!

    It is really difficult to reason about how we expand environment / kubernetes namespace name, we accumulated some technical debt there. I hope that we will make it more simple in the future somehow.

  • This merge request has been deployed to the GitLab.com environment gstg in GitLab auto-deploy version 12.6.201912111418-0b7e83cf853.029932d2cd5.

    A list of all the deployed commits can be found here.


    :robot: If this message is incorrect, please create an issue in the Release Tools project.

  • added workflowstaging label and removed workflowin dev label

  • This merge request has been deployed to the GitLab.com environment gprd in GitLab auto-deploy version 12.6.201912111418-0b7e83cf853.029932d2cd5.

    A list of all the deployed commits can be found here.


    :robot: If this message is incorrect, please create an issue in the Release Tools project.

  • added workflowproduction label and removed workflowstaging label

  • 🤖 GitLab Bot 🤖 changed the description

    changed the description

  • Please register or sign in to reply
    Loading