Deploy to Kubernetes namespace specified in CI template
What does this MR do?
If an unmanaged cluster is selected for deployment and the CI template specifies a namespace (using functionality added in !20270 (merged)), use this namespace for the deployment.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
Merge request reports
Activity
changed milestone to %12.6
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Steve Abrams ( @sabrams
)Bob Van Landuyt ( @reprazent
)Generated by
Danger Edited by 🤖 GitLab Bot 🤖marked the checklist item Changelog entry as completed
removed UX label
- Resolved by Grzegorz Bizon
marked the checklist item Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. as completed
marked the checklist item Style guides as completed
marked the checklist item Merge request performance guidelines as completed
marked the checklist item Code review guidelines as completed
Hey @tkuah, can I trouble you for another review? No rush
Thanks!
added 123 commits
-
2bb7f7b3...71c8f443 - 122 commits from branch
master
- c4136ec8 - Use CI configured namespace for deployments
-
2bb7f7b3...71c8f443 - 122 commits from branch
- Resolved by Grzegorz Bizon
I will re-assign this to @hfyngvason as he's also a domain expert :) Is that OK Hordur ?
I think we will definitely need
@grzesiek
to review this as well when ready
assigned to @hfyngvason and unassigned @tkuah
- Resolved by Hordur Freyr Yngvason
- Resolved by Grzegorz Bizon
- Resolved by Hordur Freyr Yngvason
@tigerwnz This looks great! I left a few minor comments and questions
assigned to @tigerwnz and unassigned @hfyngvason
- Resolved by Grzegorz Bizon
Thanks @hfyngvason! I've made some changes
assigned to @hfyngvason and unassigned @tigerwnz
assigned to @grzesiek and unassigned @hfyngvason
added teamDelivery label
mentioned in commit 075a4ae4
This merge request has been deployed to the GitLab.com environment
gstg
in GitLab auto-deploy version12.6.201912111418-0b7e83cf853.029932d2cd5
.A list of all the deployed commits can be found here.
If this message is incorrect, please create an issue in the Release Tools project. added workflowstaging label and removed workflowin dev label
This merge request has been deployed to the GitLab.com environment
gprd
in GitLab auto-deploy version12.6.201912111418-0b7e83cf853.029932d2cd5
.A list of all the deployed commits can be found here.
If this message is incorrect, please create an issue in the Release Tools project. added workflowproduction label and removed workflowstaging label
added groupenvironments label and removed groupconfigure [DEPRECATED] label