Skip to content

Allow checking out submodules in OpenBao setup

Alex Scheelrequested to merge
cipherboy-allow-checking-out-submodules-in-test-helpers into master

What does this MR do and why?

Allow checking out submodules in OpenBao setup

When setting up OpenBao in a fresh instance with no support for pre-compiled OpenBao binaries, git checkout will fail to check out the submodule. However, git clone does the right thing due to the passed argument.

See also: gitlab-development-kit#2035 (comment 2786805104)

Signed-off-by: Alexander Scheel <ascheel@gitlab.com>

References

Screenshots or screen recordings

How to set up and validate locally

  • podman run registry.gitlab.com/gitlab-org/gitlab-development-kit/gitlab-gdk-in-a-box:latest
  • podman exec ... --> ./bin/rspec ./ee/spec/services/secrets_management/permissions/list_service_spec.rb
  • See success this time.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

fyi: @gerardo-navarro

Merge request reports